Repository navigation
[PR] 2026 11 09 iot incompat notice upstream - #6015
ranxianglei merged 4 commits into
Conversation
iot-thinking issues its own extra compress/rewrite model call after every reply; both calls share one session lane, so the step keeps waiting seconds to tens of seconds after its first byte (measured: the extra request shape was 44% of one session's requests, p50 ~7s, and vanished when the plugin was disabled). Owners could not see the cause from bili's side. Register a fourth builtin notice (KDD ranxianglei#16 surface, no new channel): - src/notice-store.ts: iot-incompat id + dismissal allowlist - src/notices.ts: probeDshIotThinking scans dsh profile dirs for node_modules/dsh-plugin-iot-thinking (never throws; advisory) - src/web/i18n.ts: en/zh copy - tests: registry id/allowlist rows + hermetic detection/dismissal suite
Installed-but-disabled is the healthy state: the plugin's extra rewrite call is what produces the post-first-byte wait, and turning it off removes it. Gate the notice on the plugin's own effective switch instead of bare presence (missing/broken config keeps the plugin default, enabled). Verified on the owner's machine: installed=true, enabled=false ⇒ active=false.
… as catalog keys PR ranxianglei#6015 red CI (shards ubuntu/24/3, ubuntu/22/3, windows/22/4, all the same subtest): ranxianglei#1024 'every referenced key exists in both locales' failed with 'referenced key missing from zh catalog: package.json'. collectRefs()'s lenient bare-string rule (ranxianglei#5345) accepts any dot-quoted token as a live i18n reference; the new notices.ts probe writes the literals "package.json" / "config.json", which the rule misreads as keys. Drop tokens whose final segment is a file extension from that rule only — explicit t()/tr()/data-i18n references stay authoritative, and the two segments already proven to be key suffixes (summary.key, det.log) are kept out of the exclusion.
(ai: qwen/qwen3.8-27b) PR #6015 审核结论:可合并(人工合)。 已本地装齐依赖跑通定向测试 + typecheck;下面是结构化八问。 1. 是什么问题:两件事——①按 #6014 的要求给 dsh 的 iot-thinking 插件加 Web 面板冲突提示(它会在每次模型回复后串行发一轮额外压缩请求,拉高首字等待并造成锯齿状缓存命中);②顺手修 #5548 统一通知渲染循环漏加 2. 什么原因导致的:①是 #6014 报告的能力缺失(作者已按其建议实现「检测到已安装且启用 → 弹提示」);②是 #5548 落地时的真实缺陷——循环里 3. 影响范围与严重程度:①纯新增提示,仅当用户装了 dsh-plugin-iot-thinking 且未在其 config 关掉时才出现、可关闭,不装则完全无感;②影响面是「所有统一通知在 Web 面板不可见」——体验缺陷(通知形同虚设),非数据/可用性问题,定级偏 p2(能用、只是看不到提示)。注意:不修 ②,新的 iot 提示自己也显示不出来,所以两者必须一起上。 4. 怎么修复的:①把 iot-incompat 注册进 KDD#16 的统一 NOTICES 注册表( 5. 是否有回归问题:唯一行为变化是 ②把「内置通知不可见」改成「可见」,而这正是 #5548 批准设计的本意(旧值 = 全部 6. 是否破坏缓存:不涉及。纯展示层 + dsh 插件状态探测(fs stat/read),不碰压缩 / 前缀缓存 / 增量车道 / 水位。 7. 是否改了设计方向:不涉及架构转向。新通知严格落在 KDD#16 统一通知面(一个注册表 / 一套关闭 / 一套渲染),没另起炉灶;与 #2861 host-plugin 面、thirdparty-scan 关键词面不同症状不同机制,不会重复触发(dsh-plugin-iot-thinking 既不匹配 8. 是否引入了新的配置:不涉及。没有新增 env / BILI_* / 配置字段;只读 dsh 侧已有的插件目录与其 config.json。 一个非阻塞点(建议作者确认):安装检测是按 profile 扫 本地验证证据:全量装依赖后跑定向测试 CI 现状(镜像缓存实时读):30 项检查 0 failed / 14 pending,快速静态门已过(unused-exports、lifecycle-ledger-guard、pi-subagents-guard、test-import-graph、docs-sync 均 success),test 分片与 static-gates 仍在排队/运行中——最终绿红以 CI 为准。 判定:可合并(人工合)。方向正确(#6014 明确点名要这个能力且声明已完成开发)、diff 干净聚焦(7 文件 +154/-7)、测试有牙、无回归、唯一行为变化已如实披露。 |
(ai: vllm-qwen/qwen3.8-27b) CI red fixed — all 30 checks now pass on head What was red. All three failing shards died on the same subtest: Root cause. Fix (one commit, test file only, pushed to the PR branch): No source/runtime change, no new config, no behavior drift. Verified locally before pushing: reproduced the exact failure, then Note: the PR head is currently behind master (mergeable state 八问(结构化结论)
判定:CI 全绿,可进入正常 review/合并流程(提醒一句:分支落后于 master,合并前建议作者 rebase)。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.1116-master.63a4060 # this exact build
npm install -g billion-context@master # always the newest merged build
|
… to clean Follow-up sync: master advanced 5 commits (web/i18n/notice work, #6015 et al.) past the previous sync base; none touch src/launcher.ts or scripts/live-files.mjs, so this is a conflict-free auto-merge bringing the PR to mergeable_state=clean.
…incompatibility notice Master moved five commits (8 files) under the notice-registry surface: 1c069c6 adds `src/pck-notice.ts` plus `src/notice-store.ts`/`src/notices.ts` wiring, 65fcba1ba narrows the warning to enabled installs, 549bc54 restores the built-in notice banners' `.show` class, 8d202c3 stops the i18n ref scanner treating filenames like `package.json` as catalog keys, and 63a4060 is the PR merge. Zero overlap with this lane's 17 files; the only shared directory is `src/web/` and the two sides touch different files there (`i18n.ts`/`client.ts` upstream, none of mine). Nothing of mine was touched.
对应issue #6014
增加了与dsh-plugin-iot-thinking共用时的消息提示
防止出现首字几倍拉长和出现锯齿缓存却不知道问题出现在哪的情况:

效果图:

同时:修复了 #5548 统一通知渲染循环缺
.show类导致所有通知(内置/本地文件/远程 feed)在 Web 面板上始终不可见;