Skip to content

[PR] docs: fix stale storage-default comment in the CI test baseline preload - #4374

Closed
ranxianglei wants to merge 5 commits into
masterfrom
2026-10-23_preload-baseline-stale-comment
Closed

ranxianglei wants to merge 5 commits into
masterfrom
2026-10-23_preload-baseline-stale-comment

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

(ai: vllm-qwen/qwen3.8-27b)

What / why

Found while reviewing PR #4011 (which turned out to be superseded by 311c7968e / #4242 wave 3 — see that thread).

tests/preload-storage-baseline.mjs pins BILI_STORAGE_UNIFIED ??= "legacy" for every CI test file, but its header comment still claimed the production default was "shadow" (the interim #2815-era value). Since #3818 the default is "full". The stale wording misleads anyone reading why the baseline exists — and it is exactly this baseline-vs-default mismatch that made PR #4011's new full-mode test pass locally while failing on every CI lane.

Change (comment only, no behavior)

No code change; no config surface touched; no behavior change of any kind.

…-baseline (#4011 review)

The header claimed the production default was still "shadow" (the interim
#2815-era value). Since #3818 the default is "full", which made the comment
mislead test authors about what the legacy baseline actually overrides.
Add the lesson from PR #4011: suites whose assertions depend on a specific
storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline
overrides the production default in CI.
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-23_preload-baseline-stale-comment (48ac57a)

Latest build — install this exact version

npm install -g billion-context@0.0.6188-pr.4374.ceee46d

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
48ac57a billion-context@0.0.6188-pr.4374.ceee46d build
fcddc9d billion-context@0.0.6100-pr.4374.5205a1b build
3092c58 billion-context@0.0.6005-pr.4374.1ccf05b build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr4374.tgz
npm install -g package

Install instructions are refreshed on each push.

ci-check added 3 commits October 26, 2026 14:14
master window commits 293ae65/de5e03659 bumped kernel/package.json to
0.0.165 without regenerating the lockfiles; lock-sync re-resolution then
rewrites the stale recorded versions (root 0.0.163, kernel 0.0.164) and
fails. Pure recorded-version sync via npm install --package-lock-only;
no dependency or semantic change.
ranxianglei added a commit that referenced this pull request Nov 7, 2026
…-baseline (#4011 review)

The header claimed the production default was still "shadow" (the interim
#2815-era value). Since #3818 the default is "full", which made the comment
mislead test authors about what the legacy baseline actually overrides.
Add the lesson from PR #4011: suites whose assertions depend on a specific
storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline
overrides the production default in CI.

Picked up from PR #4374 for the CI/test-signal small-fixes batch.
ranxianglei added a commit that referenced this pull request Nov 7, 2026
…-baseline (#4011 review)

The header claimed the production default was still "shadow" (the interim
#2815-era value). Since #3818 the default is "full", which made the comment
mislead test authors about what the legacy baseline actually overrides.
Add the lesson from PR #4011: suites whose assertions depend on a specific
storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline
overrides the production default in CI.

Picked up from PR #4374 for the CI/test-signal small-fixes batch.
@ranxianglei

Copy link
Copy Markdown
Owner Author

(ai: sglang-gpu0/qwen3.8-27b) 已合入 master: 本 PR 的基线注释更正经 #5859 合入(848f59b)。本 PR 关闭以免重复。

@ranxianglei ranxianglei closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant