Repository navigation
[PR] docs: fix stale storage-default comment in the CI test baseline preload - #4374
Closed
ranxianglei wants to merge 5 commits into
Closed
ranxianglei wants to merge 5 commits into
ranxianglei wants to merge 5 commits into
Conversation
…-baseline (#4011 review) The header claimed the production default was still "shadow" (the interim #2815-era value). Since #3818 the default is "full", which made the comment mislead test authors about what the legacy baseline actually overrides. Add the lesson from PR #4011: suites whose assertions depend on a specific storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline overrides the production default in CI.
…help-merge sweep)
Contributor
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.6188-pr.4374.ceee46dThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4374.tgz
npm install -g packageInstall instructions are refreshed on each push. |
added 3 commits
October 26, 2026 14:14
…help-merge sweep)
master window commits 293ae65/de5e03659 bumped kernel/package.json to 0.0.165 without regenerating the lockfiles; lock-sync re-resolution then rewrites the stale recorded versions (root 0.0.163, kernel 0.0.164) and fails. Pure recorded-version sync via npm install --package-lock-only; no dependency or semantic change.
ranxianglei
added a commit
that referenced
this pull request
Nov 7, 2026
…-baseline (#4011 review) The header claimed the production default was still "shadow" (the interim #2815-era value). Since #3818 the default is "full", which made the comment mislead test authors about what the legacy baseline actually overrides. Add the lesson from PR #4011: suites whose assertions depend on a specific storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline overrides the production default in CI. Picked up from PR #4374 for the CI/test-signal small-fixes batch.
ranxianglei
added a commit
that referenced
this pull request
Nov 7, 2026
…-baseline (#4011 review) The header claimed the production default was still "shadow" (the interim #2815-era value). Since #3818 the default is "full", which made the comment mislead test authors about what the legacy baseline actually overrides. Add the lesson from PR #4011: suites whose assertions depend on a specific storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline overrides the production default in CI. Picked up from PR #4374 for the CI/test-signal small-fixes batch.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(ai: vllm-qwen/qwen3.8-27b)
What / why
Found while reviewing PR #4011 (which turned out to be superseded by
311c7968e/ #4242 wave 3 — see that thread).tests/preload-storage-baseline.mjspinsBILI_STORAGE_UNIFIED ??= "legacy"for every CI test file, but its header comment still claimed the production default was "shadow" (the interim #2815-era value). Since #3818 the default is "full". The stale wording misleads anyone reading why the baseline exists — and it is exactly this baseline-vs-default mismatch that made PR #4011's new full-mode test pass locally while failing on every CI lane.Change (comment only, no behavior)
BILI_STORAGE_UNIFIEDitself, because this baseline overrides the production default in CI.No code change; no config surface touched; no behavior change of any kind.