Repository navigation
[PR] test(session-resolve): un-shadow the #5719 msgid/store pins from the #5734 E5 checkpoint rung - #5857
[PR] test(session-resolve): un-shadow the #5719 msgid/store pins from the #5734 E5 checkpoint rung#5857ranxianglei wants to merge 1 commit into
Conversation
…5734 E5 checkpoint rung #5734 landed the self-checkpoint re-anchor rung (E5) first in the tagChanged branch of resolveSessionOrder with its own pin file (issue5719-self-checkpoint-reanchor.test.ts) but left tests/issue5719-msgid-lane-identity.test.ts untouched. That file's shared incidentHistory() fixture embeds bili's OWN authored-checkpoint identity header (conv="<raw id>"), so the E5 rung now preempts the msgid/store rungs this file exists to pin: T1/T8 fail deterministically on plain master (c45ac21, standalone run) in every CI shard carrying the file; T5/T6 additionally went vacuous (passing via E5 without ever querying the store). Give the fixture a FOREIGN conv declaration: the E5 gate misses exactly like any external quote (that boundary is pinned in E5's own suite), and each rung here fires again — T1 msgid-overlap re-anchor with the original reason strings, T5/T6 store rescue genuinely exercised, T8 store-null byte-only degradation to fork restored. No src/ change; no runtime behavior touched. This is a master-level born-red: it redacts every tree containing c45ac21 regardless of PR content (first exposed by PR #5849's shards: ubuntu 22 s2 / ubuntu 24 s2 / windows 22 s4, whose diff has zero intersection with this file). #5849's head lives in an external fork branch that cannot receive in-branch commits, so the fix lands here.
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.8454-pr.5857.0051f8eThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5857.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) PR #5857 review( 结论:可合并。 测试-only、最小 diff(单文件单 commit,+5/−1)、根因判断正确、负向边界已被 E5 自带套件钉住、本地定向 + pushed-head CI 双绿。未另开并行修复 PR(一 thread 一修 PR 规则满足,在原分支就地核对)。 查重:不重复——open issues/PR 无第二处针对本 thread 或 stale-pin 家族;#5851 只碰 src/session-resolve.ts,不同文件。 八问
验证证据
判定:可合并。 建议直接 merge;merge 后 #5849 的三个红 shard 会在其下次 CI 触发时转绿。 标签建议(判据 = 本 PR 自身 diff): |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) PR #5857 审查完成,结论:可合并。 已做:
交付:八问结构化 review 已回帖;triage 标签 |
What this fixes
Master-born-red:
tests/issue5719-msgid-lane-identity.test.tsT1/T8 fail deterministically on plain master (reproduced standalone at c45ac21, before this PR existed) in every CI shard carrying the file. First exposed by PR #5849's red shards (ubuntu 22 s2 / ubuntu 24 s2 / windows 22 s4) — whose diff (src/plugin.ts+ one new test file) has zero intersection with this file.Root cause: #5734 landed the self-checkpoint re-anchor rung (E5) first in the tagChanged branch of
resolveSessionOrder(src/session-resolve.ts:338), with its own pin filetests/issue5719-self-checkpoint-reanchor.test.ts— but left the older #5719 pin file untouched. That file's sharedincidentHistory()fixture embeds bili's OWN authored-checkpoint identity header (conv="<raw id>"at the first user cell), so the E5 rung now preempts the msgid/store rungs this file exists to pin:The fix
One fixture change: give
incidentHistory()a FOREIGN conv declaration (conv="${tag}-other"). The E5 gate then misses exactly like any external quote (that boundary is pinned in E5's own suite, acceptance 2), and each rung in this file fires again: T1 msgid-overlap re-anchor with the original reason strings, T5/T6 store rescue genuinely exercised, T8 store-null byte-only degradation → fork restored. All original assertions kept verbatim — no pin weakened.Verified locally, standalone: both issue5719 suites 14/14 green on this head (was 12/14 with only T1/T8 failing pre-fix).