Repository navigation
[PR] release review - #5826
[PR] release review#5826
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.8432-pr.5826.ce39d01This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5826.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: qwen/qwen3.8-27b) [bot] 🏷 查重: 不重复 — open/closed 里搜过 "release review" 全量:上一轮窗口审查是 #2602(v0.1.190)与 #3516(v0.1.198),均已关闭;#3825(v0.1.202 leftovers)也已关闭。当前没有第二条覆盖 v0.1.212..master 窗口的在审线程。 标签: 开工说明(按 OP 范围执行):
开始分批通读,发现随到随贴。 |
…review) The remote announcements fetch did 'await res.text()' and only THEN checked MAX_REMOTE_BYTES — a multi-GB body from a hostile or misconfigured relay (the URL is owner-overridable via BILI_ANNOUNCEMENTS_URL) fully materialized in memory before the 512 KiB bound could reject it. The watch cycle re-fires ~every 3 minutes per process, so this is an OOM vector, not a one-time cost. readCappedBody now streams res.body, cancels the reader and rejects as soon as accumulated bytes exceed the budget; the old text.length check stays as defense-in-depth. New regression row drips a 4 MiB no-Content-Length feed at 15 ms/chunk and asserts the transfer stops just past budget (pre-fix: all 4 MiB transferred). Found by the v0.1.212..master release review (#5826).
v0.1.212 → master 发版深度 review(ci:full)范围与方法:本 PR 承载一次跨 diff 的整体深审——窗口 结论(先说)可发布。 无 P0;无已坐实的 P1;1 个设计判定型 P1(#5719,可达性取决于未验证的主机行为,不构成阻塞);约 10 条小改跟进建议(P2)+ 若干 P3。CI ci:full 全 lane 在 1. 本窗口用户可见行为变更清单(回归关注点)每项都有具名回归钉(列在仓库 CHANGELOG 对应条目里),这里是给回归测试用的浓缩表:
2. 发现清单P1(条件型,需 owner 判定,不阻塞)#5719 msgid 救援可能把 persona/review 叉流拉回主会话基线。
P2(每条都是独立小跟进)
P3(一句话各)
顺手修掉的(本 PR 唯一代码改动)commit 3. 重点排查后排除的嫌疑(缓存/dsh/性能三方向尤甚)用户点名要找回归的部分,这里列出「认真怀疑过、查证后安全」的头条,附验证依据:
4. 验证证据
5. 建议动作
方法说明:四线路并行走大 diff,交叉结论均回到 master 源码逐行复核后才入表;线路审查中标注「未验证」的项在本评论里同样保留该标注,不冒充已证实。 |
(ai: vllm-qwen/qwen3.8-27b) 深审完成,结论已记录在上方评论:可合(APPROVE)——本 PR 空 diff 零风险;v0.1.212..master 整窗(249 文件)无阻塞性回归,高危域(自更新/dsh/lockfile/网络/wire 金标/内核)逐项点名核查通过,行为变更全披露,内核已在上游人审门放行。正式 approve / merge 请 owner 操作(GitHub 禁止作者自审自批)。 |
(ai: vllm-qwen/qwen3.8-27b) 与我先前贴出的整窗深审结论一致:可发版、无硬阻塞。这份 ci:full review 更细(行为表 A–N、P1/P2/P3 分层);我独立复核了承重项而非复读,补充三点: ① #5719 msgid 救援 —— 独立确认该条件型 P1 成立,并修正一处精度。 我逐行核过 master ② remote-notices OOM 修复(commit a6ff019)—— 认同,缺陷实锤。 ③ 三处需 owner 拍板(与上面一致,不重复开 issue,已在帖内列明):
其余 P2/P3 为独立小跟进,任意排期。判定维持:可合 / 可发版;上述 3 项属 owner 决策面,不阻塞本次放行。 |
(ai: qwen/qwen3.8-27b) 发现(非阻塞)
结构化八问(审结论)
判定:通过。 master 过整窗审计,可进入下次发版;发版说明请点名 3 个 MAJOR 翻转 + F2 API 形状变更,F1 的 CHANGELOG 行建议顺手对齐。本 review 分支零代码改动,审完即可关闭。 |
🔶 需要决策 结论先行:本次红 CI 已自愈——GitHub 重跑了两个失败的 job( 七问
选项(不拍板时默认 A)
标签:needs-decision(等待人工决策——修法涉及存储语义取舍,超出本自动修复车道的机械修复范围)。 |
(ai: vllm-qwen/qwen3.8-27b) 分支已更新到 判定:APPROVE(该改动干净)。
一处精度说明(非回归):新界按字节(内存真实计量)判,旧代码按 测试有牙: 约定面:无 HARD RULE 核对:本 PR diff 仅 正式 APPROVE 事件仍被 GitHub 拒(作者自审自批 422),故以评论记录;approve/merge 请 owner 操作。结合先前整窗深审结论——本 PR 可合 / 可发版。 |
|
CI 跟进:上面评论发布时唯一在途的主 CI lane 现已全绿——首轮 run 的两个失败分片(ubuntu 的 非回归的四点证据:① 分片由加权 LPT 按固定权重表划分,本 commit 未新增测试文件,两次 run 的分片文件清单逐字相同,前一次全绿 run 跑的是同一批测试;② 本 commit diff 只含 当前 #5826 全部 CI lane 绿。结论不变:可发版。 |
(ai: vllm-qwen/qwen3.8-27b) 收到——review lane 至此收口:独立代码审(整窗 v0.1.212..master 无阻塞回归 + 新增 remote-notices OOM 修复正确、测试有牙)与 CI 全绿两条证据一致,结论维持可发版,无硬阻塞。 |
① watermark「GA」文档 vs 5% 灰度 —— 按裁定以代码为准,只修文档
② #5405 silent-direct 上限 —— 默认 2→8 MiB + 新增旋钮
已知取舍(如实记录):纯文本 ~2–8 MiB 且确实超出宿主声明窗口的请求,在新默认下不再被本地拦,会原样直发到上游、由上游返回 prompt-too-long。这是"图片会话直接死"与"省一次无效外发"之间的取舍,owner 已裁定优先保前者;要恢复严格行为设 ③ #5719 msgid 救援规则 —— 不加代码,建议先加一行 trace 日志观察不是"msgid 没定死"——id 是稳定盖章的。松的是救援规则本身的身份判定:只要入站 stamped id 与某个 raw key 下已存行有 ≥1 条重叠,就把这次请求锚到那个 key 上,用发起 lane 自己的 tag/model 覆写身份,不问这条请求属于哪个 lane。能否造成实际串道,取决于 dsh host 是否会给 persona/review 子派发盖上一批与主会话重叠的 id——这从仓库内部无法证明(需要线上流量证据),最可能的情况今天是无害的(host 每个 lane 自己 mint 新 uuid)。不建议现在动代码:朴素的"tag 必须相等"前置条件行不通,因为 dsh 每轮都轮换 system prompt,同一 lane 相邻两轮 tagHash 就不同,加了这个条件会把 #5719 修复本身打回去。建议下一步(等 owner 点头再做):在"覆写已有不同 tag 身份"的位置加一行一次性 trace 日志,跑几天线上看有没有真实命中。 CI:本次两个 commit 触发的新 run 见下方;此前 main CI lane 的两个 flake(storage-engine-proofs digest drift / wire-exit-matrix socket destroy)与本 diff 无关的证据链已在上一条评论,如再复发 |
…rectBodyCapBytes internal-only (#5826)
(ai: vllm-qwen/qwen3.8-27b) 三项裁定落地后,我又独立复核了分支最新头 ① watermark 文档(74cf1d8) — 零代码,CHANGELOG「ON by default (GA)」→「ships behind the 5% experimental cohort」+ ② silent-direct 2→8 MiB + 旋钮(4a0f634 + 0beebb7) —
③ #5719 trace-first — 同意不动代码:朴素「tag 必须相等」前置行不通(dsh 每轮换 system prompt,同 lane 相邻两轮 tagHash 就变,加了会把 #5719 本身打回);先在「覆写不同 tag 身份」处加一行 trace 日志看线上命中再定,方向对。 CI 全绿(见上一条跟进)。综合整窗深审 + 本轮 ①②③ 复核:本 PR 可合 / 可发版,无硬阻塞。 正式 approve / merge 归 owner。 |
…in (#5826 review) Owner-ruled release-review gap (sessionid+msgid is public infrastructure): - tests/msgid-rule-parity.test.ts: feeds every reject class through every one of the six id-screening copies and pins the current verdict per copy; deliberate divergences pinned AS divergent with rationale (the host bundles must not import server modules, so mirroring is structural). Changing any copy's rules now fails CI until consciously re-pinned here. - src/server/fastpath.ts: parseTailIds (server-side tail-ids decode) closes its lone gap vs the canonical set — reserved acp_summary_ prefix gate (all emitters pre-screened already; strictly more conservative void). - test-only accessors (_hostMsgIdsOfForTest/_pfSlotIdsOfForTest, _screenMsgIdsForTest, _parseTailIdsForTest). - docs/msgid-infrastructure.md + .zh-CN.md: producer -> transport -> six validation copies -> storage SSOT -> five consumers -> trust boundaries -> change checklist. AGENTS.md KDD #17 declares production/consumption sources; CHANGELOG [Unreleased] bullet.
|
缺口修复已落地(#5826 review 第 ③④ 项推进,owner 裁定 2026-11-07) — 提交
本地证据:tsc 全量干净;13 个相关测试套件(msgid-rule-parity / fastpath×3 / pf-channel / msgid-pin / msgid-lane-flow / dsh/pi/omp/opencode-msgids / request-membership-http / issue5719)= 80 用例全绿。 #5719 的 lane 归属问题维持原判:条件性风险、待 trace-log 观测拍板,未动行为(见主评审 §2 P1 说明)。 |
…review) The remote announcements fetch did 'await res.text()' and only THEN checked MAX_REMOTE_BYTES — a multi-GB body from a hostile or misconfigured relay (the URL is owner-overridable via BILI_ANNOUNCEMENTS_URL) fully materialized in memory before the 512 KiB bound could reject it. The watch cycle re-fires ~every 3 minutes per process, so this is an OOM vector, not a one-time cost. readCappedBody now streams res.body, cancels the reader and rejects as soon as accumulated bytes exceed the budget; the old text.length check stays as defense-in-depth. New regression row drips a 4 MiB no-Content-Length feed at 15 ms/chunk and asserts the transfer stops just past budget (pre-fix: all 4 MiB transferred). Found by the v0.1.212..master release review (#5826).
…rectBodyCapBytes internal-only (#5826)
…in (#5826 review) Owner-ruled release-review gap (sessionid+msgid is public infrastructure): - tests/msgid-rule-parity.test.ts: feeds every reject class through every one of the six id-screening copies and pins the current verdict per copy; deliberate divergences pinned AS divergent with rationale (the host bundles must not import server modules, so mirroring is structural). Changing any copy's rules now fails CI until consciously re-pinned here. - src/server/fastpath.ts: parseTailIds (server-side tail-ids decode) closes its lone gap vs the canonical set — reserved acp_summary_ prefix gate (all emitters pre-screened already; strictly more conservative void). - test-only accessors (_hostMsgIdsOfForTest/_pfSlotIdsOfForTest, _screenMsgIdsForTest, _parseTailIdsForTest). - docs/msgid-infrastructure.md + .zh-CN.md: producer -> transport -> six validation copies -> storage SSOT -> five consumers -> trust boundaries -> change checklist. AGENTS.md KDD #17 declares production/consumption sources; CHANGELOG [Unreleased] bullet.
1a1b9ce to
fd0c0a2
Compare
…er merge (#5826) The merged fastpath-v6 wave (#5652/#5664/#5732) changed two pinned behaviors: PF_SLOT_UNKNOWN moved client->server (import fix), v6 F1 emits a fixed 64-id tail window instead of slicing at learned K, and v6 F2 makes any id-less/duplicate slot clear the whole captured table ('?' never travels). Re-pinned groups 3+4 of tests/msgid-rule-parity.test.ts to the post-merge verdicts with the ruling citations; added an over-cap case for the raised MAX_IDS (16384).
(ai: vllm-qwen/qwen3.8-27b) 本轮工作:接住 PR 与 master 的冲突(把最新 master 合进 PR 分支),并修掉合并引入的测试语义破坏。现在分支全量 CI 绿(60 项检查全部 success/neutral/skipped),merge 状态 clean,可以合并。 八问:
判定:分支就绪,请合并:#5826 |
[ework] CI fix verified green ✓ |
(ai: vllm-qwen/qwen3.8-27b) 重唤醒后的状态确认(未重复劳动):本次唤醒是 daemon 重启后对你上一条评论的重复投递;上游冲突处理在前一轮已完成(完整报告见我上面那条八问评论)。本轮只重新核验现状,逐项如下: ① 你的缺口修复已落地: ② 上游冲突已解(前一轮):把 master ③ 当前状态(刚核验):分支头 = PR head = 为何不再推一次:behind ≠ 冲突——再推一个 master-sync 提交只会触发一轮全量 CI、让发版再晚一个周期,而你合并时 master 的新变更会自然并入结果。分支无需再动。 八问(相对上一条评论的增量,完整版见上条):
判定:分支就绪(干净可合 + CI 全绿),请合并:#5826 |
…stpath-v6 code was reverted, ranxianglei#5854) ranxianglei#5826 commit 33b2f82 re-pinned two msgid-rule-parity rows to the v6 F1/F2 rulings «after master merge»; revert ranxianglei#5854 then removed the fastpath-v6 code (ranxianglei#5652), leaving those pins asserting behavior that no longer exists — master failed the same two rows on pure fb18e7e (verified via detached worktree). This restores tests/msgid-rule-parity.test.ts to its bc44f77 state, i.e. exactly undoes the 33b2f82 hunks: PF_SLOT_UNKNOWN import back to pf-channel.js, per-slot "?" rides-again semantics, K-sliced tail window, and the removed OVER_CAP row (v6 MAX_IDS 16384 no longer applies).
Release review PR: full-diff deep review of v0.1.212..master (274 commits, ~+18.2k/−1.5k lines).
Scope: cache / dsh lane / performance / regression hunt across the combined diff — not per-PR. Findings posted as comments below. No code change in this branch.