Repository navigation
[PR] spawn path: log the blocking integrity-scan phase before it starts; correct stale BILI_STORAGE_QUICK_CHECK docs - #4946
ranxianglei wants to merge 8 commits into
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.7121-pr.4946.28ad1a2This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4946.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复。 本 PR 是 #4940 提案 ②(扫描阶段可观测)+ ④(成本文档勘误)的交付件(见 #4940 floor 4)。逐一核对在途 PR:#4852(已并入 master,#4609)修的是「>512 MiB 阻塞启动」根因本身,不同范围;其余在途 storage 类 PR(#4936/#4924/#4914/#4888/#4800/#4685/#4628)均不触碰 integrity-scan 日志或 标签: scope/storage / p3 —— 改动落在统一存储开库自检路径(一行 info 日志)+ 配置文档勘误;本 PR 自身是观测性/文档级小改(父 issue #4940 保持 p2)。 这是 agent 交付的 [PR],我不重做实现,走审核流程:拉分支核对代码、验证 CI、按八问给结论。当前状态:build 作业已产出测试构建( |
(ai: vllm-qwen/qwen3.8-27b) PR #4946 审核结论 — 可合并(等你 merge) 独立核查(全部在 rebase head
八问:
一个非阻断观察:新测试 #7 钉住了日志行存在性、格式(MiB+页数)与 opt-out 静默,但无法钉住「先于扫描开始」的顺序(open() 内没有其他日志锚点可比序);该顺序由源码语句顺序保证,肉眼可核,可接受。 判定:可合并。 满足 auto-merge 门禁各项(单模块 fix+docs、回归测试复现意图且通过、rebase head 绿、diff 干净每行相关、引用 #4940、未触碰 load-bearing infra);行为变更披露已在 PR 正文(新增一条 info 日志行,无默认值/阈值/时序/wire 变化)。合并权在你:#4946 |
|
(ai: vllm-qwen/qwen3.8-27b) |
[bot] 🏷 Merge-guard sync 完成:已将 origin/master 合入 PR 分支(期间 master 又落了新提交,共同步两次),零冲突,合并后本地 typecheck 干净。head 现为 112104a,GitHub API 确认 mergeable、不再 behind(mergeable_state 已从 behind 转为 blocked,CI 正在跑新 head)。结果评论已发到 GitHub PR:#4946 (comment) |
…h a sparse-padded store (#4940)
|
(ai: vllm-qwen/qwen3.8-27b) Merge-guard re-sync: merged origin/master (~200 commits since last sync, incl. #5097/#5010) into this branch on top of the new test commit 8f332ee — zero conflicts, local typecheck clean. Head is now a59b03a, no longer behind master; mergeable with no conflicts, checks re-running on the new head. |
(ai: vllm-qwen/qwen3.8-27b) CI 自动修复结论(attempt 2/2):继承性红,本分支零代码改动,已触发失败分片重跑,等结果。 验证过程(证据先行,不是照抄转发):
八问:
另注:分支现落后 master 30 个提交——那是 merge-guard 车道的事(此前已派过),且同步 master 也去不掉这个 flake(master 本身就带着它),CI 车道不动它。 判定:等 attempt 2 重跑结果。转绿 → 待你合并(合并前 merge-guard 会再同步一次 master);若再现同一 #5140 签名 → 属 #5144 侧待处置的既有 flake(#4599 已立项跟踪),本自动修复车道无可修的决策点,按政策不为 CI 问题另开 issue。 |
|
(ai: vllm-qwen/qwen3.8-27b) Merge-guard re-sync: merged origin/master (~110 commits since last sync) into this branch — zero conflicts, local typecheck clean. Head is now f94d2b5, no longer behind master; mergeable with no conflicts, checks re-running on the new head. |
|
其中文档修正已随最终轮次的 CONFIGURATION/env seed 同步落入 master;日志提示部分被取代。冗余关闭。 |
Part of #4940 — proposals ② (phase observability) + ④ (documented cost). Proposal ① (configurable spawn budget) awaits the owner's A/B/C decision in the issue thread; if approved it extends this same branch (one issue → one PR).
Changes
1. Announce the synchronous integrity scan before startup blocks on it (
src/storage/store.ts+ regression test)UnifiedStore.open()'s sync branch (stores ≤512 MiB, verdict-cache miss), oneinfolog line now fires BEFOREPRAGMA quick_check:[storage] integrity quick_check started for <path> (<MiB>, <N pages>) — synchronous pre-migration scan; startup stays blocked until it finishes (#4940)...., N bytes — EMPTY) can no longer be misread as a hung child — the scan phase is visible, with the exact size/page count needed to estimate its duration.2. Correct stale BILI_STORAGE_QUICK_CHECK docs (
website/config-reference/env-only.yaml→ regeneratedCONFIGURATION.md/CONFIGURATION.zh-CN.md, plusLIFECYCLE.md)index.db.chkverdict cache (keyed by schema + index.db/-wal stats) skips unchanged file sets; measured cost from [PR] fix: refuse oversized degraded direct-sends using the lane known window (#4934) #4940 (4.96 GB @ 4 KB pages: ~54–73 s cold under memory pressure, ~10–15 s warm, bound at ~45 µs/page); and that pre-[Bug] 0.1.205+: open-time quick_check is O(index.db) — 14 GB takes 260 s, so the 60 s spawn budget always kills the child and the host stays on direct | 0.1.205+ 开库 quick_check 使启动变成 O(库大小):14GB 库 260 秒 → 必超 60 秒 spawn 预算 → 整生命周期直连 #4609 releases can exceed the 60 s native spawn budget on a multi-GB store's first start (escape hatch:BILI_STORAGE_QUICK_CHECK=0).3. Pin the REAL 512 MiB sync/async dispatch boundary (
tests/storage-integrity-cache.test.ts)integrityModeFor— while the SQLite page count stays tiny), then asserts open() takes the BACKGROUND path ("background quick_check started … over the 512 MiB sync threshold"), runs NO synchronous rescan, and lands a cached ok verdict. Exercises the real threshold constant instead of only the test-override seam used by the existing large-store test.Behavior-change disclosure
infolog line at startup on the sync integrity-check path (≤512 MiB store, cache miss). No defaults/thresholds/timing changed; no config surface added; no wire/message-shape changes.Verification
npm run typecheckclean on the rebased head (branch re-synced with master merges through c499b14; the merged store.ts changes are in fork-lineage paths, untouched by this PR).tests/storage-integrity-cache.test.ts8/8 (incl. the both-directions announce test and the real-boundary dispatch test),tests/storage-unified.test.ts+tests/store.test.ts43 pass / 1 gated skip / 0 fail. Full suite = remote CI.