Repository navigation
[PR] fix: initialize fork ledgers atomically before publication - #5044
ranxianglei merged 1 commit into
Conversation
|
(ai: anthropic/claude-opus-4-8) Independent verification of this patch, run from a clean checkout of baseline master ( Baseline reproduces the MAJOR finding. With this PR's On this head, all fork/persistence lanes pass locally (Linux, Node 25):
One local failure is pre-existing environment noise, not caused by this patch: Crash-recovery path read-through: Remaining gate for merge is operational: the remote |
|
(ai: anthropic/claude-opus-4-8) @kuviki — one operational ask from the maintainer side: We've finished an independent review of this patch (see the verification comment above: baseline reproduces the MAJOR finding, this head is green across all fork/persistence lanes plus typecheck/build). No code defects were found — the fix itself is complete as-is. If you could toggle "Allow edits and suggestions from maintainers" on for this PR (branch update settings), that lets us push any follow-up fixes directly onto your branch if anything later surfaces during release validation. Not required to merge — just makes the remaining CI-validation route smoother (the skipped Thanks again for picking up the release-review finding so quickly! |
|
勾上了 |
|
(ai: anthropic/claude-opus-4-8) @kuviki — 进展同步:你的修复已通过 maintainer 的独立验证(见上方验证评论)。为了让这份补丁立即拿到完整的远端 CI 矩阵裁决(当前这个面向 #4982 release 分支的形态下,test-matrix 三个车道因 base 分支触发规则被跳过,version-guard 也因非 release 命名分支携带 release 版本号而结构性红),maintainer 决定在 master 上镜像一份内容完全相同的 PR 承载 CI 裁决。你的署名保留在 commit 作者与 Co-authored-by 中,你的 #5043/#5044 是问题的正式记录源。**两个 PR 谁先合入即可,另一个随后关闭;如果 #4982 这条线先行,#5044 并入 release 分支时在 release 侧跑的矩阵同样算数。**谢谢! |
Fixes ranxianglei#5043 Regression review: ranxianglei#4982 (comment 6447703837, MAJOR). Co-Authored-By: Cury <13548063+kuviki@users.noreply.github.com>
58d0d0c to
4bf931c
Compare
|
(ai: anthropic/claude-opus-4-8) Owner-decided consolidation: this PR is now the single vehicle for the fix. Changes applied under your maintainer-edit permission:
Consequence at merge time: master gets the fix now (ships in v0.1.210+). The open v0.1.209 release candidate (#4982) would NOT carry this fix unless someone additionally cherry-picks it into the release branch - an owner call at merge time. Mirror PR #5045 (identical patch on master) was closed as superseded by this PR. The verification evidence posted earlier applies byte-for-byte to this head: baseline RED on old master (parent sparse ledger seqs [0,3,4] reproduced dense child rows [0,1,2]); green at head across plugin-fork 54 / issue4982-fork-lineage-conflict 18 / issue4910 1 / seq-ledger-pr3 4 / issue4730-fork-live-seq 2 / storage-backend-contract 7 (+1 real-MySQL skip) / bounded-storage 11 / storage-json-writer-off 3 / fork-clone-media-refcount 3 / proxy-persist 23, plus clean typecheck and build. |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.897-master.226c338 # this exact build
npm install -g billion-context@master # always the newest merged build
|
(ai: vllm-qwen/qwen3.8-27b) 查重结论:不重复。#5044 是 bug #5043 的修复载体,已 supersede 同补丁镜像 PR #5045(已关);membership/billing 的 #5042 明确分开。本 PR 是该修复线的单一正式记录源。 状态核实(git 实测,非转述):PR 已合入 master —— merge 以下是对实际 diff(单 commit,10 文件 +594/-69,其中 7 个生产文件)的独立审读——未照抄上方 floor 1 的结论,逐文件重读后给出自己的判断: 结构化八问
测试有效性:新增 判定:独立代码审读未发现缺陷,同意该修复正确且打到根因(源头原子化,而非在传输层掩症状)。无需进一步动作——已合入 master 与 v0.1.209,全量回归裁决以远端 CI 在已合并 head 上的结果为准(随合并已跑过)。分类记档:bug · scope/storage · p1(数据丢失类);因条目已合入/关闭且 owner 已拍板,未再对已关闭项追加标签操作。 @kuviki 修复已落地 master 与 v0.1.209,谢谢快速跟进 release-review 的发现。 |
[bot] (ai: vllm-qwen/qwen3.8-27b) 状态汇报(进程此前因长时间无输出被系统多次强制重启,现已恢复): 工作已完成,无待办。 本 PR(#5044,修复 #5043)的独立审核已在上方那条 核实的落地状态(git 实测,非转述):
分类记档:bug · scope/storage · p1(数据丢失类)。 说明:floor 13 之后的连续重启都是系统层面的进程挂起重连,不是本 issue 出现了新输入或新工作项——本线程自审核完成后没有新增人类评论、没有新的 CI 状态需要处置。无需进一步动作,此条仅作收尾确认。@kuviki 修复已落地 master 与 v0.1.209,谢谢快速跟进 release-review 的发现。 |
Fixes #5043
Follow-up to the persistence findings in #4982 (#4982 (comment)), targeting #4982's branch
2026-10-27_release-v0.1.209directly. The membership/billing follow-up #5042 remains separate.Summary
Reproduction
On baseline master b0b0e66 (package 0.1.208), the actual HTTP
/__bili/plugin/forkendpoint returned 201 but converted parent live seq[0,3,4]into child[0,1,2]. The regression includes inherited compression blocks, stable refs, and ordinary save/reload. A separate SQL-contract regression exposed stale dense snapshot/tail pointers after remapping.Validation
git diff --check: passed.Limits and review boundary
Linux Node 24.22.1 only; Windows and Node 22 await remote CI. Full-suite verdict must come from remote CI on this pushed head, not local targeted results. No kernel/version, package/version, configuration-schema, release-workflow or deployment changes. This touches storage and identity logic: draft for human review, not an auto-merge request.
Target correction and revalidation
The original master target was incorrect and is now corrected to #4982's release branch. Head
58d0d0c8e9e153a31fa12af90c008c1a852dcdedpreserves existing history with an additive merge commit; no force-push. Relative to release head2f1828a, the diff is exactly the original 10 fix files (+594/-69), with an identical patch-id. Release/version metadata and the unrelated draining-twin test are unchanged from the release branch. Inherited master cleanup commits remain visible in ancestry but contribute no unrelated file changes to this PR.Revalidated on the release-based tree: 107 targeted tests (105 passed, 2 real-MySQL-gated skipped), typecheck and build passed. Remote CI for the updated head/target is separate evidence and not yet claimed green. Human merge into #4982 remains required; this PR does not merge or publish the release.
Remote CI limitation
On updated head
58d0d0c, CI run 40690041335 ended with a version-guard failure before the base correction. That guard comparesorigin/master...HEAD -- package.json, so it sees the release branch's inherited version 0.1.209 on this non-release-named contribution branch. Relative to the actual target release branch, package/version metadata is unchanged. The test/static matrices were skipped; this is not evidence of a code-test pass or regression. The other 13 workflows completed successfully.The current CI pull_request base allowlist does not include release branches, and edited/base-change events do not launch this workflow. Changing from draft to ready does not resolve the base/guard mismatch. Maintainer guidance is needed for the supported validation route. No CI rules, release metadata or branch protections were changed to bypass this gate.