Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。本 PR 是 #4767(多图重建时每个幸存 core 重发全部 N 张图)的 host-scoped 子任务;当前没有其它 open PR 触碰同一 producer 路径( 标签: bug, codex, p1, scope/wiring(+已有 pr)——缺陷修复、wire 接线面;事故由 Codex 车道报告;p1 按 owner 2026-10-19 修订(缓存泄露类:26×26 图片重发 = 上下文失控增长,实测 6.2 MiB→69.8 MiB 单帧)。 审核进行中:外部贡献者 PR,按规范走独立全量审查(自己读 diff、既有行为回归清点、测试有效性),结论将以结构化八问跟进。 |
(ai: vllm-qwen/qwen3.8-27b) PR 审核结论(独立审核,非复述 issue)方向关(①):打到了本条产线的根因。#4767 的 N×N 图片重复有两个宿主侧产线:全量编码路径(无 projection 时走 回归关(②)——diff 触碰路径(
高危模式逐项:无 fail-fast 变吞错、无阈值/时序漂移、无意外输出格式变化。 代码关(③):命名达意(run/sources/flush),无死代码,注释讲为什么并带 #4767 出处,风格与仓库一致,无新依赖,函数短小。外部提交从严清单全项通过。 测试关(④):6 个新测试全部 deepEqual 带牙——断言精确 wire item 含 annotations/detail 字段,覆盖 1/2/26 图、双适配器文本协议、工具图边界两侧、相同图实例、空历史+普通邻居、摘要载体隔离;负向控制(相邻异源载体不得丢后续图片)满足 #3617 双向门禁纪律。独立复跑:responses-tool-images + issue3400-image-rescale + issue564-responses-ordering + responses-empty-messages + responses-plugin-dev-position 51/51 通过;typecheck、生产构建、 diff 整洁度(⑤):2 文件 +103/−3,每一行都与本 PR 目的相关,无跑题/空白噪声。 结构化八问
判定审查通过,可合入——两个前置条件:(a) pushed head CI 若红,按 #4599 协调流程处理(master 红则 merge ci-fixes,自红则自修),结果回本帖同步。 |
|
(ai: vllm-qwen/qwen3.8-27b) Review verdict: mergeable as a scoped partial fix (full structured review in #4767). Verified independently on head affc3fb:
One finding to make explicit (already noted in the issue thread): the batching gate Also tracked separately: #4775 — the #4150 kernel fix (d9110fb) + judge-pin flip (533eb91) are stranded on branch 2026-10-21_issue4150-responses-image-drop and never landed in master or any release tag; the kernel work for #4767 should absorb them (the pin flip MUST travel with any codec behavior change or the master judge goes red). |
(ai: vllm-qwen/qwen3.8-27b) Cross-check complete — the adjacent-shape residual is confirmed, independently reproduced at head 独立实测(合成夹具,与测试套件同构,无模型调用):
机制核对: 对我此前结论的范围修正:「解锁全量编码车道」说大了。合并后去重仅覆盖「载体拆核独占一个单一来源 user run」的场景;run 中有任何相邻独立 user 项(含父 issue 自身的复现形态)维持合并前的 N×N 行为,直到 #4767 下获批的 kernel 源所有权工作落地。其余判定不变:零回归(fallback 路径与合并前字节一致)、生效处严格改进 → 仍作为范围受限的部分修复可合(人工合入)。 建议补进 PR 正文的显式残余声明(供作者粘贴,使缺口不读线程也可发现):
#4775:已知悉——#4150 搁浅修复 + judge pin 翻转归属 #4767 的 kernel 决策(pin 翻转必须随任何 codec 行为变更走,否则 master judge 红);对本宿主侧 PR 无影响,此处不再另立项。 八问增量(相对上轮结论)
判定维持:可合(人工合入),范围受限的部分修复;最终可合性仍以 pushed head CI 转绿 + owner 知悉上述范围边界为准。 |
(ai: vllm-qwen/qwen3.8-27b) CI 状态同步(第 3 轮):head
14 条失败全部落在 master 已处置:按 #4599 协调流程 merge 预期残留:opencode-inline(在册簇⑤,断言需平台分支、语义对齐待 owner 裁决)可能在重跑后仍单独红——若出现,按 #4599 先例归口该 issue,不构成对本 PR 的 blocker。 审核结论不变(见上轮八问):可合入的范围受限部分修复——wire 变更按惯例留人工 review 把关;残余边界(相邻独立 user item 的 N×N 保留至 kernel 源所有权工作落地)建议作者把上轮给出的 Residual 段落补进 PR 正文。等重跑转绿即满足 CI 前置条件。 |
Retain exact source-part ownership when surviving cores are reminted or split by a summary. Cover partial folds, raw resends, short-view recovery, genuinely new identical images, cold loading, and byte-exact archived-image retrieval.
…-branch; merge-guard)
|
(ai: vllm-qwen/qwen3.8-27b) Synced master into this branch (merge commit cbf9a3c, clean — no conflicts); branch is up to date with master and mergeable again, CI is running on the new head. |
…-branch; merge-guard)
|
Landed via batch PR #6464 (merged) — closing as superseded. |
(ai: openai/gpt-6)
A partial compression block can resurrect the first image instead of its surviving second image; reminted cores can also expand each image back into the whole original multipart carrier. Bind projected user cores to exact source parts and rebuild their current layout before full or projection-based encoding. Preserve caption metadata, image detail, source order and summary position. Complete unchanged carriers remain verbatim.
The regression exercises real blocks through full/short/full raw resends, genuinely new identical uploads, SessionStore cold loading, byte-exact archived-image retrieval and another resend. It also checks 1/2/12/17/26-part remint cases, partial survivors, adjacent carriers and identical pixels with different detail. All original PR tests are retained. The repair changes host projection/encoding; raw-kernel codec defect pins and kernel instance-identity policy are unchanged. Refs #4767.
Validation on head 54ae0fd, synchronized with upstream e4cc685: typecheck, build and 45 targeted cases pass, zero skips. Earlier integrated synthetic real-client/provider checks retained the memory code and image conclusion after compression. Full CI and original production-session recovery remain unverified.
The current diff contains only the host module and two test files. No kernel/configuration/version change. Existing contribution history is preserved with additive commits.