Repository navigation
[PR] fix(ci): build acp-kernel in the mysql-contract lane (sub-defect B of #4326) - #4330
Closed
ranxianglei wants to merge 1 commit into
Closed
ranxianglei wants to merge 1 commit into
ranxianglei wants to merge 1 commit into
Conversation
#4326-B: since #4177 the contract suite reaches acp-kernel through backend.ts -> store.ts -> runtime-status.ts -> knobs.ts -> config.ts, but this job never built the file:-linked kernel, whose dist is not committed — every fresh checkout died at import resolution. Build the kernel like scripts/run-ci-tests.mjs does in its pretest; pi-subagents is not in these files' import graph (verified).
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.5135-pr.4330.7394ed5This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4330.tgz
npm install -g packageInstall instructions are refreshed on each push. |
This was referenced Oct 22, 2026
This was referenced Oct 22, 2026
This was referenced Oct 22, 2026
Closed
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers sub-defect B of #4326 (referenced, not closed — sub-defect A lands via #4174, and master goes fully green only once both merge).
Problem
The
mysql-contractjob in.github/workflows/ci.ymlruns the two storage contract suites directly from source, with NO build step. Since #4177 (1da8eca68, durability trio) addedstore.ts -> runtime-status.tsto the import graph, those files now reachacp-kerneltransitively viabackend.ts -> store.ts -> runtime-status.ts -> knobs.ts -> config.ts.kernel/distis not committed andnode_modules/acp-kernelis afile:-link intokernel/, so EVERY fresh checkout dies at import resolution withERR_MODULE_NOT_FOUND ... acp-kernel/dist/index.js— deterministic, reproduced locally on a clean install (it is not a cache-state problem).Other lanes are unaffected:
scripts/run-ci-tests.mjsbuilds kernel + pi-subagents in its pretest, the e2e/registry/image lanes runnpm run buildor typecheck first, andci-theorem.yml(same no-build shape) imports onlykernel/src/*sources, so it resolves fine.Fix
One step added to the job:
npm --prefix kernel run build(same command as the rootpretesthook). pi-subagents is NOT in these two files' import graph (verified: the suite passes withpi-subagents/distabsent), so it is deliberately not built here.Verification
npm install --ignore-scripts: before the fix both files die at import with the exact CI error signature; after adding the build step,node --import tsx --test tests/storage-backend-contract.test.ts tests/storage-backend-knob.test.tsis green (sqlite lane — 12 tests, 11 pass, 1 skip = the DSN-gated mysql test). The mysql DSN assertions are untouched by this diff; CI's mysql:8.0 service container covers them.Behavior change
None outside CI: no runtime, config, wire, or persistence change. The mysql-contract lane gains ~10-20s per run.
Note: the test-shard lanes on this PR's head stay red until #4174 merges (sub-defect A, already fixed there); the mysql-contract check itself turns green with this PR.