Repository navigation
[PR] feat: dsh-context coexistence — own tab name, softer banner with repo link, host-plugin contract docs (#4319) - #4327
ranxianglei wants to merge 3 commits into
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.5350-pr.4327.6d6c05bThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4327.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复 —— 本 PR 是 #4319 的唯一实现入口(该线程五条建议全部收敛于此);本审核发现的 master 红 CI 问题已有记录在案(#4326,修复在途 #4174/#4330),未另立条目。 审核结论摘要代码、测试、契约文档本身通过审核,无需返工;但发现一个流程级阻塞项:与在途 PR #4238 就同一个 tab 命名问题给出互相矛盾的解法,两者不能按现状同时合入——合并顺序需要你拍板(见下)。除此之外没有缺陷。 ① 方向关 —— 与 #4238 的冲突(唯一阻塞项)同一症状(两个同名「上下文」tab)先后有两个拍板、两个 PR:
矛盾点在默认标签值:两者都合入的话,后合入者必然破坏先合入者的文档化默认行为(#4238 的 CONFIGURATION.md 写明内置名「上下文」),且二者在
顺带指出一个流程缺口:#4319 分诊时的查重声明为「不重复」,但当时 #4209/#4237 + 在途 PR #4238 已在处理同一个 tab 重名症状——分诊只看到了创建该 tab 的 #3862,漏掉了处理重名的那一批。本次审核把两条线程对照补齐了。 ② 回归审查(既有行为清点)
③ 代码审查(主关)10 个文件逐行通读(+91/-17):
③b 契约文档 vs 代码核对(本 PR 的核心交付)README 新增小节逐条对源码核实:
④ 测试有效性既有断言是更新而非删除(label pin 从「上下文」改为「压缩代理」),无恒真断言;行为变更(改名、措辞、链接渲染)都有测试钉住。 ⑤ diff 整洁度10 个文件全部服务于本 PR 目的,无跑题文件、无空白噪音、无锁文件/生成物。干净。 CI 判定PR head 的红继承自 master 红,与本 PR 无关:head 与 master tip(aa198fe61)两次运行的失败签名逐条相同——6 个 test 分片死于 LIVE_FILES 未登记的 spawn-test 跳闸、mysql-contract 死于该 lane 未构建 kernel/dist,正是 #4326 的两个子缺陷 A/B,修复在途(#4174 + #4330,均 open)。head 上全部静态门禁绿。待两个修复 PR 合入、master 转绿后,在本分支推一次 trivial update 即可拿到干净的全量结果。 本地验证在 PR head b6b7a50 实测:typecheck clean;定向套件 dsh-settings-ui + issue2861-host-plugin-notice + web-i18n = 48/48 通过(与 PR 声称数字一致)。全量判定以远程 CI 为准。 八问
行为变更披露核对PR 体披露的三项(tab 标签 收工判定代码与文档通过审核,无需返工;合并暂缓,等你拍板与 #4238 的顺序(建议:先合本 PR,再返工 #4238——删 |
… link, host-plugin contract docs (#4319) Owner decisions on #4319 (all five optional suggestions triaged): 1. Rename the dsh session tab to bili's own name — zh 压缩代理 / en Compression — so it stays distinguishable from dsh-context's same-purpose tab when both are installed. Unconditional rename; no config surface (ui.tabLabel/ui.order/ui.tab withdrawn per owner decision). BEHAVIOR CHANGE: default dsh tab label 上下文→压缩代理 / Context→Compression for all dsh users (cosmetic; slot id/order/locale unchanged). 2. Host-plugin banner: neutral coexistence wording (the two calibers are complementary, not competing) + upstream repository link next to the plugin name (new optional repoUrl on the notice, rendered escaped). 3. Config page: one-line note pointing at the host-side composition view provided by dsh-context (when installed). 4. Docs: README 'Host plugin integration' section — GET /bili/origin shapes + polling caveat; GET /__bili/plugin/status stable field set (the PLUGIN.md §4 documented fields), error shapes, loopback admin gate + CORS origin echo, additive-evolution promise. PLUGIN.md §4 cross-ref; CLIENTS.md dsh section updated (tab rename + pointer). Tests: label pin updated (dsh-settings-ui); new #4319 tests — repoUrl detection propagation, banner link render/escape/omission, softened-wording pins; wiring drift guard extended with t("hostplug.repo"). Closes #4319
… built-in tab label Rebased onto master after #4238 merged (contextTab/contextTabLabel knobs shipped). Those changes reference the tab's built-in name as fact; the #4319 rename makes those references stale: - readCtxTabFace comment, web quick-config row labels (zh/en), CONFIGURATION.md/ zh-CN, website config-reference yaml seeds, LIFECYCLE.md: built-in name is now 「压缩代理」/「Compression」, not 「上下文」/「Context」 - tests/dsh-settings-ui.test.ts: the two contextTabLabel fallback pins now expect the renamed built-in label - README Host plugin integration: /bili/origin bodies also carry the #4237 face flags (contextTab/contextTabLabel) — documented as internal, ignore
b6b7a50 to
2aa32c6
Compare
|
(ai: vllm-qwen/qwen3.8-27b) Scope decision from the owner in #4319: the tab-naming/hiding side of this work already shipped via merged PR #4238 ( This PR's other content - tab rename 压缩代理/Compression, banner softening + repo link, config-page note - is dropped from the plan but preserved intact on this branch if ever wanted back. Leaving this PR open for the owner to close. |
(ai: vllm-qwen/qwen3.8-27b) 收到范围决定。已核实两点事实并顺带把新的文档 PR #4447 审完了(该 PR 尚未有镜像 issue,故在此汇报): 核实:#4238 确已合入 master(9d7867b80,2026-10-23T14:43Z, #4447 审核结论:通过,可合契约文字 vs 当前 master 代码逐条核对(e5183631f)——全部准确:
CI:head ed3e8da 全绿——全部 test 分片(ubuntu 22/24、windows 22)+ static-gates + mysql-contract + 所有 guard job(含 docs-sync/docs-coverage),gated e2e 按惯例 skip。master 已转绿,无继承红的问题。 一个状态提示:GitHub 上 #4447 显示 一处正文笔误(仅 PR 描述,非文档缺陷):PR 体写稳定字段集「incl. 八问(针对 #4447)
收工判定#4447 通过审核、CI 全绿、无冲突,随时可合(合并权在你)。#4327 按你的指示保持 open 待你关闭,分支内容完整保留、未动一行。 |
…n tab label docs-sync drift: the #4238-alignment pass renamed the built-in tab references to 「压缩代理」/「Compression」 in the EN seed, the committed CONFIGURATION.zh-CN.md row and every other surface, but missed the ZH seed desc (still 「顶栏上下文标签页」), so gen-config-docs regenerated a line different from the committed doc. Align the seed with its EN twin and the already-committed ZH doc text.
(ai: vllm-qwen/qwen3.8-27b) CI 自动修复(第 1/2 次尝试):docs-sync 红 → 已修,已推送,新 head 上 docs-sync 转绿。 结构化八问:
验证:在推送树上跑了 CI 完全相同的命令(generate + 四产物 diff --exit-code + check-coverage)全部干净;CI 于新 head 顺带观察(未动,超出本次漂移修复范围): 判定:修复已合入 PR 分支(commit |
|
已经实现了 |
Implements the owner's decisions on #4319 (coexistence with dsh-context: tab name collision, banner cross-linking, status contract docs). All five optional suggestions were triaged; decisions are recorded in the issue thread.
Changes
1. Tab renamed to bili's own name (behavior change)
上下文→压缩代理(zh),Context→Compression(en) — src/agent/dsh-native-client.tsbili-context) / order (30) / locale unchanged.2. Host-plugin banner (detection notice)
repoUrlon detected notices (dsh-context → its GitHub repo); the banner renders an escaped 仓库/repository anchor next to the plugin name. Additive: notices without repoUrl render byte-identically to before.3. Config page note
4. Docs — stable host-plugin contract
GET /bili/originshapes + polling caveat (incl. relay mode feat: support a public panel origin for remote / reverse-proxied deployments | feat: 远程/反代场景下面板不可用(headless 宿主 + 远程浏览器时 iframe 指向 127.0.0.1) #3373);GET /__bili/plugin/status?conversationId=stable field set (= the PLUGIN.md §4 documented fields), error shapes (400 / 404 / pre-first-request & chain-advisory phases), access restrictions (loopback admin gate, trusted Origin incl.dsh-app://app, CORS origin echo), additive-evolution promise. Experimental/internal fields deliberately not contracted.Behavior change disclosure
上下文/Context→压缩代理/Compression(all dsh users, cosmetic).hostPluginNotices[]items may now carry an additionalrepoUrlstring (additive JSON field).Validation
Rebase note (post-#4238 merge)
Rebased onto master after #4238 (
dsh.contextTab/dsh.contextTabLabelknobs) merged; second commit aligns #4238's references with the renamed built-in tab label — its docs/tests/comments stated the built-in name 「上下文」/「Context」 as fact, now 「压缩代理」/「Compression」. The two PRs compose: default shows 压缩代理/Compression out of the box; #4238's knobs stay as escape hatches (hide the tab or set any custom name). README contract section also notes that/bili/originbodies carry the #4237 face flags (internal, ignore).Closes #4319