Repository navigation
[PR] fix: recognize externalSummary in COMPRESS_SETTING_FIELDS so misplaced placement warns | 配置识别集合补上 externalSummary——放错位置终于有提示 - #3880
Conversation
…d placement warns (#3876)
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4610-pr.3880.a381aadThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3880.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复。本 PR 关闭的源 issue #3876 已做过完整查重——#3675/#3680 是「放错位置的 compress 键静默无效且无告警」的机制,本条是「那条告警的识别集合漏登记了一个字段」,同症状家族、不同缺陷;近期也没有其它 PR 往该集合加字段。 独立审核(我重读了权威 diff、base 代码与 head/base 两侧 CI,不是照抄 issue 结论): 标签:bug / p3 / scope/other(与本 PR 关闭的 #3876 分类一致)。 八问
代码/测试核对
CI(关键):head 判定:PR 本身正确、最小、带回归测试、无回归,可合;当前无法显示全绿 CI 的唯一原因是 master 自身在 docs-sync / unused-exports 上红(与本 PR 无关)。建议待 master 这两个既有红修复后再合;若分支保护不强制这两项,现在也可合。我未改 PR(本身没问题),也未为这两个 master 既有红另开 issue——它们超出本 PR 范围且需先确认是否已被跟踪再立项,避免重复;需要我去查/立这俩红的 issue 说一声即可。 |
Commit 66219d4 added externalSummary to COMPRESS_SETTING_FIELDS on this branch; the config-surface guard then fails HERE (leaf compress.externalSummary lacks a seed entry) until #3880's seed lands on master - i.e. merge order mattered: merging this PR first would have put a NEW red on master's own config-surface-guard. This mirrors #3880's exact seed entry (byte-identical, so either PR may merge first and the duplicate is a clean no-op) plus the generator output for it (5 added lines, 0 removed), making this branch self-contained green for both config-surface-guard and docs-sync once the pre-existing master static-gate red (#3870/#3871) clears.
Commit 66219d4 added externalSummary to COMPRESS_SETTING_FIELDS on this branch; the config-surface guard then fails HERE (leaf compress.externalSummary lacks a seed entry) until #3880's seed lands on master - i.e. merge order mattered: merging this PR first would have put a NEW red on master's own config-surface-guard. This mirrors #3880's exact seed entry (byte-identical, so either PR may merge first and the duplicate is a clean no-op) plus the generator output for it (5 added lines, 0 removed), making this branch self-contained green for both config-surface-guard and docs-sync once the pre-existing master static-gate red (#3870/#3871) clears.
|
(ai: zhipuai-lb/glm-5.3) 已并入 #4590。关单收尾;误判请 reopen。 |
Closes #3876
What / why
parseCompressSettingsacceptsexternalSummary, but the recognition setCOMPRESS_SETTING_FIELDS(whose comment claims it stays in sync with that parser) did not contain it. Cross-checked every fieldparseCompressSettingsaccepts against the set:externalSummaryis the ONLY gap. Consequences:externalSummarygot the generic "unknown top-level key" warning WITHOUT the "belongs under compress" placement hint ([config] misplaced/unknown top-level keys are silently ignored — root-level promptPack does nothing without any warning #1815 hint path);externalSummaryat the route root.Fix: one line — add
externalSummaryto the set. Plus the website seed entry the config-surface guard requires (below), plus a regression test pinning the new hint.config surface
New website seed entry
compress.externalSummaryinwebsite/config-reference/compress.yaml. Required because the config-surface guard (#2643) derivescompress.*leaves from this exact set — adding the member makes the leaf mandatory. The entry documents an EXISTING, already-shipped field (fully documented in CONFIGURATION.md en/zh today); no new config shape is introduced. Seed wording is open to adjustment at review.Behavior change (old -> new)
externalSummary: old = warned as unknown key with no placement hint; new = same warning plus"externalSummary" belongs under "compress" (did you mean "compress.externalSummary"?). Deduped once per signature, warn-only. No parsing or runtime behavior changes.providers."<key>": { externalSummary: ... }): unchanged on master — that warning does not exist on master yet (it lives in open PR [PR] fix: warn when compress-block keys sit inert on a provider route root | 路由根上的 compress 块键静默无效时补告警 #3680). Because [PR] fix: warn when compress-block keys sit inert on a provider route root | 路由根上的 compress 块键静默无效时补告警 #3680 reads the same set, it picks upexternalSummaryautomatically when it merges; merge order is immaterial (both sides carry the identical one-line set edit, which merges cleanly).Verification
Targeted suites green locally on the rebased head (master 39fb841): issue1815 + named-provider-bind + external-summary-settings = 59/59 pass; config-surface guard green (153 leaves incl. the new seed). Full-suite verdict = CI on this head.
Note: git egress from this environment failed mid-task (connection resets on all git protocol attempts while plain HTTPS worked), so the branch was created through the GitHub Git Data API instead of
git push; the pushed tree is byte-identical to the locally verified files listed above.