Skip to content

test: regenerate storage-render goldens after #3295 removed image stats seed fields - #3320

Closed
ranxianglei wants to merge 1 commit into
masterfrom
2026-10-16_regen-storage-render-goldens
Closed

ranxianglei wants to merge 1 commit into
masterfrom
2026-10-16_regen-storage-render-goldens

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

What

Regenerates tests/golden/storage-render/*.json — 4 files × 3 digest lines each, no source changes.

Closes #3313

Why the goldens drifted

The storage-render goldens were last regenerated at 700722d (#3266 「remove image pre-compression」). The #3295 follow-up commit 5bcc345 ("finish the #3266 removal — orphaned kernel image types/stats fields") then deliberately deleted the three zero-value seed fields imagesShrunk / imageBytesSaved / imageTokensSaved from createInitialState() (kernel/src/state.ts) and their interface declarations (kernel/src/types.ts) — dead-code cleanup: after src/image-compress.ts was removed these counters had no readers left.

Consequence: persisted state.stats lost 3 keys → the state section's stats key digest in the committed snapshots no longer matches live behavior → all four wire subtests red on master and on every in-flight PR's CI test shards (the failure signature in #3313).

Regeneration justification (required by tests/golden-storage-render.test.ts header)

This is a deliberate persisted-state contract change (removal of dead zero-value counters), not accidental drift:

  • The regen diff is exactly 4 files × 3 lines: per-wire stateDigest, sectionDigests.state, and the state-key stats digest. blockContents / top-level stats / metadata / blocks / messageRefs / nudge sections are all unchanged.
  • New chat stateDigest=7bd74bdd045445f7… matches bit-for-bit the live value CI reported in storage-render 金标快照未随 #3295 重新生成,master 与所有在途 PR 的测试分片全红 [no-dispatch] #3313.
  • Local targeted runs: tests/golden-storage-render.test.ts 5/5 pass (was 1/5), tests/storage-engine-proofs.test.ts 12/12 pass (also reads this golden dir). Full-suite verdict left to remote CI.

Behavior notes

No user-facing behavior change: old sessions reading back the legacy keys follow the #3266 back-compat contract where whitelisted readers DROP them (pinned by tests/storage-corpus.test.ts); media bytes unaffected. This PR only aligns the test fixture with current code — merging it turns every in-flight PR's test shards green again.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-16_regen-storage-render-goldens (05f1b1d)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.3888-pr.3320.309c065

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr3320.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重: 重复 #3314——本 PR 与 #3314 是同一工作的两个并行产物:

处置(按先来后到:后到的关闭、先到的保留):即将关闭本 PR(duplicate of #3314),把补充核验信息写到 #3314 下。初步 CI 观察:#3314 的 CI 中已无任何 storage-render 失败(修复本身生效),其剩余红分片是无关测试(#1086 T5 liveness ×3 分片、AC12 multi-hop grandchild ×1 分片)——正在核实这些是否为 master 侧既有 flake,随后给出结构化八问结论。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重结论:本 PR 与 #3314 100% 重复,按先来后到关闭本 PR、保留 #3314。

八问

  1. 是什么问题:两个会话各自为同一个红 CI(storage-render 金标快照未随 #3295 重新生成,master 与所有在途 PR 的测试分片全红 [no-dispatch] #3313 的 4 条 storage-render golden 失败)提交了内容完全相同的 rebaseline PR——test: rebaseline storage-render goldens after #3295 dropped dead image-stats fields from state.stats #3314(17:28Z)与本 PR(test: regenerate storage-render goldens after #3295 removed image stats seed fields #3320)。diff 逐字节一致:仅 tests/golden/storage-render/{chat,anthropic,responses,google}.json 4 文件 × 3 行 digest(stateDigest / sectionDigests.state / state 段 stats key),零源码改动。
  2. 什么原因导致的:前一个会话在 storage-render 金标快照未随 #3295 重新生成,master 与所有在途 PR 的测试分片全红 [no-dispatch] #3313 的 floor 2 里已经明确引用了 test: rebaseline storage-render goldens after #3295 dropped dead image-stats fields from state.stats #3314 是「在途的 rebaseline PR」,但随后 floor 3 的开工回复却写了「查重: 不重复」——引用在先、查重在后且自相矛盾,漏检了自己的在途 PR。
  3. 影响范围与严重程度:无代码行为影响;两个 PR 是同一个修复,若都合入第二个必然冲突/空转,浪费的是调度与 review 资源。严重度:纯流程浪费。
  4. 怎么修复的:独立复核后关单——本地 A/B 验证 + CI 日志分析确认修复本身正确(证据转投 test: rebaseline storage-render goldens after #3295 dropped dead image-stats fields from state.stats #3314 线程),关闭本 PR 并在 test: rebaseline storage-render goldens after #3295 dropped dead image-stats fields from state.stats #3314 补充验证记录。
  5. 是否有回归问题:PR 本身零源码改动,不涉及行为回归。既有行为清点:golden 目录的消费方只有 tests/golden-storage-render.test.ts 与 tests/storage-engine-proofs.test.ts(grep 全仓确认),两者在 PR head 上分别 5/5、12/12 通过;旧会话读回 legacy key 走 image_full 无法被正确调用:同一张图每轮重复降采样(38 次)、restore 提示注入 38 次,模型只能猜 ref → 每轮一次失败+重发,缓存命中从 75% 掉到 28% #3266 back-compat 白名单丢弃路径(tests/storage-corpus.test.ts 钉住),不受影响。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及。
  8. 是否引入了新的配置:不涉及。

独立复核证据(不抄 PR 描述,本地重做):

顺带发现(已在 #3313 留评论等 owner 决定,按来源链规则不自行立项):#3314 CI 剩余红分片与本 fixture 无关——#1086 T5 liveness 是确定性失败:该测试 mock 每轮吐 "x".repeat(360)(tests/issue1086-chain-self-exemption.test.ts:546),超过 #3289 合入 master 的输出侧 runaway guard 阈值 maxTextRun=200,流被 abort → 25 !== 60。我在本 PR head 本地确定性复现(21 tests / fail 1,同签名)。即 #3289 合入后,凡含该测试文件的 CI 分片必红。另 win22-s3 的 AC12 单次失败本地 4/4 复跑通过,判为偶发。

判定:关闭本 PR(duplicate of #3314),保留 #3314 待人工合并;golden 修复本身已验证成立。

@ranxianglei ranxianglei added the duplicate This issue or pull request already exists label Oct 15, 2026
ranxianglei pushed a commit that referenced this pull request Oct 16, 2026
…3312-#3320 batch)

- keep #3298 changes on master's post-absorb shapes: relay round-2 rebuild
  and all four prepare* paths keep withProjectAttribution; absorb imports/
  sections dropped with #3309
- storage-render goldens: metadata-section drift after the merge (absorb
  fields gone from session metadata) — regenerated via
  scripts/update-storage-render-goldens.ts, wire-body sections unchanged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage-render 金标快照未随 #3295 重新生成,master 与所有在途 PR 的测试分片全红 [no-dispatch]

1 participant