Repository navigation
test: regenerate storage-render goldens after #3295 removed image stats seed fields - #3320
ranxianglei wants to merge 1 commit into
Conversation
…ts seed fields
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.3888-pr.3320.309c065This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3320.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重: 重复 #3314——本 PR 与 #3314 是同一工作的两个并行产物:
处置(按先来后到:后到的关闭、先到的保留):即将关闭本 PR(duplicate of #3314),把补充核验信息写到 #3314 下。初步 CI 观察:#3314 的 CI 中已无任何 storage-render 失败(修复本身生效),其剩余红分片是无关测试( |
(ai: vllm-qwen/qwen3.8-27b) 查重结论:本 PR 与 #3314 100% 重复,按先来后到关闭本 PR、保留 #3314。 八问
独立复核证据(不抄 PR 描述,本地重做):
顺带发现(已在 #3313 留评论等 owner 决定,按来源链规则不自行立项):#3314 CI 剩余红分片与本 fixture 无关—— 判定:关闭本 PR(duplicate of #3314),保留 #3314 待人工合并;golden 修复本身已验证成立。 |
…3312-#3320 batch) - keep #3298 changes on master's post-absorb shapes: relay round-2 rebuild and all four prepare* paths keep withProjectAttribution; absorb imports/ sections dropped with #3309 - storage-render goldens: metadata-section drift after the merge (absorb fields gone from session metadata) — regenerated via scripts/update-storage-render-goldens.ts, wire-body sections unchanged
What
Regenerates
tests/golden/storage-render/*.json— 4 files × 3 digest lines each, no source changes.Closes #3313
Why the goldens drifted
The storage-render goldens were last regenerated at 700722d (#3266 「remove image pre-compression」). The #3295 follow-up commit 5bcc345 ("finish the #3266 removal — orphaned kernel image types/stats fields") then deliberately deleted the three zero-value seed fields
imagesShrunk/imageBytesSaved/imageTokensSavedfromcreateInitialState()(kernel/src/state.ts) and their interface declarations (kernel/src/types.ts) — dead-code cleanup: aftersrc/image-compress.tswas removed these counters had no readers left.Consequence: persisted
state.statslost 3 keys → the state section's stats key digest in the committed snapshots no longer matches live behavior → all four wire subtests red on master and on every in-flight PR's CItestshards (the failure signature in #3313).Regeneration justification (required by tests/golden-storage-render.test.ts header)
This is a deliberate persisted-state contract change (removal of dead zero-value counters), not accidental drift:
stateDigest,sectionDigests.state, and the state-keystatsdigest. blockContents / top-level stats / metadata / blocks / messageRefs / nudge sections are all unchanged.stateDigest=7bd74bdd045445f7…matches bit-for-bit the live value CI reported in storage-render 金标快照未随 #3295 重新生成,master 与所有在途 PR 的测试分片全红 [no-dispatch] #3313.tests/golden-storage-render.test.ts5/5 pass (was 1/5),tests/storage-engine-proofs.test.ts12/12 pass (also reads this golden dir). Full-suite verdict left to remote CI.Behavior notes
No user-facing behavior change: old sessions reading back the legacy keys follow the #3266 back-compat contract where whitelisted readers DROP them (pinned by
tests/storage-corpus.test.ts); media bytes unaffected. This PR only aligns the test fixture with current code — merging it turns every in-flight PR's test shards green again.