Repository navigation
feat: remove the absorb distillation feature (#3293) - #3309
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 接单处理 PR #3309(移除 absorb distillation 功能)。 查重:不重复。 与 #3177/#3287(compress 面在 plugin lane 不可达)同症状家族但不同机制——#3177 修的是 compress 工具面,本 PR 按 owner 在 #3293 的决定直接移除 absorb 整个功能;与在途其他 PR 无文件级重叠需协调的冲突(见下)。 当前状态:PR 分支 正在 rebase 到最新 master → 定向验证 → push,完成后按八问体例回复结论。 |
8cc5e64 to
84e7a25
Compare
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.3892-pr.3309.8f19865This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3309.tgz
npm install -g packageInstall instructions are refreshed on each push. |
84e7a25 to
67fda03
Compare
(ai: vllm-qwen/qwen3.8-27b) 冲突已解决并 rebase 到最新 master,另修掉一处遗漏(docs-sync CI 红),已推送到 PR 分支:head 现为 67fda03( 做了什么
结构化八问
判定本地验证(typecheck + 267 定向测试)已过,diff 干净(每一行都与「删 absorb + 对齐 master」相关)。待 CI 全绿即可合并——CI 结果出来我再回一条确认;若有任何 lane 红,我会先定向排查再报。 |
602e74c to
3890451
Compare
(ai: vllm-qwen/qwen3.8-27b) 冲突已解决:分支已 rebase 到最新 master( 八问
判定:冲突闭环,可等 CI 绿灯后由人合并(合并权限在人,我不代合)。 |
3890451 to
dac6224
Compare
The `absorb` tool let a model distill oversized tool results through an injected tool, but its prompt activation was gated on `shouldInject` alone while tool injection was additionally gated on `!pluginMode`. In every plugin-mode lane (pi/omp/opencode/dsh) with compress.absorb.enabled=true the model was therefore told to call a tool that never appears on the wire — unknown-tool spin, same symptom family as #3177 (which fixed the compress surface). Owner decision: remove the feature entirely rather than gate it. - delete src/absorb.ts; relocate isProxyToolFor to src/proxy-tool.ts (absorb branch dropped) - drop absorb from config schema/validation/divergence-warn, compress-settings, the four prepare-* wire paths, relay, preflight, side-request, stream*, loop/core, plugin manifest, server inject; drop ABSORB_TOOL* from compress-tool + opencode-v2 - delete tests/absorb.test.ts + tests/absorb-plugin.test.ts; strip absorb fixtures/assertions/golden-specs from affected suites - regenerate wire-contract goldens (bili.json, manifest-optin.json); kernel.json unchanged - docs en/zh: remove absorb config sections and cross-references The low-level m00885 emission-drop machinery (adapter absorbArmed params, tag-echo-filter tcHold path) is kept dormant/unarmable: no request can arm it after this removal. Kernel is untouched (human-gated). Closes #3293
dac6224 to
8a43cd8
Compare
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) PR #3309 已 rebase 到当前 master 并完成全部修复,分支现为单提交 做了什么(按时间序)
CI 现状(head
八问
判定:本 PR 范围内的工作已全部闭环且验证通过;当前 8 个红分片全部由 master 基线红(#3313/#3320、#3317 接手中)造成。等 #3317/#3320 合入后重跑即可全绿,届时可合并;若 owner 接受「已知基线红」直接合并也可以——本 PR 没有任何自己引入的红。我不代合并。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.475-master.9a5ff5c # this exact build
npm install -g billion-context@master # always the newest merged build
|
…3312-#3320 batch) - keep #3298 changes on master's post-absorb shapes: relay round-2 rebuild and all four prepare* paths keep withProjectAttribution; absorb imports/ sections dropped with #3309 - storage-render goldens: metadata-section drift after the merge (absorb fields gone from session metadata) — regenerated via scripts/update-storage-render-goldens.ts, wire-body sections unchanged
Restore the absorb machinery reverted by #3309, as the base for the media-scoped revival (#3398): conflicts resolved keeping both the restored absorb wiring and post-#3309 additions (withProjectAttribution #3298, withAcpNotes #3252). src/proxy-tool.ts is deleted again — its only export isProxyToolFor moves back to absorb.ts (absorb-aware, pre-#3309 shape). This revert is intentionally NOT pushed alone; the media-only scope restriction lands on top in the same PR.
…t parity (#3402) Host applies the product policy the kernel leaves neutral: resolveAbsorbSettings defaults mediaOnly to true (image-bearing results only), so pure-text large results are no longer marked by default and the old over-compression mode is gone; mediaOnly:false restores legacy full-text behavior. absorb.enabled still defaults false. New config key compress.absorb.mediaOnly (boolean) added to the schema, cleaning loop, and plugin-lane divergence fields; config docs regenerated (EN/ZH/website). Adds a regression test pinning that the plugin-lane absorb prompt gate and the manifest advertisement read the same base config block (#3293: prompt appears iff tool is advertised). CHANGELOG backfills the entry #3309 omitted and records this revival.
Restore the absorb machinery reverted by #3309, as the base for the media-scoped revival (#3398): conflicts resolved keeping both the restored absorb wiring and post-#3309 additions (withProjectAttribution #3298, withAcpNotes #3252). src/proxy-tool.ts is deleted again — its only export isProxyToolFor moves back to absorb.ts (absorb-aware, pre-#3309 shape). This revert is intentionally NOT pushed alone; the media-only scope restriction lands on top in the same PR.
…t parity (#3402) Host applies the product policy the kernel leaves neutral: resolveAbsorbSettings defaults mediaOnly to true (image-bearing results only), so pure-text large results are no longer marked by default and the old over-compression mode is gone; mediaOnly:false restores legacy full-text behavior. absorb.enabled still defaults false. New config key compress.absorb.mediaOnly (boolean) added to the schema, cleaning loop, and plugin-lane divergence fields; config docs regenerated (EN/ZH/website). Adds a regression test pinning that the plugin-lane absorb prompt gate and the manifest advertisement read the same base config block (#3293: prompt appears iff tool is advertised). CHANGELOG backfills the entry #3309 omitted and records this revival.
Restore the absorb machinery reverted by #3309, as the base for the media-scoped revival (#3398): conflicts resolved keeping both the restored absorb wiring and post-#3309 additions (withProjectAttribution #3298, withAcpNotes #3252). src/proxy-tool.ts is deleted again — its only export isProxyToolFor moves back to absorb.ts (absorb-aware, pre-#3309 shape). This revert is intentionally NOT pushed alone; the media-only scope restriction lands on top in the same PR.
…t parity (#3402) Host applies the product policy the kernel leaves neutral: resolveAbsorbSettings defaults mediaOnly to true (image-bearing results only), so pure-text large results are no longer marked by default and the old over-compression mode is gone; mediaOnly:false restores legacy full-text behavior. absorb.enabled still defaults false. New config key compress.absorb.mediaOnly (boolean) added to the schema, cleaning loop, and plugin-lane divergence fields; config docs regenerated (EN/ZH/website). Adds a regression test pinning that the plugin-lane absorb prompt gate and the manifest advertisement read the same base config block (#3293: prompt appears iff tool is advertised). CHANGELOG backfills the entry #3309 omitted and records this revival.
Restore the absorb machinery reverted by #3309, as the base for the media-scoped revival (#3398): conflicts resolved keeping both the restored absorb wiring and post-#3309 additions (withProjectAttribution #3298, withAcpNotes #3252). src/proxy-tool.ts is deleted again — its only export isProxyToolFor moves back to absorb.ts (absorb-aware, pre-#3309 shape). This revert is intentionally NOT pushed alone; the media-only scope restriction lands on top in the same PR.
…t parity (#3402) Host applies the product policy the kernel leaves neutral: resolveAbsorbSettings defaults mediaOnly to true (image-bearing results only), so pure-text large results are no longer marked by default and the old over-compression mode is gone; mediaOnly:false restores legacy full-text behavior. absorb.enabled still defaults false. New config key compress.absorb.mediaOnly (boolean) added to the schema, cleaning loop, and plugin-lane divergence fields; config docs regenerated (EN/ZH/website). Adds a regression test pinning that the plugin-lane absorb prompt gate and the manifest advertisement read the same base config block (#3293: prompt appears iff tool is advertised). CHANGELOG backfills the entry #3309 omitted and records this revival.
…-keys INERT list (#3402) The #3309 revert revived absorb, but #3344 still listed compress.absorb alongside compress.imageCompression as a removed/inert key: old-config parsing dropped absorb and tests/removed-compress-keys-inert.test.ts asserted it parsed to undefined. Pull absorb out of INERT_REMOVED_COMPRESS_KEYS (imageCompression stays removed), correct the warning text, and update the test so absorb is asserted kept while only imageCompression warns.
Restore the absorb machinery reverted by #3309, as the base for the media-scoped revival (#3398): conflicts resolved keeping both the restored absorb wiring and post-#3309 additions (withProjectAttribution #3298, withAcpNotes #3252). src/proxy-tool.ts is deleted again — its only export isProxyToolFor moves back to absorb.ts (absorb-aware, pre-#3309 shape). This revert is intentionally NOT pushed alone; the media-only scope restriction lands on top in the same PR.
…t parity (#3402) Host applies the product policy the kernel leaves neutral: resolveAbsorbSettings defaults mediaOnly to true (image-bearing results only), so pure-text large results are no longer marked by default and the old over-compression mode is gone; mediaOnly:false restores legacy full-text behavior. absorb.enabled still defaults false. New config key compress.absorb.mediaOnly (boolean) added to the schema, cleaning loop, and plugin-lane divergence fields; config docs regenerated (EN/ZH/website). Adds a regression test pinning that the plugin-lane absorb prompt gate and the manifest advertisement read the same base config block (#3293: prompt appears iff tool is advertised). CHANGELOG backfills the entry #3309 omitted and records this revival.
…-keys INERT list (#3402) The #3309 revert revived absorb, but #3344 still listed compress.absorb alongside compress.imageCompression as a removed/inert key: old-config parsing dropped absorb and tests/removed-compress-keys-inert.test.ts asserted it parsed to undefined. Pull absorb out of INERT_REMOVED_COMPRESS_KEYS (imageCompression stays removed), correct the warning text, and update the test so absorb is asserted kept while only imageCompression warns.
Removes the
absorbdistillation feature entirely.What & why
The
absorbtool let a model distill oversized tool results through an injected tool. Its prompt activation was gated onshouldInjectalone, but tool injection was additionally gated on!pluginMode. So in every plugin-mode lane (pi/omp/opencode/dsh) withcompress.absorb.enabled=true, the model was told to call a tool that never appears on its wire → unknown-tool spin, wasted turns, growing context pressure. Same symptom family as #3177 (which fixed the compress surface); this is the absorb surface across all plugin lanes.Owner decision (#3293): remove the feature rather than gate it — it was opt-in, default-off, and found to be useless in practice.
Config surface
Removed config fields (all under
compress.absorb.*):enabled,toolName,minTokens,maxTokens,levels. No new or renamed fields.Compat / migration: the config parser is lenient — old configs that still carry
compress.absorb.*are silently ignored (no error, no migration step) because the feature no longer exists. Nothing else reads these keys.Behavior change (flagged per policy)
compress.absorb.enabled=trueactivated an absorb system prompt + kernel[ACP absorb]markers + an injectedabsorbtool. In practice only proxy mode worked; plugin mode was broken (see above).absorbno longer exists anywhere. Oversized tool results are handled solely by the CCR content store (acp_retrieve), which was already the lossless default path.Scope notes
kernel/(acp-kernel) still exports its absorb API; bili simply stops passingconfig.absorbinto the loop.kernel.jsongolden unchanged.absorbArmedparams,tag-echo-filtertcHold state machine) is kept but unarmable — after this removal no request can setabsorbArmed=true(there is noconfig.absorb). Full excision would be a high-risk streaming-core refactor disproportionate to removing a user toggle; documented here as a deliberate boundary. Its unit tests (absorb-emission.test.ts,loop-adapters.test.ts,adapter-google.test.ts) stay green against the dormant path.rulesActivegate (same missing!pluginMode) is out of scope — the request was to remove absorb only; rules behavior is unchanged.Tests
tests/absorb.test.ts+tests/absorb-plugin.test.ts; stripped absorb fixtures/assertions/golden-specs from ~15 affected suites.bili.json(−22 lines),manifest-optin.json(−68 lines) — pure absorb deletions;kernel.json+manifest-default.jsonunchanged.Closes #3293