Skip to content

修 CI 无故变红:#1086 T5 用例的 'x'×360 填充触发 #3289 输出护栏,含 #3289 的每棵树必挂 - #3317

Merged
ranxianglei merged 1 commit into
masterfrom
2026-10-15_issue1086-t5-filler-under-runaway-guard
Oct 16, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-10-15_issue1086-t5-filler-under-runaway-guard

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

(ai: vllm-qwen/qwen3.8-27b)

Fixes #3315 子缺陷 2(#1086 T5 liveness)。查重:不重复——#3315 已跟踪此症状但判为「偶发/#394 互扰」;本 PR 给出确定性根因证据与修复。金标漂移(子缺陷 1)由在途 #3314 处理,不在本 PR。

是什么 / 为什么红

tests/issue1086-chain-self-exemption.test.ts:546 的假上游每轮回显 "x".repeat(360)。#3289(今日合入 master 顶)新增输出侧 text-run 失控护栏:src/runaway-guard.ts:72 TEXT_RUN_THRESHOLD = 200(内部常量,按 #2030 纪律无配置面)——解码后输出文本中同一码位连续 ≥200 次即中止上游流。360 > 200 ⇒ T5 每一轮流都被中止、该轮无可见回复 ⇒ every client turn must get a visible reply: 25 !== 60 确定性失败,不是 #3315 原判的偶发/负载问题。

证据(三层同签名)

  1. 本地(master 6ee4a2a):node --import tsx --test tests/issue1086-chain-self-exemption.test.ts → T5 必挂,日志 35 次 output-side runaway guard tripped (text-run; {...maxTextRun:200, textRunChar:"x"}) — aborting upstream stream,紧随每次被截断的流;
  2. master push CI run 38767006158(ubuntu-24 shard 2)同签名失败;
  3. PR test: pin persistence write-amplification shape and mode cost ordering (#3049) #3275 run 38776693851 shard 2 全平台失败(分区确定性 ⇒ 各平台同文件集)。

全仓排查同类夹具:其余长单字符 repeat() 均在输入侧历史构造(issue2360/issue1495/responses-instructions-drift 等),护栏只作用于上游输出流,不受影响;输出侧仅此一处。

修法

填充改等长混合字符 "xyz".repeat(120)(仍 360B,maxTextRun=1)。该测试的全部断言只依赖回复长度/请求字节数/计数(:579/:584/:586),不依赖内容;护栏行为本身不动——#3289 是有意的生产行为,夹具不应产出病态序列。注释一行说明约束来源,防止日后被「简化」回均匀串重引入本红。

验证

  • 修复前本地:21 测 1 挂(T5)+ 35 次 guard tripped;修复后:21/21 通过,0 次 tripped
  • 纯测试文件变更,无 src/ 触碰;typecheck 不涉及(仅字符串字面量 + 注释)

八问:①T5 存活用例被新护栏误伤致 CI 常红;②夹具 360 连 x 超护栏 200 阈值;③含 #3289 的所有树上 shard 2 全平台必挂,阻塞全部 PR 合并门禁;④夹具改等长混合字符,护栏不动;⑤无回归(断言不依赖内容,字节数不变);⑥不涉及缓存;⑦不改设计方向;⑧无新配置。

…3315 sub-defect 2)

The T5 liveness fake upstream echoed "x".repeat(360) per turn. #3289's
output-side runaway guard trips at TEXT_RUN_THRESHOLD=200 identical
codepoints (src/runaway-guard.ts), aborting every such stream — so each
turn lost its visible reply and the suite failed deterministically
(25 !== 60) on every tree containing #3289: master push run 38767006158
and PR #3275 run 38776693851, plus local repro (35 guard trips).

Mixed-char filler "xyz".repeat(120) keeps the identical 360-byte payload
size (all assertions depend on length/byte count only) while maxTextRun
drops to 1. Guard behavior itself is untouched — #3289 is intentional
production behavior; the fixture simply must not emit pathological runs.

Verified: node --import tsx --test tests/issue1086-chain-self-exemption.test.ts
-> 21/21 pass, 0 guard trips (was 35).
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-15_issue1086-t5-filler-under-runaway-guard (f404915)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.3876-pr.3317.707a28e

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr3317.tgz
npm install -g package

Install instructions are refreshed on each push.

ranxianglei pushed a commit that referenced this pull request Oct 15, 2026
Pushed as 7d061be before PR #3317 was discovered: it fixes the exact same
line (tests/issue1086-chain-self-exemption.test.ts:546, same mechanism, same
equal-length mixed-char approach) and is properly tracked under #3315 sub-defect 2.
Keeping both would force a merge-conflict round between #3314 and #3317 on one
line. Reverting restores the intended disjoint-file split (#3314 = golden JSONs,
#3317 = the single test file); shard 2 goes green only when BOTH land, per
#3315 floor 6.
@ranxianglei
ranxianglei merged commit ed89230 into master Oct 16, 2026
34 of 39 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.470-master.ed89230 (rolling master tag).

npm install -g billion-context@0.0.470-master.ed89230  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI 测试 lane 出现与代码改动无关的失败:存储渲染快照漂移 + 两个偶发用例

1 participant