Skip to content

test: regen storage-render goldens for the #3023 cache-ledger client-insert attribution - #3035

Merged
ranxianglei merged 1 commit into
masterfrom
chore/storage-render-golden-regen-3023
Oct 13, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
chore/storage-render-golden-regen-3023

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

What

Regenerates the 4 storage-render goldens (chat/anthropic/responses/google). Diff: 8 digest lines, 4 files — stateDigest + sectionDigests.metadata per wire. state/blockContents/stats digests unchanged.

Why

#3023 (20c42582, merged as #3027 at 2026-10-13 18:55 +0800) added client-side-rewrite attribution to session.metadata.cacheLedger but shipped without regenerating the goldens. Result: tests/golden-storage-render.test.ts fails 4/5 on master right now (35591c38):

✖ storage-render golden (chat): ... sections: {..."metadata":"1f78ed1b58e4a77e"} vs golden {..."metadata":"201a63bff674729d"}; state-key divergence: none

Verified metadata-only drift:

Why nobody saw it

  1. feat: attribute client-side mid-history rewrites in the cache ledger (#3023) #3027's PR CI was red on all four test legs (the same 4 golden failures) and was merged anyway.
  2. Master-push CI skips the test lane entirely — run 38389227456 on 35591c38 shows test=skipped, static-gates=skipped (guards skip on push by design; skipped needs count as satisfied). Master has had no test coverage signal since 18:55.

PR #3030's red test legs are entirely this inherited breakage — its own head is green locally (verified by running the goldens + its touched suites on the PR head).

Validation

…insert attribution

#3023 (20c4258) added client-insert attribution to session.metadata.cacheLedger
(inbound-view fingerprints, bucket fields) but shipped without regenerating the
storage-render goldens: the metadata section digest drifted on all four wires
while state/blockContents/stats stayed identical. Its PR CI was red on the test
legs and was merged anyway, and master-push CI skips the test lane entirely
(38389227456: test=skipped, static-gates=skipped), so master has silently failed
tests/golden-storage-render.test.ts since 2026-10-13 18:55 (+0800).

Drift verified metadata-only by bisect (a1dba97 green -> 20c4258 red) and by
raw metadata diff (timestamps/uuids aside, only cacheLedger changed; canonicalize
already normalizes volatile values). Regen diff: 8 digest lines, 4 files.
storage-corpus pins untouched (they pin legacy-format parsing, not live render).

Also un-blocks PR #3030, whose CI failure is entirely this inherited master
breakage, not its own diff (verified: #3030 head alone is green locally).
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: chore/storage-render-golden-regen-3023 (5ceca75)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.3428-pr.3035.5f057bb

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr3035.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei
ranxianglei merged commit 187d031 into master Oct 13, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.374-master.187d031 (rolling master tag).

npm install -g billion-context@0.0.374-master.187d031  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

LoveDoLove pushed a commit to LoveDoLove-Forked-Projects/billion-context that referenced this pull request Oct 15, 2026
…ascade-skip the legs

The test job needs 9 guards; 4 are pull_request-only (version/kernel/
pi-subagents/lane-guard). A skipped need cascades the skip to dependents
(GitHub-documented behavior) — the workflow comment's 'skipped needs count
as satisfied' never held. Result: every master push ran CI with
'test: skipped' (e.g. run 38665531939), so master has had NO post-merge
unit-test signal — the hole that let ranxianglei#3145 (port collisions), ranxianglei#3027
(golden drift) and ranxianglei#3035 slip red to master unnoticed.

Fix: explicit 'if: !failure() && !cancelled()' on the test job:
- pull_request: guards run; a guard failure still skips the legs
  (required checks pending, merge blocked — ranxianglei#2637 fail-fast tiering intact)
- push/dispatch: PR-only guards skip harmlessly, the 12 shard legs RUN
  and master gets a real post-merge signal

Cost: bounded by the existing per-ref concurrency cancel (owner-approved
2026-10-10) — rapid merge sequences only pay for the last push.
@ranxianglei
ranxianglei deleted the chore/storage-render-golden-regen-3023 branch October 15, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant