Repository navigation
test: regen storage-render goldens for the #3023 cache-ledger client-insert attribution - #3035
Merged
Merged
Conversation
…insert attribution #3023 (20c4258) added client-insert attribution to session.metadata.cacheLedger (inbound-view fingerprints, bucket fields) but shipped without regenerating the storage-render goldens: the metadata section digest drifted on all four wires while state/blockContents/stats stayed identical. Its PR CI was red on the test legs and was merged anyway, and master-push CI skips the test lane entirely (38389227456: test=skipped, static-gates=skipped), so master has silently failed tests/golden-storage-render.test.ts since 2026-10-13 18:55 (+0800). Drift verified metadata-only by bisect (a1dba97 green -> 20c4258 red) and by raw metadata diff (timestamps/uuids aside, only cacheLedger changed; canonicalize already normalizes volatile values). Regen diff: 8 digest lines, 4 files. storage-corpus pins untouched (they pin legacy-format parsing, not live render). Also un-blocks PR #3030, whose CI failure is entirely this inherited master breakage, not its own diff (verified: #3030 head alone is green locally).
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.3428-pr.3035.5f057bbThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3035.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.374-master.187d031 # this exact build
npm install -g billion-context@master # always the newest merged build
|
This was referenced Oct 13, 2026
Open
LoveDoLove
pushed a commit
to LoveDoLove-Forked-Projects/billion-context
that referenced
this pull request
Oct 15, 2026
…ascade-skip the legs The test job needs 9 guards; 4 are pull_request-only (version/kernel/ pi-subagents/lane-guard). A skipped need cascades the skip to dependents (GitHub-documented behavior) — the workflow comment's 'skipped needs count as satisfied' never held. Result: every master push ran CI with 'test: skipped' (e.g. run 38665531939), so master has had NO post-merge unit-test signal — the hole that let ranxianglei#3145 (port collisions), ranxianglei#3027 (golden drift) and ranxianglei#3035 slip red to master unnoticed. Fix: explicit 'if: !failure() && !cancelled()' on the test job: - pull_request: guards run; a guard failure still skips the legs (required checks pending, merge blocked — ranxianglei#2637 fail-fast tiering intact) - push/dispatch: PR-only guards skip harmlessly, the 12 shard legs RUN and master gets a real post-merge signal Cost: bounded by the existing per-ref concurrency cancel (owner-approved 2026-10-10) — rapid merge sequences only pay for the last push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates the 4 storage-render goldens (chat/anthropic/responses/google). Diff: 8 digest lines, 4 files —
stateDigest+sectionDigests.metadataper wire. state/blockContents/stats digests unchanged.Why
#3023 (
20c42582, merged as #3027 at 2026-10-13 18:55 +0800) added client-side-rewrite attribution tosession.metadata.cacheLedgerbut shipped without regenerating the goldens. Result:tests/golden-storage-render.test.tsfails 4/5 on master right now (35591c38):Verified metadata-only drift:
a1dba977(Phase 3) green →20c42582([Enhancement][cache-ledger] attribute client-side mid-history insertions to a client bucket — seam forensics currently blame bili for host churn (found in #2997) #3023) redcacheLedger(+ itsattimestamps / observation uuids, whichcanonicalizealready normalizes)Why nobody saw it
35591c38showstest=skipped,static-gates=skipped(guards skip on push by design; skipped needs count as satisfied). Master has had no test coverage signal since 18:55.PR #3030's red test legs are entirely this inherited breakage — its own head is green locally (verified by running the goldens + its touched suites on the PR head).
Validation
golden-storage-render5/5 after regen;storage-corpus9/9 (untouched — legacy-format pins);cache-seam-client-insert+issue1891-seam-nobaseline(the suites [Enhancement][cache-ledger] attribute client-side mid-history insertions to a client bucket — seam forensics currently blame bili for host churn (found in #2997) #3023 touched) green