Skip to content

ci: run the test matrix on master pushes — fix the skipped-needs cascade - #3219

Merged
ranxianglei merged 2 commits into
masterfrom
fix/master-push-test-lane
Oct 15, 2026
Merged

ranxianglei merged 2 commits into
masterfrom
fix/master-push-test-lane

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

What

Master pushes have never run the unit-test matrix: the test job needs 9 guards, 4 of which are pull_request-only. A skipped need cascades the skip to dependents (GitHub-documented), so every push event produced test: skipped (proof: master-push run 38665531939). The old comment in ci.yml ("skipped needs count as satisfied") was wrong and never held.

That hole is exactly how red reached master unnoticed three times: #3145 (port-collision storm, fixed by #3197), #3027 (storage-render golden drift, fixed by #3035).

Fix

test:
  needs: [ ... 9 guards ... ]
  if: ${{ !failure() && !cancelled() }}
event guards test legs
pull_request all 9 run guard failure → legs skip → required checks pending, merge blocked (#2637 fail-fast tiering unchanged)
push / dispatch 5 run, 4 skip legs RUN — master gets a real post-merge signal

Cost is bounded by the existing per-ref concurrency cancel-in-progress (owner-approved 2026-10-10): rapid back-to-back merges only pay for the last push (~7 min wall, 12 shards).

Verification

  • PR path (this PR's own CI): guards + 12 legs must all run and pass — identical to before (no behavior change on PRs).
  • Push path: verifiable the moment this merges — the master-push CI run must show 12 test (…) legs instead of test: skipped.

…ascade-skip the legs

The test job needs 9 guards; 4 are pull_request-only (version/kernel/
pi-subagents/lane-guard). A skipped need cascades the skip to dependents
(GitHub-documented behavior) — the workflow comment's 'skipped needs count
as satisfied' never held. Result: every master push ran CI with
'test: skipped' (e.g. run 38665531939), so master has had NO post-merge
unit-test signal — the hole that let #3145 (port collisions), #3027
(golden drift) and #3035 slip red to master unnoticed.

Fix: explicit 'if: !failure() && !cancelled()' on the test job:
- pull_request: guards run; a guard failure still skips the legs
  (required checks pending, merge blocked — #2637 fail-fast tiering intact)
- push/dispatch: PR-only guards skip harmlessly, the 12 shard legs RUN
  and master gets a real post-merge signal

Cost: bounded by the existing per-ref concurrency cancel (owner-approved
2026-10-10) — rapid merge sequences only pay for the last push.
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: fix/master-push-test-lane (e22f9fe)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.3707-pr.3219.685a05d

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr3219.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei
ranxianglei merged commit 494087c into master Oct 15, 2026
21 checks passed
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重结论:不重复(同根因前作已关闭,本 PR 为其继任)。同主题唯一前作是 #2907(agent PR,同一根因——#2637 把 4 个 pull_request-only 守卫塞进 needs,误以为「skipped needs 算满足」),机制不同(它移除 4 个守卫的事件门;本 PR 在 test 上显式 if 容忍跳过)。#2907 已于 2026-10-12 由你关闭未合并,本 PR 是当前在途方案,保留处理。近期 open/closed 中无其他同失败签名(CI job=CI/test、签名=test: skipped on push)的条目。

初审已核实的点(细节随最终八问回复):

  • 诊断属实:master-push run 38665531939 逐 job 核对 = 4 个 PR-only 守卫 skipped、5 个守卫 success、test: skipped。且同一个级联也打穿了 static-gates(该 run 里同样 skipped)——本 PR 只给 test 加了 if,static-gates 合入后在 push/dispatch 上仍会静默跳过(typecheck/kernel 套件/pi 套件/build 全部无 post-merge 信号)。这是同一个机制族的漏网项,我会在 PR 分支上补一个独立标注的小 commit 把同样的 if 加到 static-gates(一行,不拉锯)。
  • PR 路径零变化已按语义推演确认:PR 事件下 9 守卫全跑,全绿→腿照跑;任一守卫红→!failure() 假→腿 skip(与现状一致,required checks 不满足,merge 照旧被挡)。branch protection 实测 required contexts = 恰好 12 个 test (…) (os, node, shard) 腿(strict),与推演吻合。
  • base 落后 master 4 个提交(全是 fix: fail fast on dead upstreams — round-level circuit breaker + acp_status visibility (#3148) #3154 circuit-breaker 系,未触碰 ci.yml),GitHub 判定 mergeable、无冲突;push 路径的最终验证要等合入后那次 master-push run。

正在补 static-gates 的 commit,随后给完整八问结论。

@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.435-master.494087c (rolling master tag).

npm install -g billion-context@0.0.435-master.494087c  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

@ranxianglei
ranxianglei deleted the fix/master-push-test-lane branch October 15, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant