Repository navigation
ci: run the test matrix on master pushes — fix the skipped-needs cascade - #3219
Conversation
…ascade-skip the legs The test job needs 9 guards; 4 are pull_request-only (version/kernel/ pi-subagents/lane-guard). A skipped need cascades the skip to dependents (GitHub-documented behavior) — the workflow comment's 'skipped needs count as satisfied' never held. Result: every master push ran CI with 'test: skipped' (e.g. run 38665531939), so master has had NO post-merge unit-test signal — the hole that let #3145 (port collisions), #3027 (golden drift) and #3035 slip red to master unnoticed. Fix: explicit 'if: !failure() && !cancelled()' on the test job: - pull_request: guards run; a guard failure still skips the legs (required checks pending, merge blocked — #2637 fail-fast tiering intact) - push/dispatch: PR-only guards skip harmlessly, the 12 shard legs RUN and master gets a real post-merge signal Cost: bounded by the existing per-ref concurrency cancel (owner-approved 2026-10-10) — rapid merge sequences only pay for the last push.
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.3707-pr.3219.685a05dThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3219.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重结论:不重复(同根因前作已关闭,本 PR 为其继任)。同主题唯一前作是 #2907(agent PR,同一根因——#2637 把 4 个 初审已核实的点(细节随最终八问回复):
正在补 static-gates 的 commit,随后给完整八问结论。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.435-master.494087c # this exact build
npm install -g billion-context@master # always the newest merged build
|
What
Master pushes have never run the unit-test matrix: the
testjob needs 9 guards, 4 of which arepull_request-only. A skipped need cascades the skip to dependents (GitHub-documented), so every push event producedtest: skipped(proof: master-push run 38665531939). The old comment in ci.yml ("skipped needs count as satisfied") was wrong and never held.That hole is exactly how red reached master unnoticed three times: #3145 (port-collision storm, fixed by #3197), #3027 (storage-render golden drift, fixed by #3035).
Fix
Cost is bounded by the existing per-ref concurrency cancel-in-progress (owner-approved 2026-10-10): rapid back-to-back merges only pay for the last push (~7 min wall, 12 shards).
Verification
test (…)legs instead oftest: skipped.