Skip to content

fix: pin dsh.bundle.patch.yml to LF + normalize CRLF before byte-exact includes (#2631) - #2634

Merged
ranxianglei merged 1 commit into
masterfrom
2026-10-10_bundle-eol-lf
Oct 10, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-10-10_bundle-eol-lf

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Fixes #2631

Ship-first per owner: this unblocks the v0.1.191 release PR #2630 (its Windows legs are deterministic red on current master until this lands).

What

Exactly the fix the issue proposes, nothing more:

  1. .gitattributes: dsh.bundle.patch.yml text eol=lf — same test: wire-contract anti-regression system — parity fakes, goldens, unified ledger #1305 precedent as the golden JSONs.
  2. tests/issue2605-dsh-retry-patch.test.ts: replaceAll("\r\n", "\n") after read — belt-and-suspenders for checkouts that bypass gitattributes.

Verification

  • Simulated the Windows failure locally: converted dsh.bundle.patch.yml to CRLF on disk → before the fix the bundle-lane assert fails (compaction-basic auto:false row must stay intact), after it 2/2 tests pass (bundle lane + overlay lane).
  • Clean checkout (LF): 2/2 pass. Typecheck clean.
  • No source change — CI-only/test-only + gitattributes; npm artifact unaffected.

§7.4 self-check

Fix-scoped, regression-proven, no config/persistence/wire/kernel surface — auto-merge eligible per §7.4 except it's on the CI-critical path during an active release; human review requested. Merge order for the release: merge THIS PR → merge master into 2026-10-10_release-v0.1.191 (I'll push that immediately after) → windows legs go green → merge #2630.

…t includes (#2631)

#2605's bundle test asserts byte-exact multi-line literals against the
shipped dsh.bundle.patch.yml; Git-for-Windows checks it out CRLF
(autocrlf) and the includes fail on every Windows leg since #2610
merged — master's test (windows-latest, 22|24) legs have been red
since 07:30Z, blocking every PR's required checks (#2631).

Same failure class as #1305 (golden JSONs): pin eol=lf in
.gitattributes, and belt-and-suspenders normalize CRLF after read in
the test so checkouts that bypass gitattributes still pass.
@ranxianglei
ranxianglei merged commit 2d31e42 into master Oct 10, 2026
25 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-10_bundle-eol-lf (7cf6796)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.2847-pr.2634.7056494

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr2634.tgz
npm install -g package

Install instructions are refreshed on each push.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.218-master.2d31e42 (rolling master tag).

npm install -g billion-context@0.0.218-master.2d31e42  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows CI 全红:#2610 新增的 bundle-patch 测试对 CRLF 签出的 yml 做字节级精确匹配(.gitattributes 未覆盖)

1 participant