Repository navigation
fix(#2623): pin dsh.bundle.patch.yml to LF checkout so windows-latest CI goes green - #2632
Closed
ranxianglei wants to merge 2 commits into
Closed
ranxianglei wants to merge 2 commits into
ranxianglei wants to merge 2 commits into
Conversation
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.2841-pr.2632.6f33dafThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr2632.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
|
Superseded by #2634 (merged as 7cf6796, on master as 2d31e42). A parallel report of the same root cause (#2631) landed first with a functionally identical two-layer fix:
Line-by-line diff of this branch against current master shows only comment wording differs; merging would churn already-fixed lines with zero functional gain. This PR's own CI already proved the mechanism on a real windows-latest runner ( Closing as superseded — the fix ships via #2634. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2623
Root cause
tests/issue2605-dsh-retry-patch.test.ts(added by eb0e4d2, #2605) assertsincludes()against LF-anchored row constants read from the committeddsh.bundle.patch.yml. The blob is pure LF, but.gitattributesonly pinnedtext eol=lffortests/golden/wire-contract/*.json(#1305). On windows-latest runners Git-for-Windows' defaultcore.autocrlf=truematerializes the yml as CRLF at checkout, so every exact match fails — the twotest (windows-latest, *)jobs have been red on every commit since eb0e4d2.Verified locally through git's own conversion path, not just sed:
core.autocrlf=truecore.autocrlf=trueFix (two layers, one mechanism)
.gitattributes:/dsh.bundle.patch.yml text eol=lf— fixes the producer (checkout materialization) at the VCS layer, same precedent as the test: wire-contract anti-regression system — parity fakes, goldens, unified ledger #1305 golden pin. Expliciteol=lfoverridesautocrlf=true, proven above. Also protects any future byte-exact consumer of the shipped file.tests/issue2605-dsh-retry-patch.test.ts: normalize\r\n→\nbefore matching — pins logical row content instead of EOL bytes, so a stray CRLF checkout (existing Windows clones until they re-checkout the file, or any non-git materialization) cannot red the gate again. All teeth remain: any drift in the restated rows/codes still fails.Behavior changes
None. CI hygiene only — user-facing patch content is generated in-memory with LF (
writeDshAcpPatch) and the shipped blob is unchanged (still pure LF).Note: pre-existing Windows developer clones keep their CRLF worktree copy of this file until they re-checkout it (
git checkout -- dsh.bundle.patch.yml); irrelevant to CI, which always checks out fresh.