Repository navigation
fix: drop orphaned export on codexRewriteInsertionIndex (Fixes #2314) - #2315
ranxianglei wants to merge 1 commit into
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)This exact version is immutable and reproducible. The rolling Option B — Download artifact
Install instructions are refreshed on each push. |
[bot] 🏷 Review of PR #2315 (head 结构化七问
本地定向验证(全量套件/typecheck 按本地测试纪律留给 CI):
CI 状态(head 其他核查:PR base = 当前 master HEAD( 判定:可合并——待 test matrix 跑完转绿即可合入(当前已完成的所有 check 均绿)。合并请人工操作:#2315 |
[bot] 🏷 跟进:head |
a4f2730 (ranxianglei#3811) introduced maskUrlForPublish with an export, but nothing outside src/log-mask.ts imports it (only maskUrlsForPublish below calls it), so scripts/check-unused-exports.mjs fails with: INTERNAL_ONLY src/log-mask.ts: maskUrlForPublish Dropping the export keyword makes the gate pass again; no behavior change. Same treatment as ranxianglei#2315 applied to maskUrlsInText.
What
One-line fix for the red
unused-exportsgate on master (#2314). Drops the leadingexportfromcodexRewriteInsertionIndexatsrc/launcher.ts:1020.Root cause
PR #2282 (
5336c0700) added the function withexport, though its only caller is internal (src/launcher.ts:980). It merged green because the unused-export gate did not exist on master yet. PR #1443 then landed the gate (scripts/check-unused-exports.mjs) after #2282 and immediately detected the orphaned export — so master itself is red and every PR based on it fails the check.Verification
node scripts/check-unused-exports.mjs→✗ 1 unused export(s): INTERNAL_ONLY src/launcher.ts: codexRewriteInsertionIndex(exit 1).src/,tests/, orscripts/(full-repo grep: only the definition + internal call site + a doc comment).src/launcher.tsis not an entry file (absent fromtsup.config.ts), so it is not exempt from the gate.✓ unused-export gate: clean (3 waived));npm run typecheckclean.Behavior change
None. The function keeps its name, signature, and all internal call sites; only its module visibility narrows from exported to module-private. No wire, config, persistence, or kernel surface touched.
Full suite/build left to CI per local-testing discipline (change touches no request-pipeline path).
Closes #2314