Repository navigation
fix: clear the 7 root-tsconfig type errors gating master typecheck (#2003) - #2006
ranxianglei wants to merge 2 commits into
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.2022-pr.2006.9f78dc9This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr2006.tgz
npm install -g packageInstall instructions are refreshed on each push. |
…2003) Test-side only, zero src changes, zero runtime changes: - codex-responses-ws: cast request.tools / request.input / error.error off the Item record type instead of optional-chaining through unknown - ws-bridge: handler returns Promise<void>; type the close-wait Promise - issue1993-preflight-400: import ProxyOptions from src/config.ts (its definition home) instead of the non-exported src/server.ts binding Fixes #2003
fbcc7fa to
0ac6b45
Compare
[bot] 🏷 PR #2006 review — 可合并(CI 已全绿) 结论先行:这是把 master 的 root-tsconfig typecheck 门从 RED 拉回 GREEN 的解锁 PR。我独立复现了基线、逐行核对了 diff、本地验证了修法,并确认了当前 head 的 CI 状态。
我的验证(证据,非复述 diff):
结构化七问:
顺带说明(均不阻塞):
收工判定:CI 已全绿、diff 干净(每行都服务于本 issue)、零回归——可直接合并。合并后所有 open PR 经 merge-ref 继承绿色 typecheck,#1632 等同步解锁。 |
|
[bot] 🏷 重复判定:与 #2007 同题同失败域(master typecheck 12 错),打「重复」标签,保持打开待 owner 拍板方案。 两者实测对比(均基于当前 master tip 33d58e5):
唯一差异即上表最后一行。建议:默认合 #2007(集中补全模块契约,后续从 server.ts 取 startServer 参型的写法不再踩坑);若 owner 偏好零 src 变更,则合本 PR、关 #2007——二选一,避免双合并冲突。完整 review 见 #2007 帖。 |
Fixes #2003.
What: the 7 type errors that made master's four required
testchecks RED at 129200d (and, via the merge ref, every open PR's):tests/codex-responses-ws.test.ts— 4× (tools/input/error typed throughItem = Record<string, unknown>): explicit casts instead of optional-chaining throughunknowntests/ws-bridge.test.ts— 2× (handler must returnPromise<void>; untyped close-wait Promise)tests/issue1993-preflight-400.test.ts— 1× (ProxyOptionsimported fromsrc/config.ts, its definition home, instead of the non-exportedsrc/server.tsbinding)Scope: test-side only — no src changes, no runtime changes, no behavior changes. Zero diff outside the 3 files named in #2003.
Evidence (branch = master + this one commit):
npx tsc --noEmit --project tsconfig.json→ 0 errors (was 7)node --import tsx --test tests/codex-responses-ws.test.ts tests/ws-bridge.test.ts tests/issue1993-preflight-400.test.ts→ 13/13 passMerge note: master is currently red — this PR is the unblock; every other open PR (incl. #1632) turns green automatically once this lands, because the errors are inherited through the merge ref.
Found while hardening #1632's CI lane; filed separately per one-issue-one-scope.