You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
master typecheck RED since #1968/#1994 merges: 7 errors in 3 test files — blocks every open PR's required checks #2003
tests/codex-responses-ws.test.ts(144,198): error TS2339: Property 'map' does not exist on type '{}'.
tests/codex-responses-ws.test.ts(192,42): error TS2571: Object is of type 'unknown'.
tests/codex-responses-ws.test.ts(192,76): error TS7006: Parameter 'item' implicitly has an 'any' type.
tests/codex-responses-ws.test.ts(242,22): error TS18046: 'error.error' is of type 'unknown'.
tests/issue1993-preflight-400.test.ts(17,28): error TS2459: Module '"../src/server.ts"' declares 'ProxyOptions' locally, but it is not exported.
tests/ws-bridge.test.ts(45,67): error TS2322: Type 'Promise<ServerResponse<IncomingMessage>>' is not assignable to type 'Promise<void>'.
tests/ws-bridge.test.ts(111,59): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
Fix PR: #2006 (test-side only, 3 files named above; tsc -p tsconfig.json 0 errors, 13/13 tests pass locally). Master's four required checks turn green on merge; every open PR inherits the green through the merge ref.
Update: master moved again (#1989 → 33d58e5) and brought 5 more errors of the same class in tests/issue1987-preflight-baseline-anchor.test.ts (ProxyOptions import from src/server.ts + 2× address().port null/string narrowing). The preflight lane keeps copy-pasting the same broken import pattern — see #2006 which now clears all 12 (rebased onto 33d58e5, tsc 0 errors, 14/14 tests pass).
Activity
ranxianglei commentedon Oct 3, 2026
Fix PR: #2006 (test-side only, 3 files named above;
tsc -p tsconfig.json0 errors, 13/13 tests pass locally). Master's four required checks turn green on merge; every open PR inherits the green through the merge ref.ranxianglei commentedon Oct 3, 2026
[bot] 🏷 PR 已开:#2005 → #2005 #2003)
审核过程(动手前完成):
npm ci && npx tsc --noEmit --project tsconfig.json@ 129200d → 恰好 issue 所列 7 条,无多无少。ProxyOptions的导出源是src/config.ts:598,src/server.ts:11只是本地 import 别名(TS 因此报 TS2459);改导入源与其余 20+ 个测试文件的既有做法一致,零重声明漂移风险。结构化七问:
Item[]cast(debug arg tools、input.find、error.error,断言语义不变);issue1993 把ProxyOptions导入源从 server.ts 改为src/config.ts;ws-bridge dispatch fake 改 async 块体(返回Promise<void>,对齐 src/ws-bridge.ts:81 签名)、new Promise补<void>泛型。关于附带发现(
enforce_admins=false允许带红 checks 合并):这是仓库分支保护设置决策(是否对 admins 也 enforce required checks),属 owner 拍板事项,我不擅动设置、也不另行立项(已在 #2003 正文记录)。建议方向:开 enforce admins,或至少约定合并前等 required checks 绿——本次三个红色 merge(#1968/#1994)若有一道门拦住,这条 issue 就不会存在。收工判定:CI 绿后可直接合并。PR 仅 3 个测试文件、7+/6-,diff 每一行都与本 issue 相关。
fix: clear the 7 root-tsconfig type errors gating master typecheck (#…
fix: clear the issue1987 preflight-baseline-anchor type errors landed…
ranxianglei commentedon Oct 3, 2026
Update: master moved again (#1989 → 33d58e5) and brought 5 more errors of the same class in
tests/issue1987-preflight-baseline-anchor.test.ts(ProxyOptions import from src/server.ts + 2×address().portnull/string narrowing). The preflight lane keeps copy-pasting the same broken import pattern — see #2006 which now clears all 12 (rebased onto 33d58e5, tsc 0 errors, 14/14 tests pass).ranxianglei commentedon Oct 3, 2026
[bot] 🏷 收敛完成:关闭我早开的 #2005,#2006 为本 issue 唯一修复 PR。
发生了什么:两个 agent 会话被并行派发到本 issue,16 秒内各开一个 PR(#2005 @15:22:43Z、#2006 @15:22:59Z)——违反「一个 issue 至多一个 PR」。期间 master 又前移(#1989 → 33d58e5),在
tests/issue1987-preflight-baseline-anchor.test.ts带入同族 5 条错误(同样的ProxyOptions从 server.ts 导入陷阱 ×1 +address().portnarrowing ×2),总数 7 → 12。为何留 #2006、关 #2005:
0ac6b459)做了独立验证(不采信单方报告):tsc --noEmit -p tsconfig.json= 0 错误;四个改动文件定向跑 14/14 pass;CI 侧 ubuntu×2 test job 已绿(windows×2 in_progress)。error.error用{ code: string }精确断言、新文件补AddressInfoimport,均符合仓库既有模式。无质量差异足以翻盘。结构化七问:
ProxyOptionsfromsrc/server.ts,该模块只本地 import 未导出 → TS2459)——issue1993 与 issue1987 两个文件接连踩中。系统性建议(未入本 PR):footgun 的根因是
src/server.ts导出startServer(opts: ProxyOptions)却不 re-export 该类型,新测试文件天然倾向写错导入源——本次已两次发生。一行export type { ProxyOptions } from "./config.js"可在源头消灭这类 TS2459。因涉及 hot file(server.ts,虽纯类型零运行时影响)且 #2006 分支另一会话仍在活跃迭代(已观察到 force-update),我不中途推入其分支;#2006 合并后我会开一个小 follow-up PR 落这一行,或 owner 另有指示。收工判定:#2006 windows×2 CI 转绿后即可直接合并;合并后所有 open PR 的 required checks 经 merge ref 恢复绿色。
ranxianglei commentedon Oct 3, 2026
[bot] 🏷 补报:#2006(
0ac6b459)全量 CI 14/14 全绿(含 windows×2 test job,FAILURES: none)。本地独立验证(tsc 0 错误、定向 14/14)+ 远程 CI 双重通过,#2006 已具备合并条件,required checks 转绿。合并后所有 open PR(含 #1632 等无关 PR)的 required checks 将经 merge ref 同步恢复绿色。
ProxyOptionsre-export 一行 follow-up 按前述承诺在合并后提交。