Repository navigation
[PR] fix(#1977): release-notes visibility silent by default — advisories are the only auto-visible channel - #1979
ranxianglei wants to merge 1 commit into
Conversation
…s stay the only auto-visible channel
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.1988-pr.1979.e191f3fThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr1979.tgz
npm install -g packageInstall instructions are refreshed on each push. |
[bot] 🏷 PR #1979 审查结论(自审) 已拉取分支 1. 是什么问题:#1870 的分层 release-notes 可见性 surface( 2. 什么原因导致的:可见性设计本身是「纯展示」但默认 ON,叠加 tier 分布失衡 → 提示行对几乎所有版本都触发。这是产品可见性策略问题(非代码 bug),由 owner 拍板调整方向,不是修某个函数。 3. 怎么修复的:删除两个渲染面 + 删除已无人消费状态的 watcher + 移除因此变死的配置面。具体: 4. 是否有回归问题:无。逐项审过既有行为:
5. 是否破坏缓存:不涉及。唯一被移除的缓存是 watcher 自己的 release-notes fetch+cache,其唯一消费者( 6. 是否改了设计方向:不涉及架构转向。收敛的是可见性策略(默认静默);数据管线保留—— 7. 是否引入了新的配置:无新增,只有移除: 两点说明(均不阻塞):
验证:CI 全绿(head 判定:可合并(无阻塞问题)。建议 owner 直接合并;若要我先 rebase 到最新 master 说一声即可。 |
…tical-tier releases Option C compromise: keep the ranxianglei#1870 watcher and surfaces, silent by default. New 'critical' tier is the only one that ever surfaces (CRITICAL UPDATE READY / CRITICAL UPDATE AVAILABLE); 'recommended' becomes record-only, and a pending restart alone no longer announces itself — only when the pending span carries a critical entry. - ReleaseTier += critical (parser + CI validator + docs) - getUpdateVisibility: visible = critical-in-span (ranxianglei#1977) - describeUpdateReady / acp_status wording: Critical update … - release-notes/package.json: re-tier inflated recommended -> routine (5 of 6 entries were 'recommended' — the nag ranxianglei#1977 complained about) - CONFIGURATION.md/.zh-CN, release-notes/README.md, reference/release.md: tier discipline documented Supersedes ranxianglei#1979 (full removal) per owner: 不能完全静默.
|
(ai: zhipuai-lb/glm-5.3) 陈旧票清理(第三批动作①):目标 issue #1977 已关。为避免重复劳动关闭本 PR;如判断有误请直接 reopen 并留言。 |
Closes #1977.
What changes
/acppanel footer: theUpdate ready: X — restart to finish/Update available: X (recommended) — <summary>line is gone. The⚠️ CRITICAL ADVISORYline (its before-footer neighbor) stays untouched.acp_status: theUPDATE READY/UPDATE AVAILABLEblock with the per-release span is gone. TheCRITICAL ADVISORY (instance-level)block stays untouched.src/update-notes.tsdeleted (plustests/update-notes.test.ts) — after the surfaces go, nothing consumes the state, so the 3-min fetch cycle is pure waste.Config surface
Removed (per §3, explicit report): env
BILI_RELEASE_NOTES_CHECK, envBILI_RELEASE_NOTES_URL, file keysreleaseNotesCheck/releaseNotesUrl(CONFIGURATION.md + CONFIGURATION.zh-CN.md rows deleted). Rationale: they only gated the removed watcher/surfaces; keeping them would be dead surface. Compat: any user who set them gets them silently ignored — no migration needed. No new fields.What deliberately stays
release-notes/doc + CI validator/publish (release-notes.yml) — entries remain a release-process requirement: the dispatch-time gate inrelease-manual.yml/release.yml(发版可见性:分级标签的 release 元数据(模型撰写摘要)+ 用户版跨 span 更新说明 + acp_status //acp 面板送达「更新已就绪待重启」(#1577 延伸) #1870) still fails a stable release without its entry (see docs(release-notes): 0.1.181 entry + 0.1.180 backfill (#1870) #1975 for the 0.1.181 entry this release cycle needs).Both-modes note
No wire/protocol change — the removed lines were host-side renders only (panel pre-footer slot, acp_status text). plugin mode and proxy mode are equally unaffected.
Verification
npm run typecheck✔,npm run build✔ (0 occurrences ofUpdate ready|Update availableindist/index.js).update-notes/ removed config keys anywhere in src/tests/docs.