Skip to content

[PR] fix(#1977): release-notes visibility silent by default — advisories are the only auto-visible channel - #1979

Closed
ranxianglei wants to merge 1 commit into
masterfrom
2026-10-03_release-notes-silent
Closed

ranxianglei wants to merge 1 commit into
masterfrom
2026-10-03_release-notes-silent

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Closes #1977.

What changes

  • /acp panel footer: the Update ready: X — restart to finish / Update available: X (recommended) — <summary> line is gone. The ⚠️ CRITICAL ADVISORY line (its before-footer neighbor) stays untouched.
  • acp_status: the UPDATE READY / UPDATE AVAILABLE block with the per-release span is gone. The CRITICAL ADVISORY (instance-level) block stays untouched.
  • Watcher removed: src/update-notes.ts deleted (plus tests/update-notes.test.ts) — after the surfaces go, nothing consumes the state, so the 3-min fetch cycle is pure waste.
  • Net effect: updates are silent by default. Critical defects still auto-surface (and can force-upgrade) through the advisory system (搞一个自动强制更新,针对重大bug的版本 #1481) — panel, acp_status, web banner, stderr.

Config surface

Removed (per §3, explicit report): env BILI_RELEASE_NOTES_CHECK, env BILI_RELEASE_NOTES_URL, file keys releaseNotesCheck / releaseNotesUrl (CONFIGURATION.md + CONFIGURATION.zh-CN.md rows deleted). Rationale: they only gated the removed watcher/surfaces; keeping them would be dead surface. Compat: any user who set them gets them silently ignored — no migration needed. No new fields.

What deliberately stays

Both-modes note

No wire/protocol change — the removed lines were host-side renders only (panel pre-footer slot, acp_status text). plugin mode and proxy mode are equally unaffected.

Verification

  • npm run typecheck ✔, npm run build ✔ (0 occurrences of Update ready|Update available in dist/index.js).
  • Targeted suites: config 6/6, acp-status + plugin-status + plugin + update + advisory 23/23 ✔.
  • No remaining references to update-notes / removed config keys anywhere in src/tests/docs.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-03_release-notes-silent (c4af34d)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.1988-pr.1979.e191f3f

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr1979.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 PR #1979 审查结论(自审)

已拉取分支 2026-10-03_release-notes-silent(head c4af34de)逐文件核对。这是本 agent 已完成的工作,不重做——以下为结构化七问。

1. 是什么问题:#1870 的分层 release-notes 可见性 surface(/acp panel footer 行 + acp_status UPDATE 块)默认开启;因 recommended tier 被过度使用(release-notes/package.json 6 条里 5 条是 recommended),用户几乎每个版本都被打断。owner 决策(2026-10-03):默认静默,只有 critical advisory(#1481)可自动浮出。

2. 什么原因导致的:可见性设计本身是「纯展示」但默认 ON,叠加 tier 分布失衡 → 提示行对几乎所有版本都触发。这是产品可见性策略问题(非代码 bug),由 owner 拍板调整方向,不是修某个函数。

3. 怎么修复的:删除两个渲染面 + 删除已无人消费状态的 watcher + 移除因此变死的配置面。具体:src/plugin.ts handlePluginStatus 去掉 describeUpdateReady 行;src/acp-status.ts handleAcpStatus 去掉 UPDATE READY/AVAILABLE 块;删 src/update-notes.ts(323 行)+ tests/update-notes.test.ts(272 行);src/config.ts 移除 releaseNotesCheck/releaseNotesUrl(ProxyOptions/FileConfig/loadOptions);src/cli.ts main() 移除 startReleaseNotesWatcher 启动块;CONFIGURATION.md/.zh-CN.md 各删 2 行 env 文档。advisory 链(force-upgrade、panel/acp_status/web/stderr 四处浮出)完整保留。

4. 是否有回归问题:无。逐项审过既有行为:

  • ⚠️ CRITICAL ADVISORY 行在 src/plugin.ts:866 与 src/acp-status.ts:148 原样保留,顺序未变;
  • 全树 grep 确认对任何被删符号/配置 key(getUpdateVisibility/describeUpdateReady/startReleaseNotesWatcher/releaseNotes*/BILI_RELEASE_NOTES*)零残留引用;
  • 无孤儿 import:acp-status.ts 的 VERSION 仍在 :52 使用;cli.ts 的 PACKAGE_NAME/resolveProxy 在多处仍用;
  • 配置后向兼容:这两个 key 从来就不在 KNOWN_TOP_LEVEL_KEYS(见下方注),所以本 PR 未引入任何新告警;
  • 全树 grep 确认无遗留测试断言被删的输出串(Update ready/UPDATE READY/restart to finish 等);
  • 两个删除文件确认在 head 上真正不存在。

5. 是否破坏缓存:不涉及。唯一被移除的缓存是 watcher 自己的 release-notes fetch+cache,其唯一消费者(getUpdateVisibility)一并删除,无跨功能缓存依赖被打破。advisory 的缓存/重试链未动。

6. 是否改了设计方向:不涉及架构转向。收敛的是可见性策略(默认静默);数据管线保留——release-notes/ 包发布(release-notes.yml)、dispatch-time release gate(#1870)仍是发版硬要求,tier+summary 字段降级为机器可读记录(暂无渲染消费者)。

7. 是否引入了新的配置:无新增,只有移除:BILI_RELEASE_NOTES_CHECK/BILI_RELEASE_NOTES_URL env + releaseNotesCheck/releaseNotesUrl file key。迁移方式:旧值失效。

两点说明(均不阻塞):

验证:CI 全绿(head c4af34de)——typecheck/build-artifact ✔、ubuntu+windows(node 22/24)全套测试 ✔、hermetic registry e2e(self-update 链)✔、real pi/dsh/opencode/codex lane ✔、version-guard ✔。本地另做了逐文件静态核对(上方各 grep)。

判定:可合并(无阻塞问题)。建议 owner 直接合并;若要我先 rebase 到最新 master 说一声即可。

antclt pushed a commit to antclt/billion-context that referenced this pull request Oct 3, 2026
…tical-tier releases

Option C compromise: keep the ranxianglei#1870 watcher and surfaces, silent by
default. New 'critical' tier is the only one that ever surfaces
(CRITICAL UPDATE READY / CRITICAL UPDATE AVAILABLE); 'recommended'
becomes record-only, and a pending restart alone no longer announces
itself — only when the pending span carries a critical entry.

- ReleaseTier += critical (parser + CI validator + docs)
- getUpdateVisibility: visible = critical-in-span (ranxianglei#1977)
- describeUpdateReady / acp_status wording: Critical update …
- release-notes/package.json: re-tier inflated recommended -> routine
  (5 of 6 entries were 'recommended' — the nag ranxianglei#1977 complained about)
- CONFIGURATION.md/.zh-CN, release-notes/README.md, reference/release.md:
  tier discipline documented

Supersedes ranxianglei#1979 (full removal) per owner: 不能完全静默.
@ranxianglei ranxianglei mentioned this pull request Oct 4, 2026
@ranxianglei

Copy link
Copy Markdown
Owner Author

(ai: zhipuai-lb/glm-5.3)

陈旧票清理(第三批动作①):目标 issue #1977 已关。为避免重复劳动关闭本 PR;如判断有误请直接 reopen 并留言。

@ranxianglei ranxianglei changed the title fix(#1977): release-notes visibility silent by default — advisories are the only auto-visible channel [PR] fix(#1977): release-notes visibility silent by default — advisories are the only auto-visible channel Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release-notes visibility should be silent by default (owner decision) — advisories stay the only auto-visible channel

1 participant