Skip to content

fix(#1977): release-notes visibility surfaces only for critical-tier releases - #1983

Merged
ranxianglei merged 3 commits into
masterfrom
2026-10-03_release-notes-critical-tier
Oct 3, 2026
Merged

ranxianglei merged 3 commits into
masterfrom
2026-10-03_release-notes-critical-tier

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Closes #1977 — the compromise variant ("不能完全静默"), supersedes #1979 (full removal — recommend closing that one in favor of this).

Problem

#1870 surfaces update notices on acp_status + the /acp panel by default, and the tier got inflated: 5 of 6 entries in release-notes/package.json are recommended, so users see a nag nearly every release.

Approach (Option C)

Keep the watcher and the surfaces, but silent by default: a new critical tier is the ONLY thing that ever surfaces.

  • ReleaseTier += "critical" (parser, CI validator, docs)
  • getUpdateVisibility: visible = span contains critical — routine/recommended never surface; a pending restart alone is silent too (it only speaks when the pending span carries a critical entry, because the restart matters then)
  • describeUpdateReady / acp_status wording → Critical update ready: … restart to finish. / CRITICAL UPDATE READY (instance-level) / CRITICAL UPDATE AVAILABLE (instance-level)
  • release-notes/package.json: re-tier the inflated recommended entries → routine (none meet the critical bar; advisory-class defects went to advisories/)
  • Tier discipline documented (en + zh): critical = serious defect users must act on, below the advisory force-upgrade bar, used sparingly; recommended = record-only since Release-notes visibility should be silent by default (owner decision) — advisories stay the only auto-visible channel #1977
  • Force-upgradeable defects still go to advisories/ (搞一个自动强制更新,针对重大bug的版本 #1481) — entries here never trigger the safety chain

Verification

Notes

…releases

Option C compromise: keep the #1870 watcher and surfaces, silent by
default. New 'critical' tier is the only one that ever surfaces
(CRITICAL UPDATE READY / CRITICAL UPDATE AVAILABLE); 'recommended'
becomes record-only, and a pending restart alone no longer announces
itself — only when the pending span carries a critical entry.

- ReleaseTier += critical (parser + CI validator + docs)
- getUpdateVisibility: visible = critical-in-span (#1977)
- describeUpdateReady / acp_status wording: Critical update …
- release-notes/package.json: re-tier inflated recommended -> routine
  (5 of 6 entries were 'recommended' — the nag #1977 complained about)
- CONFIGURATION.md/.zh-CN, release-notes/README.md, reference/release.md:
  tier discipline documented

Supersedes #1979 (full removal) per owner: 不能完全静默.
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-03_release-notes-critical-tier (a32ba1c)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.1999-pr.1983.a4b537a

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr1983.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 收到。这是 [PR] 类 issue(对应 GitHub PR #1983,open / mergeable / CI blocked)。按 PR Review 规范开始审查:先审原 issue #1977 的方向,再拉分支核对代码、回归面、测试有效性与 diff 整洁度,最后给结构化七问结论。审查中,稍后更新。

ework-daemon and others added 2 commits October 3, 2026 17:17
 display policy

- src/cli.ts watcher-start comment: 'learn a recommended update exists'
  -> 'learn when a critical-tier fix exists' (recommended is record-only now)
- release.yml release-notes gate comment: tier enumeration gains critical
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

审查完成(分支 2026-10-03_release-notes-critical-tier,审到 a32ba1c)。结论:可合并,等 CI 绿(CI 正在跑该 head)。

结构化七问

  1. 是什么问题:发版可见性:分级标签的 release 元数据(模型撰写摘要)+ 用户版跨 span 更新说明 + acp_status //acp 面板送达「更新已就绪待重启」(#1577 延伸) #1870 把 release-notes 更新提示默认展示在 acp_status + /acp 面板上,而 release-notes/package.json 里 6 条有 5 条是 recommended——提示退化成几乎每次发版都 nag。本 PR 落实你定的折中方案("不能完全静默"):watcher 和展示面保留,但默认静默,新增的 critical 层是唯一会浮出的东西。
  2. 什么原因导致的:展示策略绑定在「span 非空」而不是「严重度」上;团队把 recommended 当成常规发版的记录层在用,tier 通胀后信号价值归零。根因是可见性判据缺一个真正的严重度门槛,不是某条数据写错。
  3. 怎么修复的:ReleaseTier += "critical"(parser、release-notes.yml CI validator、en+zh 文档四处对齐);getUpdateVisibility 改为 visible = span 含 critical,pending restart 单独不再发声(只有 pending span 带 critical 才说,因为那时重启才有意义);措辞改 Critical update ready/available …;5 条通胀的 recommended 全部降回 routine;tier 纪律写明(en+zh):critical = 用户必须行动的重大缺陷、低于 advisory 强升档、慎用;recommended 自 Release-notes visibility should be silent by default (owner decision) — advisories stay the only auto-visible channel #1977 起仅记录。强升类缺陷仍走 advisories/(搞一个自动强制更新,针对重大bug的版本 #1481),这里的条目永不触发安全链。
  4. 是否有回归问题:逐项审过既有行为——
    • advisory 自动升级通道(搞一个自动强制更新,针对重大bug的版本 #1481):未触碰,advisory 面板行与本次改动正交;
    • 一键发布门禁(release.yml / release-manual.yml dispatch-time entry check):只查条目存在性,任意 tier 都过,critical 条目不受影响;
    • wire/消息形态:无变化,纯 host 侧渲染文案,两种压缩模式(plugin/proxy)均不涉及;
    • 持久化/会话状态:无变化(watcher 状态进程内,throttle 文件语义不变);
    • 配置面:BILI_RELEASE_NOTES_CHECK / BILI_RELEASE_NOTES_URL 语义未变(关的是 watcher),CONFIGURATION en/zh 同步更新;
    • 有意行为变更(即本 PR 目的):默认从「任何新 span 都提示」→「仅 critical span 提示」,旧值→新值已在 PR 描述披露。未发现无意回归。
  5. 是否破坏缓存:不涉及。watcher/throttle 去重键未动,与 LLM 前缀缓存无关。
  6. 是否改了设计方向:架构不转向——发版可见性:分级标签的 release 元数据(模型撰写摘要)+ 用户版跨 span 更新说明 + acp_status //acp 面板送达「更新已就绪待重启」(#1577 延伸) #1870 的 watcher + 双展示面原样保留,只换了可见性谓词。一点透明化说明:Release-notes visibility should be silent by default (owner decision) — advisories stay the only auto-visible channel #1977 OP 的非目标写了「no new tier」,本 PR 折中方案实际引入了 critical tier;这是你后续拍板覆盖了原 OP 表述,不算违规,但记录在此以免日后翻案时疑惑。
  7. 是否引入新配置:无。没有新 env/config/默认值。

测试有效性

tests/update-notes.test.ts 重写后的断言有牙:recommended-only span 不可见、pending restart 无 critical 保持静默、critical 单独可见(with/without disk)、acp_status 静默态用子串断言(!includes("UPDATE READY") 同时覆盖新旧两种措辞,恒真风险为零)、/acp 面板 $ 转义保留。本地跑了受影响的全部相关套件(update-notes / acp-status / acp-panel / advisory-panel / advisory / plugin-protocol / update-restart-reminder)87/87 通过,typecheck 干净,grep 确认无残留旧字符串引用、模块导入方仅 plugin.ts / acp-status.ts / cli.ts 三处。

顺手小修(已推,标注 commit 745f9286)

review 中发现两处注释与新行为矛盾,按「小问题直接修」直接修掉:

  • src/cli.ts:634-637 watcher 启动注释还写「learn a recommended update exists」→ 改为 critical-tier 措辞;
  • .github/workflows/release.yml:78 发布门禁注释的 tier 枚举缺 critical → 补上。

均为既有注释的事实性更正,不含逻辑变更。

其他

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

CI 已全绿(head a32ba1ca,含你合入 master 后的完整套件):PR Build Artifact / CI(ubuntu 22+24, windows 22+24)/ e2e-local-registry / e2e-fake-codex / e2e-native-dsh / e2e-native-opencode / e2e-native-pi / Windows codex overlay —— 8/8 success。

收工判定:可合并,等你人工 merge。合并后记得顺手关掉被取代的 #1979。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release-notes visibility should be silent by default (owner decision) — advisories stay the only auto-visible channel

1 participant