This repository was archived by the owner on May 11, 2026. It is now read-only.
fix: replace silent catch with error logging#59
Closed
AmSach wants to merge 4 commits into
Closed
Conversation
- Changed .catch(() => {}) to .catch(err => console.error(...))
- Now logs the error message instead of silently swallowing it
Signed-off-by: Aman Sachan <amansachan92905@gmail.com>
Signed-off-by: Aman Sachan <amansachan92905@gmail.com>
AmSach
added a commit
to AmSach/live-countdown-bot
that referenced
this pull request
May 7, 2026
- Applied prettier --write to all JS files - Trailing comma style was inconsistent across 12 files - Resolves CI 'Check formatting' failure on PR radiantly#59
This fixes the Check formatting CI failure by applying consistent Prettier formatting across all JavaScript files. Signed-off-by: Aman Sachan <amansachan92905@gmail.com>
AmSach
force-pushed
the
fix/silent-catch-error-handling
branch
from
c45e186 to
b558906
Compare
Owner
|
Hi @AmSach, thank you for attempting to contribute. However:
|
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug I found while browsing. Replaced the silent .catch(() => {}) with proper error logging in bot.js. Previously, when the bot failed to send a welcome message to a guild's system channel, the error was silently swallowed. Now it logs the error message for debugging.
Before:
After: