This repository was archived by the owner on May 11, 2026. It is now read-only.
fix CI: upgrade Node.js from 17 to 20#60
Closed
AmSach wants to merge 3 commits into
Closed
Conversation
- Changed .catch(() => {}) to .catch(err => console.error(...))
- Now logs the error message instead of silently swallowing it
Signed-off-by: Aman Sachan <amansachan92905@gmail.com>
Signed-off-by: Aman Sachan <amansachan92905@gmail.com>
Author
|
The CI is failing because the workflow uses Node.js 17 but pnpm 11+ requires Node.js v22+. Here's the fix for name: Check formatting
on:
push:
pull_request:
jobs:
check:
name: Check code formatting and run tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: "20"
- uses: pnpm/action-setup@v4
with:
version: latest
run_install: true
- name: Check formatting
run: pnpm run check-formattingKey changes:
|
Author
|
Correction: the CI failure shows pnpm 11 requires Node.js v22.13, not v18.12. Node 20 alone won't work. The fix needs either:
Option 1 is cleaner since Node 22 is LTS and future-proof. |
Owner
|
See #59 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Node.js version in GitHub Actions from 17 to 20.
Problem
pnpm latest requires Node.js >= 18.12 but the workflow was using Node 17, causing CI failures:
Solution
Update node-version from "17" to "20" in the setup-node action.
Testing
CI should pass after this change.