Conversation
Fix GITHUB_TOKEN limitation: release.yml now calls docker.yml directly via workflow_call so Docker builds are triggered automatically on release.
Removes ~25 any type annotations from backend core, infra, and inter layers, replacing them with proper types (unknown, Record<string, unknown>, BusMessage, JsonWebKey, PromiseLike signatures). Part of the ongoing type safety cleanup.
Remove any types from frontend code: client, plugins, utils, models, and components. Part 4 of the type safety cleanup series. Includes fix aligning parsingErrors type with SerializeError shape.
Replace ~98 any instances across 19 test files with proper types. Final PR (5 of 5) in the remove-any-types series (PRs #272-276). Only 2 justified any remain in test helpers with deno-lint-ignore.
* fix(storage): replace sharp with pure-WASM photon for thumbnails * fix(api): type timeout ids as ReturnType<typeof setTimeout> * ci(tests): pin deno to 2.6.8 to match production runtime * chore: remove code comments
Contributor
Docker image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance release: fixes intermittent image/thumbnail load failures, removes
anytypes across the codebase, and automates Docker image publishing on release.Fixes
sharp/libvips thumbnail pipeline is replaced with the pure-WASM@cf-wasm/photon. On musl/arm64 under Deno,sharpcould abort the whole process with a nativeSIGABRTon the first (uncached) resize of an image — dropping every in-flight connection (surfacing asNS_BINDING_ABORTEDin the browser) until the container restarted. photon runs sandboxed in WebAssembly with no per-arch native binary, so that crash class is eliminated. (fix(storage): replace sharp with pure-WASM photon for thumbnails #294)Improvements
anytypes across the codebase — backend core (serializers, bus, command/query, repos, HTTP/CLI), storage/encryption/config/migrate/tools, the API module, the frontend (client, plugins, models, components), and test files. (chore(types): remove any types from backend core #272, chore(types): remove any types from storage, encryption, and support modules #273, chore(types): remove any types from API module (#274) #274, chore(types): remove any types from frontend code #275, chore(types): remove any types from test files #276)build-basetoolchain (keptmusl-dev, required by the@node-rs/argon2native binding) and added a.dockerignorethat excludesdesktop/,mobile/, build outputs and dev artifacts — production image ~3.6 GB → ~435 MB.CI / Release
2.6.8to match the production runtime (denoland/deno:alpine-2.6.8).