ci(release): trigger docker build via workflow_dispatch - #297
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release workflow, which
startup_failured on the v3.5.1 release (PR #295) — the GitHub Release and image build never ran.Root cause
The
docker:job added torelease.ymlcalleddocker.ymlas a reusable workflow (uses: ./.github/workflows/docker.yml) from apull_request-triggered workflow. v3.5.1 was the first release to exercise it, and that call fails workflow validation at startup (the whole run dies in ~1s with zero jobs and no usable error — GitHub only reports "workflow file issue"). The previous v3.5.0 release predated this job and ran fine.Fix
Replace the reusable-workflow call with an explicit
workflow_dispatchofdocker.yml:release.yml: after creating the Release, dispatchdocker.ymlonmainwith the version viaactions/github-script(createWorkflowDispatch). Addsactions: writepermission (required to dispatch) and drops the now-unusedoutputs/dockerreusable job.docker.yml: add an optionalversioninput toworkflow_dispatchso the dispatched build tags the image correctly (APP_VERSION/ image tag already fall back togithub.ref_name).This avoids the fragile reusable-call-from-
pull_requestpattern. A token-created release/tag does not triggeron: push: tags, so the explicit dispatch is the reliable chain.Note
v3.5.1 was recovered manually (tag pushed → image built & published, Release created). This fix takes effect from the next release.