Rewrite most rules to use the new Rule Builder#6
Draft
Seatori wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Rewrites Minecraft's
Rules.pyto use the newly added Rule Builder program.This of course depends on Rule Builder, so the branch is based on a more recent version of Archipelago main with it included.
It is also based on my previous PR #5 and includes all of the same changes and fixes.
It is definitely incomplete as I have not yet figured out how to get everything working properly (from testing it seems like the special
Over-Overkillrule modifier onOverkilldoes not appear to work at the moment) and goal rules are not yet updated.Bumped the required version of Archipelago up to 0.6.7, under the assumption that it's the most likely first version that Rule Builder will be included in.
How was this tested?
Enough to know that it doesn't appear to be working 100% properly.
Ran unit tests to try and catch as many regressions as possible.
Generated some test games that looked okay but did not give them much scrutiny.
In general, not as much as I'm comfortable with.