Minecraft: Update Item+Location ID System#8
Merged
Conversation
Owner
|
Not sure what happened to your commit history here |
Author
|
This...clearly broke somewhere down the line. It doesn't even have the proper changes anymore. Let me see what I can do to fix this. |
Author
|
Fixed it. This should be the proper changes, @qixils . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This changes the ID system for items and locations. Each Location and ID now starts at 1, and counts up from there. There are no offsets, and the trap offset is removed entirely.
This effects #5, #6 , and #7, though it does not incorporate those changes.
How was this tested?
Ran a few test games with the Minecraft mod ID changes branch. Everything appeared to work properly.