init FileHandler#21
Draft
pskfyi wants to merge 5 commits into
Draft
Conversation
Open
- `FileHandler` type describes the shape of a handler. - `FileExtensionHandler` abstract class defines the shape of objects that care about file extensions and acts as a sane default implementation. - `Evaluable` mixin type provides a consistent interface for file types that can be evaluated. (ex. source code) - `PlainTextFileHandler` sample implementation with `FileExtensionHandler` and `FileHandler` also works as a base class for other handlers or a fallback handler. TODO: need unit tests for `PlainTextFileHandler`
TODO: add tests for `.write()` TODO: add readme entry
This was referenced May 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Release Notes Preview
feat(fs): init fileHandler (5f76976)
FileHandlertype describes the shape of a handler.FileExtensionHandlerabstract class defines the shape of objects that care about file extensions and acts as a sane default implementation.Evaluablemixin type provides a consistent interface for file types that can be evaluated. (ex. source code)PlainTextFileHandlersample implementation withFileExtensionHandlerandFileHandleralso works as a base class for other handlers or a fallback handler.TODO: need unit tests for
PlainTextFileHandlerfeat(json): init; move
types/json->json/types(14c7813)feat(json): add
JsonFileHandler(d8a6740)TODO: add tests for
.write()TODO: add readme entry
feat(ts): add
TypeScriptFileHandler(35401f3)test: namespace fixture data (64220d2)