Skip to content

feat(json): init; move types/json -> json/types#51

Merged
AustinArey merged 1 commit into
mainfrom
init-json
May 8, 2023
Merged

feat(json): init; move types/json -> json/types#51
AustinArey merged 1 commit into
mainfrom
init-json

Conversation

@pskfyi
Copy link
Copy Markdown
Owner

@pskfyi pskfyi commented May 6, 2023

Extracted from #21

@pskfyi pskfyi marked this pull request as ready for review May 6, 2023 04:08
@pskfyi pskfyi requested a review from AustinArey May 6, 2023 04:08
@pskfyi pskfyi marked this pull request as draft May 6, 2023 15:50
@pskfyi pskfyi removed the request for review from AustinArey May 6, 2023 15:50
@pskfyi
Copy link
Copy Markdown
Owner Author

pskfyi commented May 6, 2023

Moving this back to draft. I want to keep the types module for some forthcoming utility types. I'll edit this branch after that stuff lands.

@pskfyi
Copy link
Copy Markdown
Owner Author

pskfyi commented May 8, 2023

Upon further consideration, I'd rather park general utility types in ts/types now that ts exists as a top-level directory. So this PR is good to move forward.

@pskfyi pskfyi marked this pull request as ready for review May 8, 2023 04:38
@pskfyi pskfyi requested a review from AustinArey May 8, 2023 04:38
Copy link
Copy Markdown
Collaborator

@AustinArey AustinArey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AustinArey AustinArey merged commit d5b6167 into main May 8, 2023
@AustinArey AustinArey deleted the init-json branch May 8, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants