Skip to content

test(bcr): cover both prefer_prebuilt_protoc cases in presubmit configs #29545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meteorcloudy wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

test(bcr): cover both prefer_prebuilt_protoc cases in presubmit configs #29545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,18 @@
matrix:
platform: ["debian12", "macos_arm64", "ubuntu2404", "windows"]
bazel: [8.x, 9.x]
prefer_prebuilt_protoc: ["true", "false"]

@zhangskz zhangskz Sep 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding this to .bcr/presubmit.yml would help, but the .bazelci/presubmit.yml won't really work right since the prebuilt protoc artifacts are generated during release. We don't actually have prebuilts for these to point to at HEAD so --prefer_prebuilt_protoc=true isn't expected to work (this is why our .bazelrc sets this to false in the first place)


tasks:
verify_targets:
name: "Verify build targets"
name: "Verify build targets (prefer_prebuilt_protoc=${{ prefer_prebuilt_protoc }})"
working_directory: examples
platform: ${{ platform }}
bazel: ${{ bazel }}
build_flags:
- '--@com_google_protobuf//bazel/toolchains:prefer_prebuilt_protoc=${{ prefer_prebuilt_protoc }}'
test_flags:
- '--@com_google_protobuf//bazel/toolchains:prefer_prebuilt_protoc=${{ prefer_prebuilt_protoc }}'
build_targets:
- '//...'
- '@com_google_protobuf//:protobuf'
Expand All @@ -18,4 +23,6 @@ tasks:
- '@com_google_protobuf//:protoc'
- '@com_google_protobuf//:test_messages_proto2_cc_proto'
- '@com_google_protobuf//:test_messages_proto3_cc_proto'
test_targets:
- '//...'
# LINT.ThenChange(<ROOT_DIR>/.bcr/presubmit.yml)
9 changes: 8 additions & 1 deletion .bcr/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,17 @@ bcr_test_module:
matrix:
platform: ["debian12", "macos_arm64", "ubuntu2404", "windows"]
bazel: [8.x, 9.x]
prefer_prebuilt_protoc: ["true", "false"]

tasks:
verify_targets:
name: "Verify build targets"
name: "Verify build targets (prefer_prebuilt_protoc=${{ prefer_prebuilt_protoc }})"
platform: ${{ platform }}
bazel: ${{ bazel }}
build_flags:
- '--@com_google_protobuf//bazel/toolchains:prefer_prebuilt_protoc=${{ prefer_prebuilt_protoc }}'
test_flags:
- '--@com_google_protobuf//bazel/toolchains:prefer_prebuilt_protoc=${{ prefer_prebuilt_protoc }}'
build_targets:
- '//...'
- '@com_google_protobuf//:protobuf'
Expand All @@ -19,4 +24,6 @@ bcr_test_module:
- '@com_google_protobuf//:protoc'
- '@com_google_protobuf//:test_messages_proto2_cc_proto'
- '@com_google_protobuf//:test_messages_proto3_cc_proto'
test_targets:
- '//...'
# LINT.ThenChange(<ROOT_DIR>/.bazelci/presubmit.yml)
Loading