test(bcr): cover both prefer_prebuilt_protoc cases in presubmit configs - #29545
Open
meteorcloudy wants to merge 1 commit into
Open
test(bcr): cover both prefer_prebuilt_protoc cases in presubmit configs#29545meteorcloudy wants to merge 1 commit into
meteorcloudy wants to merge 1 commit into
Conversation
Add prefer_prebuilt_protoc to matrix in .bcr/presubmit.yml and .bazelci/presubmit.yml to verify examples both with and without the prebuilt protoc toolchain. Also add test_targets: ['//...'] so test targets in examples are executed during presubmit.
Contributor
Author
|
Tested on Bazel CI: https://buildkite.com/bazel/protobuf/builds/5774 |
github-actions
Bot
removed
the
🅰️ safe for tests
zhangskz
reviewed
Sep 1, 2026
| matrix: | ||
| platform: ["debian12", "macos_arm64", "ubuntu2404", "windows"] | ||
| bazel: [8.x, 9.x] | ||
| prefer_prebuilt_protoc: ["true", "false"] |
Member
There was a problem hiding this comment.
I think adding this to .bcr/presubmit.yml would help, but the .bazelci/presubmit.yml won't really work right since the prebuilt protoc artifacts are generated during release. We don't actually have prebuilts for these to point to at HEAD so --prefer_prebuilt_protoc=true isn't expected to work (this is why our .bazelrc sets this to false in the first place)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves
.bcr/presubmit.ymland.bazelci/presubmit.ymlto:prefer_prebuilt_protoc: ["true", "false"]to thematrixdefinition.--@com_google_protobuf//bazel/toolchains:prefer_prebuilt_protoc=${{ prefer_prebuilt_protoc }}in bothbuild_flagsandtest_flags.test_targets: ["//..."]so tests inexamplesare actually executed during presubmit.This ensures both building from source and downloading prebuilt
protoctoolchains are continuously tested across all supported platforms before publishing to BCR, preventing regressions like #29537.