Skip to content

fix(extensions): refresh GNOME-compatible upstream pins - #998

Merged
hivecommons-hive[bot] merged 6 commits into
projectbluefin:mainfrom
hanthor:fix/blur-my-shell-latest-fixes
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 6 commits into
projectbluefin:mainfrom
hanthor:fix/blur-my-shell-latest-fixes

Conversation

@hanthor

@hanthor hanthor commented Oct 28, 2026

Copy link
Copy Markdown
Member

Changes

  • Update Blur My Shell from v76 (f019cd1f) to upstream master v77 (b973ec8f). This includes popup first-open fixes, parent-attached modal blur, and reduced allocations while painting.
  • Advance Bluefin Bling to current upstream main (d357a1e1), including recent Syncthing-toggle fixes.
  • Keep BudsLink on c11b6cf: its latest upstream branch tip removes the extension and metadata, which fails Utah's GNOME source contract.
  • Update desktop-contract guidance for current upstream pins.

Verification

  • python3 scripts/verify-gnome-extensions.py --source: all 18 declared extensions pass GNOME 51 metadata validation.
  • umask 022 && just check: passed, 1233 tests. The explicit umask avoids an environment-dependent test-fixture permissions failure under the workstation's default umask.
  • umask 022 && pre-commit run --all-files: passed.

Refs #992, #993, #997. The reported machine still runs Blur v76; runtime rendering and CPU behavior require a build/deploy before these can be closed.

@github-actions
github-actions Bot requested review from Danathar and alatiera October 28, 2026 18:50
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@hanthor is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Oct 28, 2026
Update Blur my Shell to upstream v77 and Bluefin Bling to current upstream, while retaining the last source-bearing BudsLink commit. Document the GNOME 51 extension audit.

Assisted-by: GPT-6 Luna via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hanthor
hanthor force-pushed the fix/blur-my-shell-latest-fixes branch from 2404c01 to cc55708 Compare October 28, 2026 19:56
@hanthor

hanthor commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

Updated the branch onto current upstream main; PR head is cc55708a909cfe21c3c69ec67ef7544c8e3d3bae. Local just check (1,233 tests), pre-commit run --all-files, and the GNOME 51 source verifier passed. Remote contract check is still pending. A temporary low-priority package-build smoke on the GNOME 51.1 host could not connect over SSH, and no runtime deployment was made. This refresh does not attribute the reported CPU usage to Blur.

@hivecommons-hive hivecommons-hive Bot added the role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) label Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change moves two bundled desktop add-ons (the "Blur my Shell" effect and the Bluefin Bling extras) to their newest upstream versions and refreshes the notes that explain which versions we ship. The version bumps are sound. One small wording problem in the updated notes could mislead the next person reading them.

What I need from you: Fix the wording in the extensions note (suggestion below).


docs-currency

  • low — docs/skills/desktop-contract.md:283-298: the paragraph still frames the list as "both failures below" and closes with "tests/test_gnome_extensions.py covers both pinned sources", but the PR inserts a third bullet (Blur my Shell) that is a plain pin note, not a boot-time failure, and the test file (tests/test_gnome_extensions.py:8,60,72) only covers GSConnect and Dash to Dock. Suggest:
Declaring GNOME 51 in `metadata.json` is necessary, not sufficient: the GSConnect
and Dash to Dock failures below passed the metadata check, built cleanly, and
only showed up in a booted session's journal (`journalctl _UID=1000 | grep -i extension`).

and

`tests/test_gnome_extensions.py` covers the GSConnect and Dash to Dock pins. On a booted VM,

No findings from: correctness, security, intent-alignment, style.

Confidence: 3/5 (needs attention) — 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@hanthor this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

Signed-off-by: James Reilly <jreilly1821@gmail.com>
@hanthor

hanthor commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

Addressed the queued wording review in signed-off fast-forward commit b971f2e on the existing branch: the two journal failures are now explicitly GSConnect and Dash to Dock, Blur my Shell is identified as a separate pin update still needing boot testing, and the test-coverage sentence names only GSConnect and Dash to Dock. No extension pins, code, tests, runtime requirements or publication settings changed. The normal push succeeded without force, preserving concurrent-writer protection; please re-evaluate the existing relay fix entry against the new head rather than replay its old wording request. CI is pending; no boot/runtime proof is claimed.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 29, 2026
@hanthor

hanthor commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

Verification update for wording repair b971f2e: Build Utah run https://github.com/projectbluefin/utah/actions/runs/40801461642 completed successfully, including manifest validation, the full unit suite, parity/package checks and image builds. This is CI/image-build evidence, not a booted-session proof for Blur my Shell. The queued wording request is addressed; please re-review this head while retaining the existing real-session acceptance requirements.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 060-reviewed → 050-review-pending: check-pending

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin bumps look correct to me. One thing I checked because the diff does not touch those submodules: the desktop-contract.md rewrite now says GSConnect is at v74 and Dash to Dock at v110. Verified against main's gitlinks — gsconnect@andyholmes.github.io → 61cc76b is upstream tag v74, and dash-to-dock@micxgx.gmail.com → 2dfae34 is extensions.gnome.org-v110^{} — so the doc correction is accurate, not drift.

The Blur my Shell f019cd1 → b973ec8 move itself can only be validated on a booted image, which the body already says; nothing here changes the build-time contract.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 050-review-pending: check-pending

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the tree at f531e2b. Looks correct to me.

  • Both submodule moves are plain pin bumps: blur-my-shell@aunetx f019cd1f → b973ec8f (on master, per .gitmodules:12), tmp/bluefin-bling f9e68e20 → d357a1e1. I checked d357a1e1 is on projectbluefin/bluefin-bling main (one commit behind tip), so this is not a stray branch pin.
  • tests/test_gnome_extensions.py:56-78 only inspects the GSConnect and Dash to Dock trees; nothing in the test suite pins a Blur my Shell commit, which matches the green contract run.
  • GSConnect (61cc76b) and Dash to Dock (2dfae34) are untouched here; their last move was #835, so the desktop-contract.md text had been stale since then and this PR is the first to catch it up.

One open question, not a defect: docs/skills/desktop-contract.md:290,293 now state GSConnect "v74" and Dash to Dock "v110". I could not confirm those version strings from inside this repo (they come from each submodule's metadata.json at the pinned commit). Worth a glance from whoever merges, since the whole point of that paragraph is that the numbers are right.

Issue linking is non-closing on purpose (Refs #992, #993, #997 — boot/runtime proof still needed), which reads right to me.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against main and compared the submodule ranges. Looks correct to me, with one open question on the docs.

Verified

  • system_files/.../tmp/bluefin-bling f9e68e20 → d357a1e1: 11 commits, all on projectbluefin/bluefin-bling main (two syncthing-toggle fixes, #93 and #117, plus renovate bumps). Fast-forward, nothing off-branch.
  • blur-my-shell@aunetx f019cd1f → b973ec8f is on the master branch .gitmodules already tracks; the contract check is green on this head. I did not boot-test it, and the PR body says the same.
  • tests/test_gnome_extensions.py only asserts on the GSConnect and Dash to Dock trees (lines 54–72), so the Blur pin is covered by verify-gnome-extensions.py --source metadata validation only — consistent with what the body claims.

Open question (docs, low)
docs/skills/desktop-contract.md:287-292 now says GSConnect "tracks v74" and Dash to Dock "tracks v110", replacing v73 and v109. This PR does not move either submodule, so either those pins already advanced on main and the old text was stale (fine — worth saying in the body), or the new numbers are ahead of what is actually pinned. Worth a one-line confirmation from @hanthor before merge so the contract doc matches the tree.

Refs #992/#993/#997 with the boot-test remainder stated inline reads right to me.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 060-reviewed → 050-review-pending: check-pending

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit a1bf852 into projectbluefin:main Oct 29, 2026
43 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#99813b7e24` sha256:3b426a5d9fbdc3812e5a6dda2ab5f18aa7e86688bb8f7468b28a005846828ebd — download from the dashboard or `hivectl review evidence #998`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @hanthor was auto-promoted after 5 clean merged PRs in this hive's repositories.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant