Repository navigation
fix(extensions): refresh GNOME-compatible upstream pins - #998
hivecommons-hive[bot] merged 6 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hanthor is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Update Blur my Shell to upstream v77 and Bluefin Bling to current upstream, while retaining the last source-bearing BudsLink commit. Document the GNOME 51 extension audit. Assisted-by: GPT-6 Luna via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2404c01 to
cc55708
Compare
|
Updated the branch onto current upstream main; PR head is |
There was a problem hiding this comment.
Summary: This change moves two bundled desktop add-ons (the "Blur my Shell" effect and the Bluefin Bling extras) to their newest upstream versions and refreshes the notes that explain which versions we ship. The version bumps are sound. One small wording problem in the updated notes could mislead the next person reading them.
What I need from you: Fix the wording in the extensions note (suggestion below).
docs-currency
- low —
docs/skills/desktop-contract.md:283-298: the paragraph still frames the list as "both failures below" and closes with "tests/test_gnome_extensions.pycovers both pinned sources", but the PR inserts a third bullet (Blur my Shell) that is a plain pin note, not a boot-time failure, and the test file (tests/test_gnome_extensions.py:8,60,72) only covers GSConnect and Dash to Dock. Suggest:
Declaring GNOME 51 in `metadata.json` is necessary, not sufficient: the GSConnect
and Dash to Dock failures below passed the metadata check, built cleanly, and
only showed up in a booted session's journal (`journalctl _UID=1000 | grep -i extension`).
and
`tests/test_gnome_extensions.py` covers the GSConnect and Dash to Dock pins. On a booted VM,
No findings from: correctness, security, intent-alignment, style.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@hanthor this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
Addressed the queued wording review in signed-off fast-forward commit b971f2e on the existing branch: the two journal failures are now explicitly GSConnect and Dash to Dock, Blur my Shell is identified as a separate pin update still needing boot testing, and the test-coverage sentence names only GSConnect and Dash to Dock. No extension pins, code, tests, runtime requirements or publication settings changed. The normal push succeeded without force, preserving concurrent-writer protection; please re-evaluate the existing relay fix entry against the new head rather than replay its old wording request. CI is pending; no boot/runtime proof is claimed. |
|
Verification update for wording repair b971f2e: Build Utah run https://github.com/projectbluefin/utah/actions/runs/40801461642 completed successfully, including manifest validation, the full unit suite, parity/package checks and image builds. This is CI/image-build evidence, not a booted-session proof for Blur my Shell. The queued wording request is addressed; please re-review this head while retaining the existing real-session acceptance requirements. |
|
stage 060-reviewed → 050-review-pending: check-pending |
There was a problem hiding this comment.
Pin bumps look correct to me. One thing I checked because the diff does not touch those submodules: the desktop-contract.md rewrite now says GSConnect is at v74 and Dash to Dock at v110. Verified against main's gitlinks — gsconnect@andyholmes.github.io → 61cc76b is upstream tag v74, and dash-to-dock@micxgx.gmail.com → 2dfae34 is extensions.gnome.org-v110^{} — so the doc correction is accurate, not drift.
The Blur my Shell f019cd1 → b973ec8 move itself can only be validated on a booted image, which the body already says; nothing here changes the build-time contract.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission → 050-review-pending: check-pending |
There was a problem hiding this comment.
Read the diff against the tree at f531e2b. Looks correct to me.
- Both submodule moves are plain pin bumps:
blur-my-shell@aunetxf019cd1f→b973ec8f(onmaster, per.gitmodules:12),tmp/bluefin-blingf9e68e20→d357a1e1. I checkedd357a1e1is onprojectbluefin/bluefin-blingmain(one commit behind tip), so this is not a stray branch pin. tests/test_gnome_extensions.py:56-78only inspects the GSConnect and Dash to Dock trees; nothing in the test suite pins a Blur my Shell commit, which matches the greencontractrun.- GSConnect (
61cc76b) and Dash to Dock (2dfae34) are untouched here; their last move was #835, so thedesktop-contract.mdtext had been stale since then and this PR is the first to catch it up.
One open question, not a defect: docs/skills/desktop-contract.md:290,293 now state GSConnect "v74" and Dash to Dock "v110". I could not confirm those version strings from inside this repo (they come from each submodule's metadata.json at the pinned commit). Worth a glance from whoever merges, since the whole point of that paragraph is that the numbers are right.
Issue linking is non-closing on purpose (Refs #992, #993, #997 — boot/runtime proof still needed), which reads right to me.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the diff against main and compared the submodule ranges. Looks correct to me, with one open question on the docs.
Verified
system_files/.../tmp/bluefin-blingf9e68e20 → d357a1e1: 11 commits, all onprojectbluefin/bluefin-blingmain(two syncthing-toggle fixes, #93 and #117, plus renovate bumps). Fast-forward, nothing off-branch.blur-my-shell@aunetxf019cd1f → b973ec8fis on themasterbranch.gitmodulesalready tracks; thecontractcheck is green on this head. I did not boot-test it, and the PR body says the same.tests/test_gnome_extensions.pyonly asserts on the GSConnect and Dash to Dock trees (lines 54–72), so the Blur pin is covered byverify-gnome-extensions.py --sourcemetadata validation only — consistent with what the body claims.
Open question (docs, low)
docs/skills/desktop-contract.md:287-292 now says GSConnect "tracks v74" and Dash to Dock "tracks v110", replacing v73 and v109. This PR does not move either submodule, so either those pins already advanced on main and the old text was stale (fine — worth saying in the body), or the new numbers are ahead of what is actually pinned. Worth a one-line confirmation from @hanthor before merge so the contract doc matches the tree.
Refs #992/#993/#997 with the boot-test remainder stated inline reads right to me.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 060-reviewed → 050-review-pending: check-pending |
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @hanthor was auto-promoted after 5 clean merged PRs in this hive's repositories. |
Changes
f019cd1f) to upstream master v77 (b973ec8f). This includes popup first-open fixes, parent-attached modal blur, and reduced allocations while painting.d357a1e1), including recent Syncthing-toggle fixes.c11b6cf: its latest upstream branch tip removes the extension and metadata, which fails Utah's GNOME source contract.Verification
python3 scripts/verify-gnome-extensions.py --source: all 18 declared extensions pass GNOME 51 metadata validation.umask 022 && just check: passed, 1233 tests. The explicit umask avoids an environment-dependent test-fixture permissions failure under the workstation's default umask.umask 022 && pre-commit run --all-files: passed.Refs #992, #993, #997. The reported machine still runs Blur v76; runtime rendering and CPU behavior require a build/deploy before these can be closed.