Repository navigation
fix(ci): isolate invalid GNOME extension heads - #1001
hivecommons-hive[bot] merged 2 commits into
Conversation
Keep the known-good submodule pin when an upstream head drops required metadata, report the skipped candidate, and continue proposing valid independent updates. Assisted-by: GPT-6 Luna via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar, hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1e805a9
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @hanthor, head
Hive did not add the |
|
@hanthor is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
There was a problem hiding this comment.
Summary: This change stops the weekly GNOME extension updater from giving up entirely when one upstream project deletes its extension; that one is now held at its last good version and reported, while the others still get proposed. I read the new script, the workflow, the helper it calls, and the test, and found no correctness or security problems. A few small clarity and convention points below, each with a ready-to-apply fix.
style
.github/scripts/prepare-gnome-extension-bumps.py:1— this creates a new.github/scripts/directory holding a single file. Every other Python tool in the repo (including the helper this script shells out to,scripts/gnome-extension-shell-versions.py:1, andscripts/check-script-syntax.py) lives underscripts/. Suggest moving it toscripts/prepare-gnome-extension-bumps.pyand droppingparents[2]→parents[1]at line 13, plus the two path references in.github/workflows/update-gnome-extensions.yml:31andtests/test_gnome_extension_bumps.py:11. (low).github/scripts/prepare-gnome-extension-bumps.py:119— on a skipped row the "GNOME shell-version" column shows the pinned commit's value (51) directly beside the rejected upstream SHA, which reads as if the rejected head declares51. Label it so the PR table is unambiguous for the maintainer deciding whether to merge:and in- Bump(path, pinned, upstream, pinned_versions, "skipped (invalid upstream metadata)") + Bump(path, pinned, upstream, f"{pinned_versions} (pinned)", "skipped (invalid upstream metadata)")
tests/test_gnome_extension_bumps.py:126change| 51 | skipped→| 51 (pinned) | skipped. (low).github/workflows/update-gnome-extensions.yml:33-34— the comment "Always run create-pull-request, including on an empty diff…" used to justify the: > "$RUNNER_TEMP/…"line that was deleted; it now dangles after the python call with nothing it explains. Move it above thePropose GNOME extension updatestep or drop it. (low)
docs-currency
docs/skills/ci-workflows.md:90-98— the rewrite removes "Each.gitmodulesbranch must name a real remote branch;git submodule update --remotecannot follow a tag written as a branch." That constraint is unchanged: the new script still fetches+refs/heads/{branch}(prepare-gnome-extension-bumps.py:86-90) and falls back tosubmodule update --remote(line 93). Suggest keeping that sentence. (low)
correctness
tests/test_gnome_extension_bumps.py:48— because--rootpoints at a temp dir outsideEXTENSIONS_BASE, the helper'srelative_toatscripts/gnome-extension-shell-versions.py:31fails and every lookup takes theFALLBACK_LOCATIONSpath, so theSOURCE_EXTENSIONSbranch used in production is never exercised, and neither is the fail-closed branch atprepare-gnome-extension-bumps.py:112-115(pinned metadata also invalid → exit 1). Not a blocker — the production path is unchanged from the old shell step — but a second test that breaksmetadata.jsonin both pinned and upstream commits and assertsreturncode == 1would cover the fail-closed claim in the PR body. (info)
No findings from: security, intent-alignment.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge: the PR edits CI workflow / action files: awaiting owner approval — a hive owner / trusted merger's GitHub Approve review on the current head (or a dashboard Head: verdict approved @1e805a9, 19/19 checks green, soak 30m0s elapsed. What to do: a trusted merger approves this head ( Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
hanthor
left a comment
There was a problem hiding this comment.
Reviewed exact head 1e805a9. Invalid upstream metadata retains the known-good gitlink while valid extension bumps continue; fetch/ref failures and invalid pinned metadata still fail closed. Dispatch remains contract-only; current CI is green. I am not submitting self-approval or treating the workflow fence and no-dco marker as implicitly waived. Preserve the current ownership/sign-off and explicit workflow-authorization requirements; any new head needs fresh CI/review.
Danathar
left a comment
There was a problem hiding this comment.
Reviewed: isolating the invalid GNOME extension heads looks right; checks green.
|
@Danathar approved head |
|
Needs a decision, not a merge: GitHub refused to bring the branch up to date: the base changed Head: verdict approved @1e805a9, approved by @Danathar, 19/19 checks green, soak 30m0s elapsed. What to do: a trusted merger approves this head ( Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
304acd9
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @hanthor, head
Hive did not add the |
|
@Danathar approved head |
… stop retrying it (#15382) GitHub refuses update-branch when the base changed .github/workflows/ and the head lives in a fork the App is not installed on. The classifier checked for the workflow refusal before looking at the fork flag, so the PR parked at 085 as workflow-permission, asking the owner to grant Workflows: write the App already held (projectbluefin/utah#1001), and the sweep sent the same refused update-branch every tick. - A workflow-file refusal (403, or 422 with the same text) on a fork head is fork-workflow-update: 085, with a cause naming who can update the branch and no permission ask. Same-repo heads keep workflow-permission, now worded "if the installation lacks it". - updateBranchAndSkip remembers a workflow-file refusal per head and base and does not call update-branch again until one of them moves. - The hold guard shares the classifier and gains the fork stop reason and note. Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Read .github/scripts/prepare-gnome-extension-bumps.py against the bash step it replaces and against the test. Looks correct to me:
- Fail-closed paths are preserved:
run_gitraises on any fetch/checkout/rev-parse failure andmain()turns that into exit 1 (prepare-gnome-extension-bumps.py:26-32, 160-166), so a broken ref still stops the step beforecreate-pull-requestruns, same as the oldset -eloop. - The skip path re-checks out the pinned gitlink and re-validates its metadata (
:109-115); an invalid pin still raises, so the only thing that changed is that an invalid candidate head no longer takes the batch down. - A skipped submodule ends at the HEAD gitlink, so
add-pathsproduces no diff for it and the summary still shows the rejected upstream SHA. tests/test_gnome_extension_bumps.pydrives one valid and one source-less upstream through the real script and asserts both the working trees and the report rows.
Minor note, not a defect: this and #998 both edit docs/skills/desktop-contract.md in nearby (non-overlapping) hunks; whichever lands second will need a trivial rebase.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @hanthor was auto-promoted after 5 clean merged PRs in this hive's repositories. |
Why
The upstream BudsLink branch removed its extension source and metadata. The updater currently aborts the whole batch when one changed head has invalid metadata, blocking unrelated valid extension updates.
Change
Verification
python3 tests/test_gnome_extension_bumps.py— passed.umask 022 && just check— passed (1,234 tests).pre-commit run --all-files— passed.No automatic merge is added; the workflow still dispatches contract-only CI.