Repository navigation
Conversation
Probe the contracted H.264 and AV1 GStreamer elements during image verification with a fresh registry. Correct stale media publication guidance. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Run: projectbluefin#12 Hive-Plan: multimedia-capability-verification Hive-Spec: issue-12#runtime-verification Signed-off-by: arteeh <arteeh@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Summary: This change makes the image build actually try to load the two installed video decoders (H.264 and AV1) instead of only checking that their packages exist, and it refreshes the contributor notes to say those packages have arrived. The code and tests look right. One problem: the pull request is marked as fully closing the long-running "ship Bluefin's media stack" issue, while its own text and the docs it edits say that issue must stay open for the remaining work. Merging as-is would auto-close that issue prematurely.
What I need from you: Change Closes #12 to Refs #12 in the PR body (or confirm #12 should close now).
intent-alignment
- medium — closing keyword contradicts the PR's own scope. The body says "Refs #12 — partial: the complete factory multimedia closure, full FFmpeg, sample playback, and hardware decoding proof remain open under #12 and #383", and the doc this PR edits says "Keep #12 and #383 open for the remaining factory closure, full FFmpeg and runtime playback/hardware proof" (docs/skills/package-contract.md:127-129). Yet the body also ends with
Closes #12, which GitHub will honour on merge againstmain. #12's acceptance list still has "The multimedia contract is included in Utah's package transaction" (full FFmpeg and its codec tail not yet consumed) and only the software-decoder half of "representative codec capabilities" lands here (scripts/verify-rpm-contract.py:983-986 probesavdec_h264/dav1ddeconly, by design). Fix in the PR body:-Closes #12 +Refs #12
No findings from: correctness, security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@arteeh this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Use Refs for partial media work in PR descriptions and commits. PR projectbluefin#919 now references issue projectbluefin#12 without closing its remaining acceptance criteria. Assisted-by: GPT-6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: arteeh <arteeh@users.noreply.github.com>
There was a problem hiding this comment.
Summary: This change makes the image build actually try to load the two video decoders (H.264 and AV1) it installs, instead of only checking that their packages are present. I read the code and ran the new tests; the logic is sound and safe. Two small notes below: the real decoder probe has only been exercised by mocked tests so far, and the verifier's own top-of-file description does not yet mention the new check.
correctness
- (advisory, in-scope) The new tests (
tests/test_verify_rpm_contract.py:2958-3002) mocksubprocess.run, so/usr/bin/gst-inspect-1.0 avdec_h264/dav1ddechas not yet been run against a real image; the PR body says no Podman was available. The two on-image calls (Containerfile:274,Containerfile:389) in the pendingbuild_main/build_kerneljobs are the first real exercise. Gate on those builds going green before merge. Element/package pairing (scripts/verify-rpm-contract.py:983-986) and the--checkearly return (:1350) that keeps the probe off-image both read correctly.
docs-currency
- (low, in-scope) The module docstring (
scripts/verify-rpm-contract.py:2-9) enumerates what the on-image run attests and now omits the decoder probe, while the success line (:1465-1467) anddocs/skills/package-contract.md:114-118were updated. Suggested:(replacesresolve from an unapproved Fedora repository; the contracted GStreamer software decoders (`avdec_h264`, `dav1ddec`) load on-image; the composed image exposes only the runtime repositories the manifest allows; and the resolved package-origin/NEVRA set is retained as a report with build provenance.scripts/verify-rpm-contract.py:6-9.)
No findings from: security, intent-alignment, style.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@arteeh this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
@arteeh the hive has adopted this PR ( |
|
The hive adopted this PR ( Blocker: lane reason Moving to |
…eason (#15043) The adoption escalation marked the head noted before posting its note, so when GitHub answered the adoption-stalled note with a 500 the PR sat at stage/085-needs-decision with no comment on that head ever (projectbluefin/utah-packages#650 and #652, 2026-10-26). The same mark-before-post pattern was in the three workflow-path refusal paths and in escalateUnadoptableFork. - stagelabels: MarkAdoptionEscalated records the escalation only; the new MarkAdoptionEscalationNoted records (head, reason) after the post succeeds. AdoptionEscalationNoted(head, reason) checks both, so a new blocker on the same head gets its own note (mirrors EntryCommentExplains, #13139). A record from before reasons were kept (noted head, no reasons) reads as noted for every reason on that head, so the upgrade reposts nothing. - automerge: all five call sites post through postAdoptionEscalationNote. The held-escalation branch of escapeStalledAdoption retries an unposted workflow-path refusal note, and hands an unposted or changed stall reason to the stall path instead of holding silently. - Hold an active escalation against a weak opinion: an errored lane on an approved head reads 080 at role rank, which the adoption pin does not claim, so the pass dropped the escalation for a sweep and projectbluefin/utah#919 flipped 085 -> 080 -> 085 on one head (10-26, 10-28). stageengine.HoldsEscalation is shared by the live pass and passDecision so enforce mode derives the same stage. Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
hanthor
left a comment
There was a problem hiding this comment.
Blocking
- All four image builds fail on the new check:
Media decoder 'avdec_h264' (gstreamer1-plugin-libav) failed to load(run 40600999027). The check is right; the image really can't load H.264, probably because the libav plugin is built against ffmpeg-free. Either ship anavdec_h264that loads, or drop the H.264 probe or make it non-fatal, and then change the docs, which currently say H.264 is covered. - The branch conflicts with the base branch and needs a rebase.
Nits
- Remove
GST_PLUGIN_PATH*from the environment withenv.poprather than setting it to an empty string. - The
assertFalse(registry.exists())test doesn't show that a broken load is caught.
|
/hive decision hive's fixer: rebase onto the base branch, make CI green without widening scope, address the changes @hanthor requested on GitHub on #919; then it merges Rationale: the hive adopted #919 in place and owns its branch, so the reviewer's finding is the hive's own fixer's to address — not the contributor's and not a person's (hivecommons/hive#15722). Hive decided: Told the author agent what to change. Decided by the hive at @Danathar's request as the owner's delegate under the owner-delegate policy (rule |
|
Direction recorded by @Danathar for head
Recorded from the hive dashboard. |
Signed-off-by: Danathar <berths-purger-0g@icloud.com> # Conflicts: # docs/skills/package-contract.md
|
Adopting this into a hive branch: the author's agent has been offline since 10-26 and the hive cannot finish it on the fork. I merged main into the branch (one docs conflict, kept main's text plus this PR's probe paragraph) and reviewed the diff for a trusted run: it only runs gst-inspect-1.0 on two decoders inside the image build. On the hive's copy, please address @hanthor's review: make the avdec_h264 probe non-fatal or drop it, since it fails on the current image. |
|
The hive adopted this PR ( Blocker: this PR comes from a fork ( Moving to |
There was a problem hiding this comment.
Summary: This change teaches Utah's image build to prove that two video decoders (H.264 and AV1) actually load, not merely that their packages are installed. Re-reviewed after the branch was brought up to date with main. The merge itself is clean, but two things now block it: the H.264 probe fails on every real image build because the installed decoder plugin genuinely lacks that element, and the merged contributor guide is five lines over its hard size limit, which fails the test suite.
What I need from you: @arteeh — swap the H.264 probe to the decoder the pinned factory actually ships (or drop it until full FFmpeg lands), and trim the guide back under 500 lines.
Delta reviewed: f0b5e2f → b740d86 (merge of up/main; the PR's own files at this head are unchanged apart from the merge resolution in docs/skills/package-contract.md). Prior notes — GST_PLUGIN_SYSTEM_PATH not cleared (scripts/verify-rpm-contract.py:996) and the module docstring omitting the probe (scripts/verify-rpm-contract.py:4) — are still present, unchanged, and remain advisory.
correctness
build_main fails at the new probe on every run of this branch (runs 40227347356, 40600999027; the head run 42112470988 never reached it because contract failed first):
ERROR: 1 supply-chain / repository contract violation(s):
- Media decoder 'avdec_h264' (gstreamer1-plugin-libav) failed to load: No such element or plugin 'avdec_h264'
MEDIA_DECODERS maps gstreamer1-plugin-libav → avdec_h264 (scripts/verify-rpm-contract.py:983-985). The pinned factory ships libav built against ffmpeg-free, which strips the H.264 decoder, so that element cannot exist until the "full FFmpeg" delivery the guide itself lists as still open (docs/skills/package-contract.md:132-134). main already records this exact failure (docs/skills/package-contract.md:124). As written the PR cannot produce an image. The pin's working H.264 path is openh264dec from gstreamer1-plugin-openh264, which packages/utah.toml:194-195 already requests and whose release identity is asserted:
MEDIA_DECODERS = {
- "gstreamer1-plugin-libav": "avdec_h264",
+ "gstreamer1-plugin-openh264": "openh264dec",
"gstreamer1-plugin-dav1d": "dav1ddec",
}and update tests/test_verify_rpm_contract.py:2980,2984,2988 to the new element name. Move avdec_h264 back in with the full-FFmpeg switch (#383). Also: when gst-inspect-1.0 <element> fails, the message hides why the plugin did not load (scripts/verify-rpm-contract.py:1009-1012); re-running gst-inspect-1.0 <plugin> on failure and appending its stderr would have shown the cause here.
docs-currency
The merge brought main's 499-line docs/skills/package-contract.md plus this PR's 6-line paragraph (docs/skills/package-contract.md:126-131) to 505 lines; check-skill-frontmatter hard-fails at 500 (contract job 127543307436: error: docs/skills/package-contract.md is 505 lines (hard max 500)). Compress the paragraph:
The on-image RPM verifier runs `gst-inspect-1.0` on each contracted decoder element with a
fresh temporary registry, so cached metadata cannot hide a broken load; missing tools or
elements, load failures and timeouts fail the build. Off-image `--check` skips these probes.
(Line 124's "probe in PR #919 failed" sentence should also be reworded once the probe is fixed.)
No findings from: security, intent-alignment, style.
Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@hanthor, a question for you before anything is closed here. Where this stands:
What the check found is a real bug, though. On the Utah image, the H.264 software decoder doesn't load even though its package is installed. From this PR's image build (run 40600999027): The AV1 decoder ( Proposal:
Closing this PR also frees #12, which the hive currently treats as covered by this PR. Does that work for you? |
…d branch (#16820) projectbluefin/utah#919 (fork-rehome-refused on its head) and projectbluefin/testsuite#1037 (a fork changing .github/workflows/e2e.yml; the fixer's pushes were refused three times) were decided "hive's fixer: … then it merges" and read "the hive is fixing it" for days. - delegatedecision: Input.AdoptedPushRefused; a connected author gets the fix list back (return-to-contributor), otherwise recommend-only adopted-push-refused keeps the park with the person who asked. - dashboard: adoptedPushFacts (fork without maintainer edits, fork with a workflow-file diff, fork-rehome-refused or workflow-path escalation on the head, capability blocker); gathered for the delegate; ownership keeps an answered review on such an adopted head your turn (adopted_push_refused). - glossary (Go + SPA mirror), advisor wording, docs, changelog. Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…16846) settleInPlaceAdoption yielded on any new head without App push evidence, so a maintainer rebasing or fixing an offline contributor's adopted PR handed it back to the absent author, who was then nudged, re-adopted and stalled again (projectbluefin/utah#919, Danathar's 2026-10-27 push; projectbluefin/utah-packages#804, #812, #822, hanthor's 2026-10-31 pushes). Before yielding, classify the GitHub-linked pusher (committer, or the author when the committer is web-flow or unlinked): the PR author, an unlinked identity, or a read-only third party still yields; an App bot or a person with write/maintain/admin (authorRepoPermission) is a takeover and the adoption follows the new head with no yield note and no nudge. An unreadable permission keeps the adoption for the sweep. Signed-off-by: James Reilly <jreilly1821@gmail.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
@Danathar agreed. A non-fatal probe would hide a real failure, and the author's agent has been offline since 10-26. I'm tracking the decoder in #1116. That issue asks for this load probe to come back as a blocking check once the supported H.264 decoder loads. Thank you @arteeh: this check found the bug. Closing. |
Summary: Utah now checks that its installed video software can load the decoders for H.264 and AV1, two common video formats. This catches broken video support that a package-presence check would miss. The contributor guidance also reflects the media packages that have already arrived.
Refs #12 — partial: the complete factory multimedia closure, full FFmpeg, sample playback, and hardware decoding proof remain open under #12 and #383.
Changes:
gst-inspect-1.0 avdec_h264andgst-inspect-1.0 dav1ddecin the on-image RPM verifier when their provider packages are contracted.--checkstays static.Validation:
python3 -m pytest tests/test_verify_rpm_contract.py -q: 204 passed.pre-commit run --all-files: ran; existing end-of-file issues in two unrelated files required automatic fixes before a clean rerun. Those unrelated edits were restored and are excluded from this PR.just check: attempted after initializing the pinned extension submodules. It reached the full unittest suite, reported three failures, then stalled in a screenshot test; the run was terminated. The focused RPM verifier suite passes independently.— hive: backend=codex model=gpt-6.1-sol effort=medium
Refs #12
🐝 Hive Agent:
contributor| SHA:7360b37