Repository navigation
fix(media): probe supported H.264 decoder, document avdec_h264 gap - #1121
Conversation
… gap Refs #1116 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 Evidence bundle `#1121fba9b8c` sha256:5fddd57764b1f20b8f59a094942e6847f1ffa3987b9bc04b0ad66c5e27df1285 — download from the dashboard or `hivectl review evidence #1121`. |
The decoder probe raised FileNotFoundError on hosts without gst-inspect-1.0, crashing the contract test instead of reporting a contract error. Record it as a contract failure. Reflow the H.264 note so package-contract.md stays within the 500-line skill-page limit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Summary: This change makes the image build fail if the H.264 video decoder Utah actually ships ever stops loading, and documents why the libav decoder cannot work on today's base. The check itself is right and every flavor built green on this revision. Two gaps: the new check has no test even though the test file exists precisely to cover such checks, and the contract's main guide does not mention the new section.
What I need from you: add the test and the two doc lines.
Reviewed head 2312d40.
correctness
scripts/verify-desktop-contract.py:252-264— the new[media].decodersprobe is the only verify-mode assertion with no executed test.tests/test_desktop_contract_verify.py:1-16exists because this branch runs once in the Containerfile and only on the passing path, so a silently broken assertion ships a green image. Add threeVerifyModeTestscases patchingdesktop.subprocess.run(astests/test_desktop_contract.py:212,261already do): returncode 0 passes, returncode ≠0 yieldsmedia decoder ... failed to load,FileNotFoundErroryieldscannot be probed.
docs-currency
docs/skills/desktop-contract.md:72-76enumerates the contract sections anddocs/skills/desktop-contract/references/verifiers.md:8-9describes what the in-image verifier checks; neither mentions the new[media]section added atcontracts/bluefin-desktop.toml:304-305. Add a[media]bullet (openh264dec, #1116 rationale) and one line in verifiers.md.
style (advisory)
- Other runtime checks use helpers (
unit_enabledetc., lines 59-115); adecoder_loads(element)helper would fit the file and make the test above trivial. The pass summary after line 268 also omits a decoder count.
No findings from: security, intent-alignment.
Confidence: 3/5 (needs attention) — 1 medium finding; 2 perspectives requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Extract the gst-inspect-1.0 probe into decoder_load_error() and count declared decoders in the pass summary. Add MediaDecoderTests exercising load success, load failure and a missing gst-inspect-1.0 (fail closed). Document the [media] section in the desktop-contract skill page and the in-image decoder check in the verifiers reference. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Summary: The image's built-in H.264 video decoder from libav cannot load, because the underlying FFmpeg build leaves H.264 out. This change records openh264 as the supported H.264 decoder and makes the image build fail if that decoder ever stops loading, so broken video playback is caught before release.
gstreamer1-plugin-libavis built againstffmpeg-free(no H.264 decoder), soavdec_h264never registers;openh264decis the supported path.[media].decodersto the desktop contract;utah-verify-desktop-contractrunsgst-inspect-1.0for each and fails on error (restores the fix: check that installed video decoders can load #919 load probe as a blocking check).docs/skills/package-contract.md.Closes #1116
— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 requested_by=@hanthor