Skip to content

fix(media): probe supported H.264 decoder, document avdec_h264 gap - #1121

Merged
hivecommons-hive[bot] merged 5 commits into
mainfrom
scanner/fix-1116
Nov 6, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
mainfrom
scanner/fix-1116

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary: The image's built-in H.264 video decoder from libav cannot load, because the underlying FFmpeg build leaves H.264 out. This change records openh264 as the supported H.264 decoder and makes the image build fail if that decoder ever stops loading, so broken video playback is caught before release.


  • Factory gstreamer1-plugin-libav is built against ffmpeg-free (no H.264 decoder), so avdec_h264 never registers; openh264dec is the supported path.
  • Adds [media].decoders to the desktop contract; utah-verify-desktop-contract runs gst-inspect-1.0 for each and fails on error (restores the fix: check that installed video decoders can load #919 load probe as a blocking check).
  • Docs updated in docs/skills/package-contract.md.

Closes #1116

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 requested_by=@hanthor

… gap

Refs #1116

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

hivecommons-hive Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: 8359e7353d333c585602c4112a5dafbfdcf9908e

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

Evidence bundle `#1121fba9b8c` sha256:5fddd57764b1f20b8f59a094942e6847f1ffa3987b9bc04b0ad66c5e27df1285 — download from the dashboard or `hivectl review evidence #1121`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026
The decoder probe raised FileNotFoundError on hosts without
gst-inspect-1.0, crashing the contract test instead of reporting a
contract error. Record it as a contract failure. Reflow the H.264 note
so package-contract.md stays within the 500-line skill-page limit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 6, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change makes the image build fail if the H.264 video decoder Utah actually ships ever stops loading, and documents why the libav decoder cannot work on today's base. The check itself is right and every flavor built green on this revision. Two gaps: the new check has no test even though the test file exists precisely to cover such checks, and the contract's main guide does not mention the new section.

What I need from you: add the test and the two doc lines.


Reviewed head 2312d40.

correctness

  • scripts/verify-desktop-contract.py:252-264 — the new [media].decoders probe is the only verify-mode assertion with no executed test. tests/test_desktop_contract_verify.py:1-16 exists because this branch runs once in the Containerfile and only on the passing path, so a silently broken assertion ships a green image. Add three VerifyModeTests cases patching desktop.subprocess.run (as tests/test_desktop_contract.py:212,261 already do): returncode 0 passes, returncode ≠0 yields media decoder ... failed to load, FileNotFoundError yields cannot be probed.

docs-currency

  • docs/skills/desktop-contract.md:72-76 enumerates the contract sections and docs/skills/desktop-contract/references/verifiers.md:8-9 describes what the in-image verifier checks; neither mentions the new [media] section added at contracts/bluefin-desktop.toml:304-305. Add a [media] bullet (openh264dec, #1116 rationale) and one line in verifiers.md.

style (advisory)

  • Other runtime checks use helpers (unit_enabled etc., lines 59-115); a decoder_loads(element) helper would fit the file and make the test above trivial. The pass summary after line 268 also omits a decoder count.

No findings from: security, intent-alignment.

Confidence: 3/5 (needs attention) — 1 medium finding; 2 perspectives requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026
Extract the gst-inspect-1.0 probe into decoder_load_error() and count
declared decoders in the pass summary. Add MediaDecoderTests exercising
load success, load failure and a missing gst-inspect-1.0 (fail closed).
Document the [media] section in the desktop-contract skill page and the
in-image decoder check in the verifiers reference.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 6, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit fa9df6c into main Nov 6, 2026
25 checks passed
@hivecommons-hive
hivecommons-hive Bot deleted the scanner/fix-1116 branch November 6, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

H.264 software decoder (avdec_h264) does not load on Utah

0 participants