Repository navigation
ci: automate LUKS ISO validation and screenshot evidence - #84
Merged
Merged
Conversation
Run the existing encrypted installation harness for every exact published testing digest before promotion; retain diagnostics, verify fastfetch screenshots, and propose provenance-backed documentation updates. Dispatch testing builds explicitly after branch sync. Assisted-by: GPT-6 via Codex Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 18, 2026
castrojo
pushed a commit
that referenced
this pull request
Sep 18, 2026
* fix: restore the bluefin.toml parity contract packages/bluefin.toml is meant to be a byte-for-byte copy of upstream Bluefin's build_files/packages/base.toml. utah.toml says so in as many words -- "it is the parity contract, and any drift there is a parity bug" -- and just check-parity exists to make that loud. It has drifted, so that check is red on main today and every open pull request inherits the failure, #94 and #105 among them. The drift is four hunks: firefox moved into [fedora], and libgda, libgda-sqlite and ppp missing. Syncing the file alone would have been worse than the failure it fixes. All three missing names were measured against both repositories the image actually enables -- the digest-pinned factory metadata layer from Containerfile, and public-hummingbird-x86_64-rpms: libgda absent from both libgda-sqlite absent from both ppp absent from both, and nothing Provides it So a bare sync hands three unresolvable names to the install transaction and turns a failing lint into a failing image build. The sync and the [unavailable] entries have to land together, which is why they are one commit. Each entry carries a tracking issue, as that list requires: libgda, libgda-sqlite (#106) Upstream added both for the maintained Copyous extension (bluefin#1210). Hummingbird carries no package whose name contains gda at all. One factory recipe covers both, because libgda-sqlite is a subpackage of the libgda SRPM rather than its own source -- Fedora's libgda.spec declares %package sqlite alongside ui, tools, sqlcipher, mysql and postgres. ppp (#107) Worth more than dial-up trivia. Hummingbird ships NetworkManager-ppp, both 1.58.0-1.hum1 and 1.58.1-1.hum1, and its metadata carries Requires: ppp. With ppp nowhere in the enabled set that plugin is uninstallable from Hummingbird's own repository, so NetworkManager's PPPoE and PPTP paths cannot be installed at all. It is the same shape as avahi (#104) and nautilus (#100): a plugin shipped without the daemon behind it. firefox needed no handling. It is already in [unavailable], and contract() filters that set out of every section, so moving it between sections cannot put it back in the image -- which matters, because Utah ships org.mozilla.firefox as a Flatpak and re-adding the RPM would regress that decision. This change installs nothing new and removes nothing. Proven rather than argued: contract() over main's two files and over this branch's both return the same 74 packages, with no additions and no removals, and libgda, libgda-sqlite, ppp and firefox are each absent from the resulting set. 23 tests pass, 45 subtests pass. The parity diff against upstream is now empty, the RPM contract check reports 58 Bluefin, 10 GNOME and 5 service packages, and install-packages.py's own guard confirms no [unavailable] package appears in the install set. Noted but deliberately not changed: evolution-ews-core, fish and zsh predate this and carry no issue reference, so the "every entry MUST carry a tracking issue" rule is not currently enforced by anything. Worth a guard, but not in a commit whose job is restoring the contract. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M * fix(e2e): capture the fastfetch shot at 1080p, with its logo The screenshot on the repository front page is the project's end-to-end evidence, and it was about to lose Utah's branding. #84 added fastfetch --logo none to the session bashrc, which suppresses the logo outright. The committed screenshot predates that change and still has the Utahraptor in it, so the next passing run would have quietly replaced it with a logo-less one. The workaround was reasonable, because the logo genuinely did not fit. fastfetch needs about 90 columns with it -- roughly 33 for the logo column plus a ~57 character detail line -- and Ghostty opens at 80x24, so lines like KVM/QEMU Standard PC (Q35 + ICH9, 2009) (pc-q35-11.1) wrapped to column 0 and pushed fastfetch's own header off the top of the window. The committed screenshot shows exactly that: its first visible line is the tail of a wrapped one, and the OS identity line is scrolled away. Columns are the lever, and point size on its own is not. Ghostty sizes its window in cells, so a smaller font yields a smaller window with the same 80 columns and the same wrap -- it would have traded the wrap for worse OCR and fixed nothing. What buys the columns is the display: both VMs now ask for 1920x1080 instead of the 1280x800 the machine default gave, and at that size a 110-column window at 12pt is about 880px of 1920. The logo fits with room to spare and the font goes UP from the default rather than down, which helps the tesseract gate that reads UTAH-E2E-FASTFETCH and Kernel out of the image. xres/yres are the EDID preferred-mode hints QEMU passes to the guest. -vga none replaces the machine default with the same stdvga device rather than a different adapter, so the graphics path is unchanged -- this is a mode hint, not a driver swap. Applied to the live VM as well as the installed one, since live-desktop.png is published in the same record. Ghostty is a flatpak here, and which config path it honours depends on whether the sandbox exposes xdg-config or keeps its own per-app directory, so the geometry is written to both ~/.config/ghostty/config and ~/.var/app/<app>/config/ghostty/config rather than guessing. Everything is overridable: UTAH_E2E_DISPLAY_WIDTH, UTAH_E2E_DISPLAY_HEIGHT, UTAH_E2E_FONT_SIZE, UTAH_E2E_COLUMNS, UTAH_E2E_ROWS. Verified what can be verified without a hypervisor. The remote script was rendered through a stub ssh_target and executed against a throwaway HOME: it writes both ghostty configs with the expected three keys, writes the autostart entry, and leaves `fastfetch && echo UTAH-E2E-FASTFETCH` in bashrc with no --logo none. VGA_ARGS expands to exactly four argv entries, so no word splitting. All shell scripts parse; 23 tests and 45 subtests pass. NOT verified here: that QEMU accepts VGA.xres/yres in this build, and that the guest picks 1920x1080 from the EDID hint. There is no hypervisor in this environment. Both fail loudly rather than silently if wrong -- a rejected device property aborts the VM at startup, and a display that stayed at 1280x800 would still wrap and fail the OCR gate. Separately noted, not fixed: docs/verification/screenshots/installed-desktop.png and installed-fastfetch.png are currently byte-identical (cd6577d6...). The desktop shot is taken after the terminal autostart has already mapped fastfetch, so two named checkpoints record one frame. That is a question about what installed-desktop is meant to prove, not about font size, so it is left alone here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M --------- Co-authored-by: Claude <noreply@anthropic.com>
6 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the existing LUKS ISO test into the post-build pipeline for every configured flavor, using verified digest artifacts from successful testing builds. Promotion depends on the full ISO matrix; superseded commits cannot move testing tags. Preserve failure diagnostics and propose README/docs screenshot updates only after all flavors pass, with image/commit/run/checksum provenance. Debug ISOs and disks containing test credentials are never uploaded. Enable explicit build dispatch after main-to-testing sync and move nightly scheduling there. Harden the existing harness with restricted guest networking, disposable-disk SSH, required PNG captures, and OCR verification of fastfetch output. Validation: 16 unit tests, just check, and all pre-commit/actionlint checks pass; digest parser also verified against all four real artifacts from build 35053878858. The first full hosted ISO/QEMU run is still pending. Includes CI and local-testing skill updates. Related: #14, #15, #13, #45; this reuses merged #41 rather than adding another harness.