Skip to content

fix(e2e): capture the fastfetch shot at 1080p, with its logo - #112

Merged
castrojo merged 4 commits into
mainfrom
claude/fastfetch-capture-legible
Sep 18, 2026
Merged

castrojo merged 4 commits into
mainfrom
claude/fastfetch-capture-legible

Conversation

@hanthor

@hanthor hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

The fastfetch screenshot on the front page is this project's end-to-end evidence, and it was about to lose Utah's branding.

What's actually happening

iso/scripts/luks-e2e.sh puts this in the session bashrc (added by #84, 63d4d15):

[[ $- == *i* ]] && { fastfetch --logo none && echo UTAH-E2E-FASTFETCH; }

--logo none suppresses the logo outright. The committed screenshot predates that change — it's from #41 (281735c), its content is dated Sep 6, and it still has the Utahraptor in it. So the next passing run would have quietly replaced the front-page image with a logo-less one.

And the workaround was reasonable, because the logo genuinely didn't fit. fastfetch needs ~90 columns with it — roughly 33 for the logo column plus a ~57 character detail line — and Ghostty opens at 80x24, so lines like

KVM/QEMU Standard PC (Q35 + ICH9, 2009) (pc-q35-11.1)

wrapped to column 0 and pushed fastfetch's own header off the top. You can see it in the committed shot: the first visible line is the tail of a wrapped one (0)), and the OS identity line is scrolled away entirely.

Why font size alone wouldn't have fixed it

Ghostty sizes its window in cells. A smaller font gives a smaller window with the same 80 columns and the same wrap — it would have traded the wrap for worse OCR and fixed nothing.

Columns are the lever, and what buys columns is the display. Both VMs now ask for 1920x1080 instead of the 1280x800 the machine default gave. At that size a 110-column window at 12pt is about 880px of 1920: the logo fits with room to spare, and the font goes up from the default rather than down — which helps the tesseract gate that reads UTAH-E2E-FASTFETCH and Kernel out of the image.

xres/yres are the EDID preferred-mode hints QEMU passes to the guest. -vga none replaces the machine default with the same stdvga device rather than a different adapter, so the graphics path is unchanged — a mode hint, not a driver swap. Applied to the live VM too, since live-desktop.png is published in the same record.

Ghostty is a flatpak here and which config path it honours depends on whether the sandbox exposes xdg-config or keeps its own per-app directory, so the geometry goes to both ~/.config/ghostty/config and ~/.var/app/<app>/config/ghostty/config rather than guessing.

All overridable: UTAH_E2E_DISPLAY_WIDTH, UTAH_E2E_DISPLAY_HEIGHT, UTAH_E2E_FONT_SIZE, UTAH_E2E_COLUMNS, UTAH_E2E_ROWS.

Verification

What can be checked without a hypervisor, was:

  • The remote script was rendered through a stub ssh_target and executed against a throwaway HOME. It writes both ghostty configs with the expected three keys, writes the autostart entry, and leaves fastfetch && echo UTAH-E2E-FASTFETCH in bashrc with no --logo none.
  • VGA_ARGS expands to exactly four argv entries — no word splitting.
  • All shell scripts parse; 23 tests and 45 subtests pass.

Not verified here, stated plainly: that QEMU accepts VGA.xres/yres in this build, and that the guest actually picks 1920x1080 from the EDID hint. There's no hypervisor in this environment. Both fail loudly rather than silently — a rejected device property aborts the VM at startup, and a display that stayed at 1280x800 would still wrap and still fail the OCR gate. This wants one real just luks-test run to confirm.

Noticed, deliberately not fixed here

docs/verification/screenshots/installed-desktop.png and installed-fastfetch.png are currently byte-identical (cd6577d6…). The desktop shot is taken after the terminal autostart has already mapped fastfetch, so two named checkpoints record one frame — the verification record claims to show two things while showing one. That's a question about what installed-desktop is meant to prove, not about font size, so I've left it alone. Happy to take it separately.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M


Generated by Claude Code

packages/bluefin.toml is meant to be a byte-for-byte copy of upstream
Bluefin's build_files/packages/base.toml. utah.toml says so in as many words
-- "it is the parity contract, and any drift there is a parity bug" -- and
just check-parity exists to make that loud. It has drifted, so that check is
red on main today and every open pull request inherits the failure, #94 and
#105 among them.

The drift is four hunks: firefox moved into [fedora], and libgda,
libgda-sqlite and ppp missing.

Syncing the file alone would have been worse than the failure it fixes. All
three missing names were measured against both repositories the image
actually enables -- the digest-pinned factory metadata layer from
Containerfile, and public-hummingbird-x86_64-rpms:

    libgda           absent from both
    libgda-sqlite    absent from both
    ppp              absent from both, and nothing Provides it

So a bare sync hands three unresolvable names to the install transaction and
turns a failing lint into a failing image build. The sync and the
[unavailable] entries have to land together, which is why they are one
commit.

Each entry carries a tracking issue, as that list requires:

  libgda, libgda-sqlite (#106)
    Upstream added both for the maintained Copyous extension
    (bluefin#1210). Hummingbird carries no package whose name contains gda
    at all. One factory recipe covers both, because libgda-sqlite is a
    subpackage of the libgda SRPM rather than its own source -- Fedora's
    libgda.spec declares %package sqlite alongside ui, tools, sqlcipher,
    mysql and postgres.

  ppp (#107)
    Worth more than dial-up trivia. Hummingbird ships NetworkManager-ppp,
    both 1.58.0-1.hum1 and 1.58.1-1.hum1, and its metadata carries
    Requires: ppp. With ppp nowhere in the enabled set that plugin is
    uninstallable from Hummingbird's own repository, so NetworkManager's
    PPPoE and PPTP paths cannot be installed at all. It is the same shape as
    avahi (#104) and nautilus (#100): a plugin shipped without the daemon
    behind it.

firefox needed no handling. It is already in [unavailable], and contract()
filters that set out of every section, so moving it between sections cannot
put it back in the image -- which matters, because Utah ships
org.mozilla.firefox as a Flatpak and re-adding the RPM would regress that
decision.

This change installs nothing new and removes nothing. Proven rather than
argued: contract() over main's two files and over this branch's both return
the same 74 packages, with no additions and no removals, and libgda,
libgda-sqlite, ppp and firefox are each absent from the resulting set.

23 tests pass, 45 subtests pass. The parity diff against upstream is now
empty, the RPM contract check reports 58 Bluefin, 10 GNOME and 5 service
packages, and install-packages.py's own guard confirms no [unavailable]
package appears in the install set.

Noted but deliberately not changed: evolution-ews-core, fish and zsh predate
this and carry no issue reference, so the "every entry MUST carry a tracking
issue" rule is not currently enforced by anything. Worth a guard, but not in
a commit whose job is restoring the contract.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
The screenshot on the repository front page is the project's end-to-end
evidence, and it was about to lose Utah's branding. #84 added

    fastfetch --logo none

to the session bashrc, which suppresses the logo outright. The committed
screenshot predates that change and still has the Utahraptor in it, so the
next passing run would have quietly replaced it with a logo-less one.

The workaround was reasonable, because the logo genuinely did not fit.
fastfetch needs about 90 columns with it -- roughly 33 for the logo column
plus a ~57 character detail line -- and Ghostty opens at 80x24, so lines like

    KVM/QEMU Standard PC (Q35 + ICH9, 2009) (pc-q35-11.1)

wrapped to column 0 and pushed fastfetch's own header off the top of the
window. The committed screenshot shows exactly that: its first visible line is
the tail of a wrapped one, and the OS identity line is scrolled away.

Columns are the lever, and point size on its own is not. Ghostty sizes its
window in cells, so a smaller font yields a smaller window with the same 80
columns and the same wrap -- it would have traded the wrap for worse OCR and
fixed nothing. What buys the columns is the display: both VMs now ask for
1920x1080 instead of the 1280x800 the machine default gave, and at that size a
110-column window at 12pt is about 880px of 1920. The logo fits with room to
spare and the font goes UP from the default rather than down, which helps the
tesseract gate that reads UTAH-E2E-FASTFETCH and Kernel out of the image.

xres/yres are the EDID preferred-mode hints QEMU passes to the guest. -vga
none replaces the machine default with the same stdvga device rather than a
different adapter, so the graphics path is unchanged -- this is a mode hint,
not a driver swap. Applied to the live VM as well as the installed one, since
live-desktop.png is published in the same record.

Ghostty is a flatpak here, and which config path it honours depends on whether
the sandbox exposes xdg-config or keeps its own per-app directory, so the
geometry is written to both ~/.config/ghostty/config and
~/.var/app/<app>/config/ghostty/config rather than guessing. Everything is
overridable: UTAH_E2E_DISPLAY_WIDTH, UTAH_E2E_DISPLAY_HEIGHT,
UTAH_E2E_FONT_SIZE, UTAH_E2E_COLUMNS, UTAH_E2E_ROWS.

Verified what can be verified without a hypervisor. The remote script was
rendered through a stub ssh_target and executed against a throwaway HOME: it
writes both ghostty configs with the expected three keys, writes the autostart
entry, and leaves `fastfetch && echo UTAH-E2E-FASTFETCH` in bashrc with no
--logo none. VGA_ARGS expands to exactly four argv entries, so no word
splitting. All shell scripts parse; 23 tests and 45 subtests pass.

NOT verified here: that QEMU accepts VGA.xres/yres in this build, and that the
guest picks 1920x1080 from the EDID hint. There is no hypervisor in this
environment. Both fail loudly rather than silently if wrong -- a rejected
device property aborts the VM at startup, and a display that stayed at
1280x800 would still wrap and fail the OCR gate.

Separately noted, not fixed: docs/verification/screenshots/installed-desktop.png
and installed-fastfetch.png are currently byte-identical (cd6577d6...). The
desktop shot is taken after the terminal autostart has already mapped
fastfetch, so two named checkpoints record one frame. That is a question about
what installed-desktop is meant to prove, not about font size, so it is left
alone here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

CI came back red on contract → "Check Bluefin parity", which is not this PR's — it's the drift inherited from main, the same failure sitting on #94 and originally on #105. Validate manifests passed, and the failure then skipped everything downstream including both image builds.

Rather than wait for #108 to land, I've merged it in — head is now d57aefc. It no-ops the moment main carries it, and #108 stays the reviewable unit for that change.

Verified on the merged head:

parity diff against upstream : empty
23 tests, 45 subtests        : pass
rpm contract --check         : 58 Bluefin, 10 GNOME, 5 service
install set                  : 74 packages, [unavailable] overlap none
all shell scripts parse

And the e2e change survived the merge intact — VGA_ARGS in all three places, and the bashrc line is fastfetch && echo UTAH-E2E-FASTFETCH with no --logo none.

Worth being explicit about what this PR's CI can and cannot tell you: the contract job only checks manifests and shell syntax, so a green run here does not exercise the change. xres/yres being accepted by QEMU, and the guest taking the 1920x1080 EDID hint, are only provable by an actual just luks-test run. Both fail loudly if wrong — a rejected device property aborts the VM at startup, and a display that stayed at 1280x800 would still wrap and still fail the OCR gate — so a bad screenshot cannot pass silently. But that run is the real verification.


Generated by Claude Code

@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

@castrojo could you review/approve? Without this the next passing E2E run replaces the front-page fastfetch screenshot with a logo-less one. Green, blocked only on the last-pusher approval rule.


Generated by Claude Code

#110 landed the same libgda, libgda-sqlite and ppp entries with shorter
notes; this branch's versions already carry them, so its text is kept.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the net diff, not the commit titles. The commit list on this branch looks alarming — it carries fix: restore the bluefin.toml parity contract and a merge commit saying keep this branch's [unavailable] entries — so I checked whether an e2e-titled PR was smuggling a package-contract change.

It is not. Verified in an isolated clone:

  • git diff --exit-code origin/main...pr-112 -- packages/bluefin.toml exits 0 with no output. The byte-for-byte upstream copy is untouched, so just check-parity is unaffected.
  • The only packages/ residue is comment prose in packages/utah.toml (the libgda and ppp [unavailable] rationales). No package name, no section, and no tracking issue changes. The parity commit genuinely cancels out through the merges.

The actual change is confined to iso/scripts/luks-e2e.sh:

  • VGA_ARGS (lines 59-61) requests a 1920x1080 EDID mode, passed to both the live and installed QEMU launches (lines 218 and 419), so the two VMs now share display arguments.
  • --logo none is dropped at line 499 so fastfetch keeps its logo.
  • Ghostty is sized to 110x35 at 12pt (lines 507-510) before login.
  • Capture still goes through the existing shot installed-fastfetch path (lines 609/623) and the existing OCR gate, so this is consistent with every other capture rather than a special case.

bash -n iso/scripts/luks-e2e.sh parses clean, and qemu-system-x86_64 -device VGA,help confirms xres/yres exist. All 14 checks SUCCESS.

One nit, deliberately not fixed: the packages/utah.toml comment rewrite is unrelated to a screenshot fix and strictly speaking breaks the one-logical-change rule. It changes no behavior and no contract value, so I am not going to churn the branch over prose — but the tidy version of this PR touches one file.

Caveat on evidence: dispatch-iso is SKIPPED on pull_request, so the 1080p capture is not actually exercised by this PR's CI. The resolution/OCR result gets proven on the next post-testing e2e run, not here.

Approving.

@castrojo
castrojo merged commit e3de077 into main Sep 18, 2026
14 checks passed
@castrojo
castrojo deleted the claude/fastfetch-capture-legible branch September 18, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants