Skip to content

ci(extensions): automate weekly GNOME extension submodule bumps - #645

Merged
hanthor merged 7 commits into
projectbluefin:mainfrom
hanthor:exp/extension-bump-automation
Oct 12, 2026
Merged

hanthor merged 7 commits into
projectbluefin:mainfrom
hanthor:exp/extension-bump-automation

Conversation

@hanthor

@hanthor hanthor commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Weekly scheduled run moves each GNOME extension submodule to its configured upstream branch and opens or updates a review. The PR body lists old and new commits plus the extension's declared GNOME Shell versions. Tag-only refs are not valid submodule.*.branch values; appindicator tracks its real master branch, which currently declares GNOME 51 support.

The workflow dispatches build.yml with contract_only=true after a proposal changes. That checks source contracts only: it does not build an image or run the image-side extension verifier. A trusted full image build must verify the proposed extension heads before merge. The workflow does not auto-merge.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the workflow at bcff10c against .gitmodules, build.yml and update-bluefin-parity.yml. The bump mechanism and the no-diff/close path look right; two things don't do what the body says they do.

1. The "new" column is always the old SHA — .github/workflows/update-gnome-extensions.yml:67

new=$(git ls-files -s "$p" | awk '{print $2}') reads the superproject index. git submodule update --remote (line 51) only moves each submodule's worktree; it does not stage the new gitlink (that happens later when create-pull-request runs git add on add-paths). Reproduced in a scratch repo: after submodule update --remote, git ls-files -s s and git ls-tree HEAD s both still return the old commit while git -C s rev-parse HEAD returns the new one. Consequence: old == new for every row, so the table prints (unchanged) in the shell-version column for every extension and the metadata.json lookup at lines 72–76 never runs — the body's main deliverable is empty on exactly the weeks it matters. Fix is one line:

new=$(git -C "$p" rev-parse HEAD)

(git diff --quiet at line 80 is unaffected; it does see worktree submodule movement — verified exit 1 in the same scratch repo.)

2. verify-gnome-extensions does not gate the bump PR as described

The PR body says "the image build's verify-gnome-extensions gates the merge." On this workflow it cannot run automatically: verify-gnome-extensions executes inside the image build (Containerfile:263), the PR is created with the default github.token (create-pull-request step, line 88), so GitHub does not fire pull_request workflows for it, and the explicit dispatch at line 108 passes contract_only=true, which skips build_main/build_kernel (build.yml:218,243,268). The only checks that land on the bump branch are the contract gates (just check, check-parity, check-repos). Same pattern as update-bluefin-parity.yml, so this is consistent with the repo — but the PR body generated at line 56 ("The image build on this PR runs verify-gnome-extensions") and this PR's description both promise a check that won't appear unless a human pushes or closes/reopens the bump PR. Suggest either rewording both to say the maintainer must trigger the image build, or dropping contract_only (with the publish implications the build.yml:9–19 comment warns about).

Otherwise: the tmp/… submodule paths are covered by add-paths, actions: write is sufficient for gh workflow run, and the empty body-path pre-write on line 41 is a correct workaround for the no-diff case.

Confidence: 3/5 (needs attention) — 2 medium findings

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@castrojo

Copy link
Copy Markdown
Contributor

Pushed fix to line 67: new=$(git -C "$p" rev-parse HEAD) so the extension bump table reads the updated worktree commit rather than the unstaged superproject index.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at head b9c103a.

correctness

  • High — the bump step fails on every run. .gitmodules pins appindicatorsupport@rgcjonas.gmail.com to branch = v65 (.gitmodules:4), but upstream ubuntu/gnome-shell-extension-appindicator has no branch v65 — only the tag. git submodule update --remote --depth 1 -- $paths (update-gnome-extensions.yml:47) therefore exits 128 with fatal: Unable to find refs/remotes/origin/v65 revision in submodule path, and set -euo pipefail (:32) aborts the job before any PR is proposed. Reproduced locally with a fresh submodule + branch v65. Either skip submodules whose branch resolves to a tag, or change the .gitmodules entry to a real branch (and decide whether appindicator should track at all).
  • Low — gsconnect's metadata lives at data/metadata.json.in (scripts/verify-gnome-extensions.py:19), so find "$p" -maxdepth 2 -name metadata.json (:66) never matches and the table column is always ? for it; | head -n 1 can also pick an unrelated metadata.json (tests/fixtures) in other trees.

security

  • Medium — python3 -c "... open('$meta') ..." (update-gnome-extensions.yml:68) interpolates a path discovered by find inside third-party submodule trees into Python source. A directory name containing ') in an upstream extension repo becomes code executed in a job holding contents: write/pull-requests: write/actions: write (:17-19). Pass the path as sys.argv[1] instead. The shell-version strings (also upstream-controlled) are then written unescaped into the PR body table (:79).

intent-alignment

  • Low — body says "the image build's verify-gnome-extensions gates the merge", but a PR opened with GITHUB_TOKEN gets no pull_request run (docs/skills/ci-workflows.md:61-63) and the explicit dispatch is contract_only=true (:109-110), which skips every image job (build.yml:218, :243, :268). Only the source-side check verify-gnome-extensions.py --source via just check (Justfile:84) runs on the bump branch; the image-side verification (Justfile:180-181) does not run until a human pushes or re-triggers a full build. Worth stating accurately in the body and PR template text (:50-52).

style

  • Low — changed=true/false (:83-87) is never consumed (the propose step has no if), and the "All pinned GNOME extensions match" placeholder (:35) is unconditionally overwritten by the table at :81, so the comment at :32-34 describes behavior that no longer exists. Drop the output or gate the dispatch on it.

docs-currency

  • Low — docs/skills/ci-workflows.md:39-73 documents update-bluefin-parity.yml including the GITHUB_TOKEN/dispatch quirk this workflow copies; the new workflow (and its contract_only dispatch) is not added there or to the ci-workflows description in docs/skills/index.json:17.

Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hanthor

hanthor commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

Request changes at b9c103a. git submodule update --remote treats .gitmodules branch=v65 for appindicator as a remote branch, but v65 is a tag, so the scheduled bump aborts before opening a PR. Handle tag-pinned entries explicitly. Also pass the discovered metadata path as a Python argv value instead of interpolating it into Python source: upstream-controlled filenames currently become code in a write-token job. Use the known GSConnect data/metadata.json.in path, and accurately describe contract_only dispatches: they do not run image-side verification. Document this workflow in the CI skill. Do not edit vendored extension contents.

Reviewed with Codex.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
b9c103a

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head b9c103a3790c) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/update-gnome-extensions.yml
  • permission_escalation — widens workflow permissions or uses pull_request_target (Widens GitHub Actions permissions or switches to pull_request_target)
    • .github/workflows/update-gnome-extensions.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/update-gnome-extensions.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

castrojo
castrojo previously approved these changes Oct 11, 2026

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: clean, non-disruptive scheduled workflow to automate weekly GNOME extension bumps via create-pull-request and contract checks. Follows repo conventions.

@castrojo
castrojo dismissed their stale review October 11, 2026 16:45

Dismissing self-review: reviewer has commits on this branch and is disqualified per review policy.

@hanthor

hanthor commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

Review blockers for the next revision: the scheduled updater currently fails before proposing a PR because .gitmodules pins appindicatorsupport@rgcjonas.gmail.com to branch = v65, but upstream exposes v65 as a tag, not a branch. Please track a real branch or handle tag-only pins. Also pass discovered metadata paths as argv instead of interpolating them into Python source; those paths come from third-party submodules and this workflow has contents, pull-request, and actions write permissions. Please correct the gsconnect metadata lookup and describe accurately which verification runs before merge. Re-run the workflow and checks.

@hanthor
hanthor force-pushed the exp/extension-bump-automation branch from b9c103a to a2ca5b0 Compare October 11, 2026 21:01

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at a2ca5b0. The new weekly job will fail on its first run: it cannot see the upstream branch for two of the extensions it is supposed to update, so no bump PR gets opened. One fix needed; everything else checks out.

correctness

  • .github/workflows/update-gnome-extensions.yml:38-40 — git submodule update --init --depth 1 makes each submodule a shallow, single-branch clone whose fetch refspec covers only the remote's default branch. The following git submodule update --remote --depth 1 then looks up refs/remotes/origin/<branch> and dies for any submodule whose .gitmodules branch is not the upstream default. Two currently are: BudsLink-Companion (branch = Gnome-Extension, upstream HEAD is main, .gitmodules:44) and tilingshell (branch = v18.0, upstream HEAD is main, .gitmodules:40). Reproduced on a fresh shallow clone of this head with git 2.47:
    fatal: Unable to find refs/remotes/origin/Gnome-Extension revision in submodule path '.../BudsLink-Companion@maniacx.github.com'
    fatal: Unable to find refs/remotes/origin/v18.0 revision in submodule path '.../tmp/tilingshell@ferrarodomenico.com'
    
    With set -euo pipefail the step aborts, so the job is red every Monday and never reaches create-pull-request. Verified fix: before the --remote call, fetch the configured branch into its tracking ref for each path, e.g. br=$(git config -f .gitmodules submodule."$p".branch); [ -n "$br" ] && git -C "$p" fetch --depth 1 origin "+refs/heads/$br:refs/remotes/origin/$br" — after that the same --remote --depth 1 succeeds and moves BudsLink to f76e866. (The tests/ suite does not cover the workflow shell, so this was not caught by just test.)

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 high finding

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor
88767b4

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head 88767b494fc2) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/update-gnome-extensions.yml
  • permission_escalation — widens workflow permissions or uses pull_request_target (Widens GitHub Actions permissions or switches to pull_request_target)
    • .github/workflows/update-gnome-extensions.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/update-gnome-extensions.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hanthor

hanthor commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

Updated at 88767b4: the scheduled updater now fetches each .gitmodules tracked branch into its remote-tracking ref before checkout, which supports shallow clones of non-default branches. I reproduced the exact shallow-default-main path for tilingshell v18.0 and BudsLink Gnome-Extension; the targeted branch fetches and checkouts succeeded (832aac5 and f76e866). Targeted pre-commit passes, and the PR's contract and kernel-cache CI jobs have started.

The workflow is new in this PR, so its scheduled/dispatch path can only run from the default branch after merge. The updated PR body correctly states that dispatched CI is contract-only; the image-side extension verifier runs during a normal image build.

@hanthor

hanthor commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

Addressed the latest review finding in 88767b4: the updater explicitly fetches each configured submodule branch before advancing it. I reproduced the shallow-clone path for tilingshell (v18.0) and BudsLink (Gnome-Extension), and both advanced to their configured branch commits. The full Utah CI run now passes for main, gaming, NVIDIA, and NVIDIA gaming, including the image builds and Trivy scans: https://github.com/projectbluefin/utah/actions/runs/38175323621. Please re-review this head when convenient.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weekly bot that moves the bundled GNOME extensions to their latest upstream commits and opens a review PR. The automation itself is wired like the existing parity bot and looks safe; the gaps are in the report it produces and in one line of the docs.

correctness

  • scripts/gnome-extension-shell-versions.py:14 only looks at <ext>/metadata.json and <ext>/data/metadata.json.in. Nine of the sixteen submodules keep metadata elsewhere (src/, resources/, nested dirs — see scripts/verify-gnome-extensions.py:11-29, e.g. tilingshell resources/metadata.json; confirmed its v18.0 tree has no root metadata.json). Those rows in the bump PR table will always read ?, so the "declared GNOME Shell versions" column the PR body promises is missing for most extensions. Reuse the SOURCE_EXTENSIONS map (or accept a metadata path) instead of guessing two locations.

docs-currency

  • docs/skills/ci-workflows.md:80 says the dispatch runs "without review_vm", but no review_vm input or symbol exists anywhere in the repo (build.yml workflow_dispatch has only contract_only/sha). Drop the phrase or name the real input.

style

  • .github/workflows/update-gnome-extensions.yml:86-88 — if git diff --quiet; then exit 0; fi is the last statement of the step, so it changes nothing. The parity sibling (update-bluefin-parity.yml:46-48,82) emits a changed= output there; either do the same or delete the block.

No findings from: security, intent-alignment.

Confidence: 3/5 (needs attention) — 1 medium finding; 2 perspectives requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hanthor

hanthor commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

Addressed the review notes on the current head: d2be3f4 reads metadata from the verifier’s shared SOURCE_EXTENSIONS map (including nested and multi-extension submodules), the workflow now always invokes create-pull-request on an empty diff so it can close a stale bump, and the CI skill describes the local review VM behavior accurately. just check passes with 1,041 tests and the targeted pre-commit hooks pass. The current-head contract run is in progress: https://github.com/projectbluefin/utah/actions/runs/38177619326. Please re-review when checks finish.

@hanthor
hanthor requested a review from castrojo October 11, 2026 21:45
@hivecommons-hive

Copy link
Copy Markdown
Contributor
4e83f8f

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head 4e83f8f91368) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/update-gnome-extensions.yml
  • permission_escalation — widens workflow permissions or uses pull_request_target (Widens GitHub Actions permissions or switches to pull_request_target)
    • .github/workflows/update-gnome-extensions.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/update-gnome-extensions.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency (out-of-scope, pre-existing)

  • docs/skills/desktop-contract.md:245-251 still says .gitmodules "pins eight of them" and lists eight names; .gitmodules at this head has 16 submodules. Not introduced here, but this PR is the one that makes pin movement automatic, so the section describing the pins is the natural place to point at update-gnome-extensions.yml. Backlog, not blocking.

No findings from: correctness, security, intent-alignment, style.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at head 4e83f8f. The workflow, the report script and the .gitmodules change all check out: every configured branch is a real remote head (v65 was an annotated tag, master declares GNOME 51), the new tests and the full tests/run_suite.py pass, and the report script produces correct rows against real submodule checkouts.

docs-currency

  • docs/skills/ci-workflows.md:32-33, :85 and the description at :15 / docs/skills/index.json:17 describe a review_vm=true dispatch input that "builds an image locally and tests an offline ISO in a disposable VM". build.yml at this head has no review_vm input (only contract_only and sha); it comes from the still-open PR #627. If #627 lands first this is fine, but merged on its own this PR documents a flag that does not exist. Suggest dropping the review_vm / "offline ISO review VMs" sentences here and letting #627 add them.

No findings from: correctness, security, intent-alignment, style.

Confidence: 3/5 (needs attention) — 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hanthor

hanthor commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

Also addressed the latest docs-currency note in ab59032: desktop-contract.md now documents all 16 pinned extension trees and links the weekly updater; I regenerated the skill index. Focused pre-commit checks pass. The current-head Utah CI run is https://github.com/projectbluefin/utah/actions/runs/38179024848.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
eccfe1b

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head eccfe1b2b000) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/update-gnome-extensions.yml
  • permission_escalation — widens workflow permissions or uses pull_request_target (Widens GitHub Actions permissions or switches to pull_request_target)
    • .github/workflows/update-gnome-extensions.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/update-gnome-extensions.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hanthor

hanthor commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

Retry completed successfully after Codeberg recovered: all three kernel image flavors passed on current head eccfe1b. The failed first attempt was limited to transient Codeberg 503 responses during submodule checkout.

hivecommons-hive Bot pushed a commit to mrbobbytables/utah that referenced this pull request Oct 11, 2026


No content change. The earlier commit message claimed the weekly
update-gnome-extensions workflow was documented; it is not on main yet
(proposed in projectbluefin#645). desktop-contract.md correctly states pins are bumped
manually. PR title/body updated to match and the projectbluefin#682 closing link removed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Fix-Attempt: 2/6
Signed-off-by: scanner <scanner@hive.kubestellar.io>
Danathar
Danathar previously approved these changes Oct 12, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at eccfe1b. Both earlier blockers are fixed:

  • .gitmodules now tracks appindicator's master branch, which exists upstream (fbc758a4). The old branch = v65 was only a tag, so the weekly update would have failed.
  • The workflow no longer builds Python code from text found in third-party extension trees. It calls python3 scripts/gnome-extension-shell-versions.py "$p" with the path as a quoted argument, and top-level permissions are {}.

CI is green on this head. Not run: the weekly job itself.

castrojo and others added 6 commits October 12, 2026 11:30
Track appindicator on its real upstream branch, parse metadata without code interpolation, and document that the dispatched run checks contracts only.

Assisted-by: GPT-6 via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
A shallow submodule checkout only has the upstream default branch. Fetch the configured branch into its remote-tracking ref before selecting it, so tilingshell and BudsLink updates work too.

Assisted-by: GPT-6 via Codex

Co-authored-by: OpenAI Codex <noreply@openai.com>
Reuse SOURCE_EXTENSIONS from verify-gnome-extensions.py so the shell-version
column resolves nested metadata (src/, resources/, multi-extension repos)
instead of rendering '?'. Drop the reference to a non-existent review_vm
input from the CI workflow docs.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <scanner@hive.kubestellar.io>
@hivecommons-hive

Copy link
Copy Markdown
Contributor
2638af5

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head 2638af5c0579) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/update-gnome-extensions.yml
  • permission_escalation — widens workflow permissions or uses pull_request_target (Widens GitHub Actions permissions or switches to pull_request_target)
    • .github/workflows/update-gnome-extensions.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/update-gnome-extensions.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUMAN DECISION NEEDED — @hanthor decide what to do with the BudsLink extension: its tracked upstream branch is now a README-only stub, so the very first weekly bump PR this workflow opens will fail the extension contract and block every other bump until someone hand-edits it.

This change adds a scheduled job that moves each bundled GNOME extension to the newest commit on its upstream branch and opens a review PR. I ran the bump step from head 2638af5 locally against the live upstreams. The shell and Python logic work as written (tests pass, report renders correctly), but two of the branches .gitmodules points at do not match what is currently shipped, so the first proposal would be wrong.

correctness

  • tailscale-gnome-qs would be downgraded. .gitmodules:57 says branch = main, but the pinned gitlink 7feced3 (2026-07-29, "fix: Mullvad Exit nodes filter broken (#62)") is only reachable from upstream develop, not main. Upstream main head is 5307ed1 (2026-02-27, "Update main (#12)") and declares shell-version 45–49, versus 45–50 at the current pin. Because zz3-bluefin-unsupported-stuff.gschema.override:2 sets disable-extension-version-validation=true, verify-gnome-extensions.py:77 skips the GNOME 51 check, so the contract-only CI this workflow dispatches (update-gnome-extensions.yml:97-108) would pass and the bump PR would read as green. The PR fixed the same class of mismatch for appindicator (.gitmodules:4) but missed this one. Fix: branch = develop for tailscale (or re-pin from main deliberately). The report table (update-gnome-extensions.yml:68-82) shows only the new shell-version list, not the old, so a reviewer of the bump PR has no cue that the range shrank — consider printing both.
  • BudsLink-Companion upstream branch is empty. .gitmodules:41 tracks Gnome-Extension; its head f76e866 (2026-09-20) contains only README.md, which says the extension moved to maniacx/Bluetooth-Battery-Meter. The bump moves the gitlink there, scripts/gnome-extension-shell-versions.py:49 prints ?, and verify-gnome-extensions.py:69-70 fails just check with "missing …/metadata.json". Since all 16 extensions share one branch/PR (update-gnome-extensions.yml:88-95), that red check also holds back appindicator, blur-my-shell, dash-to-dock, gsconnect and fuzzy-application-search, which all have real new heads today. Needs a maintainer call: pin BudsLink out of the bump loop (e.g. drop branch and skip it, or update = none), replace the submodule, or accept a permanently red first PR.

docs-currency

  • docs/skills/desktop-contract.md:248 says .gitmodules pins all 16 trees "by URL and branch", but fuzzy-application-search@mkhl.codeberg.page (.gitmodules:43-45) has no branch and the workflow has a dedicated remote-HEAD path for that case (update-gnome-extensions.yml:51-53). Say "by URL and, where set, branch" or add the branch.

No findings from: security, intent-alignment, style.

Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hanthor
hanthor merged commit d1f6416 into projectbluefin:main Oct 12, 2026
15 checks passed
hanthor pushed a commit to mrbobbytables/utah that referenced this pull request Oct 12, 2026


No content change. The earlier commit message claimed the weekly
update-gnome-extensions workflow was documented; it is not on main yet
(proposed in projectbluefin#645). desktop-contract.md correctly states pins are bumped
manually. PR title/body updated to match and the projectbluefin#682 closing link removed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Fix-Attempt: 2/6
Signed-off-by: scanner <scanner@hive.kubestellar.io>
hanthor pushed a commit to mrbobbytables/utah that referenced this pull request Oct 12, 2026


No content change. The earlier commit message claimed the weekly
update-gnome-extensions workflow was documented; it is not on main yet
(proposed in projectbluefin#645). desktop-contract.md correctly states pins are bumped
manually. PR title/body updated to match and the projectbluefin#682 closing link removed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Fix-Attempt: 2/6
Signed-off-by: scanner <scanner@hive.kubestellar.io>
hanthor pushed a commit to mrbobbytables/utah that referenced this pull request Oct 12, 2026


No content change. The earlier commit message claimed the weekly
update-gnome-extensions workflow was documented; it is not on main yet
(proposed in projectbluefin#645). desktop-contract.md correctly states pins are bumped
manually. PR title/body updated to match and the projectbluefin#682 closing link removed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Fix-Attempt: 2/6
Signed-off-by: scanner <scanner@hive.kubestellar.io>
hanthor added a commit that referenced this pull request Oct 12, 2026
* docs(skills): update desktop contract GNOME extension submodules currency

Update docs/skills/desktop-contract.md to reflect the current 16 GNOME
extension submodules declared in .gitmodules (expanded by Dakota extensions)
and document the weekly automated update workflow (.github/workflows/update-gnome-extensions.yml).
Regenerate docs/skills/index.json to keep skill catalog metadata current.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Run: #682
Hive-Plan: docs-currency
Hive-Spec: desktop-contract#submodules
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>

* docs(skills): correct scope - weekly workflow pending #645

No content change. The earlier commit message claimed the weekly
update-gnome-extensions workflow was documented; it is not on main yet
(proposed in #645). desktop-contract.md correctly states pins are bumped
manually. PR title/body updated to match and the #682 closing link removed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Fix-Attempt: 2/6
Signed-off-by: scanner <scanner@hive.kubestellar.io>

* docs(skills): clarify extension updater contract

Assisted-by: OpenAI Codex via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs(skills): clarify Search Light removal

Assisted-by: OpenAI Codex via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs(skills): split desktop verifier guidance

Move build and installed-image verifier details into a reference page, keeping the skill below its hard line cap.

Assisted-by: OpenAI Codex via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Signed-off-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: James Reilly <jreilly1821@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants