Repository navigation
Conversation
There was a problem hiding this comment.
This change refreshes the desktop guide so it lists all 16 GNOME extension submodules instead of eight. The extension list itself matches what the repository tracks. One sentence, however, describes an automated weekly update job that does not yet exist in this repository, so a reader following the guide would be sent to a file that is not there.
docs-currency
docs/skills/desktop-contract.md:253-254states "Pin movement is automated weekly by.github/workflows/update-gnome-extensions.yml", but that workflow is not present at head7e22308(.github/workflows/contains onlyupdate-bluefin-parity.ymlas an update job). The workflow is introduced by PR #645, which is still open onexp/extension-bump-automation, and #645 itself also editsdesktop-contract.md. Either drop/soften that sentence until #645 lands, or rebase this PR onto #645. The PR body's "introduced in PR #645" reads as if it were merged; it is not.
No findings from: correctness, security, intent-alignment, style.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
This change refreshes the desktop docs so the GNOME extension list matches what the repo actually ships. The list itself is now right, but the PR's title and description promise something the text does not deliver.
intent-alignment
- PR title/body claim a weekly update workflow is documented; the diff says the opposite. Title: "…and weekly workflow"; body: "Documents the weekly automated update workflow (
.github/workflows/update-gnome-extensions.yml) introduced in PR #645." The actual new text atdocs/skills/desktop-contract.md:251-252reads "Pins are bumped manually; there is no automated update workflow yet." The diff text is correct for head6d0f146—.github/workflows/has noupdate-gnome-extensions.ymland #645 is still open, unmerged. Issue #682 asked the section to point at that workflow once pin movement is automated, so this PR only half-closes it. Fix: retitle/rewrite the PR body to say the workflow is not yet merged (and ideally mention #645), or rebase onto #645 once merged — note #645 also edits this same section ofdesktop-contract.md, so expect a conflict either way.
No findings from: correctness, security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
castrojo
left a comment
There was a problem hiding this comment.
Checked against the PR head: .gitmodules declares 16 submodules under system_files/shared/usr/share/gnome-shell/extensions/, and the list in desktop-contract.md matches those paths (hider and renamer are two separate entries, listed together). index.json last_updated is kept in sync with the front matter. Docs-only, checks green.
hanthor
left a comment
There was a problem hiding this comment.
The updated inventory still says “Pins are bumped manually; there is no automated update workflow yet.” PR #645 adds the weekly GNOME-extension updater and has been rebased to the current main; once it passes CI and receives a fresh approval, that statement will be false. Please update this paragraph to describe the workflow (or make the wording conditional on #645 not landing), then regenerate the skill index and rerun contract checks.
|
Current evidence: #645 has merged and installs the weekly submodule update workflow, so the sentence “Pins are bumped manually; there is no automated update workflow yet” is now inaccurate. Please amend this section to describe the workflow’s proposal/verification behavior, regenerate index.json if frontmatter changes, and rerun contract. The rest of this PR is good; I will approve/merge once that stale statement is fixed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
1020521 to
8146bc5
Compare
There was a problem hiding this comment.
Reviewed at head 8146bc5 (the queued SHA aa66130 was superseded by the second commit).
docs-currency
docs/skills/desktop-contract.md:256-257— the rewrite leaves a broken sentence: "A full image build must verify the proposed pins before merge, andset_shader_source(removed in GNOME 51), failing ISO tests." The subject ("Search Light was dropped: its shader code calls…") was deleted, so a reader can no longer tell what was removed or why. The base text's guidance "edit.gitmodulesdirectly when changing a source or its tracked branch" was also dropped without replacement. Restore both (e.g. "…before merge. Search Light was dropped: its shader code callsset_shader_source, removed in GNOME 51, so it errored at load and failed the ISO end-to-end test.").
intent-alignment
- PR body vs diff: the body says the PR "states that extension pins are currently bumped manually; no automated update workflow exists on
main" and "regeneratesdocs/skills/index.json", but the diff (single file,desktop-contract.md:250-257) describes the workflow as existing — correctly, since #645 merged at 12:25Z and.github/workflows/update-gnome-extensions.ymlis onmain.index.jsonis not in the changeset. The "Not in scope" paragraph is likewise stale. Please update the body; with #645 merged this canCloses #682rather thanRefs. - Title claims "update … for 16 extension submodules", but
mainalready reads "pins all 16 extension trees" atdesktop-contract.md:248(landed with #645); the diff does not change the count. Net change is a reword of the workflow paragraph, which is fine, but title/body should say so.
No findings from: correctness, security, style.
Confidence: 3/5 (needs attention) — 1 medium finding; 2 perspectives requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Addressed the review in 0297c3f: the page now describes the existing weekly updater, its metadata-only contract check, the required image build, direct |
There was a problem hiding this comment.
docs-currency
- low —
docs/skills/desktop-contract.md:255: the rewritten Search Light sentence keeps theset_shader_source/ GNOME 51 reason but drops the fact the old text led with ("Search Light was dropped"). A reader now learns why it broke, not that it is no longer shipped (it is absent from.gitmodulesat head). Suggest: "Search Light was dropped: GNOME 51 removedset_shader_source, which its shader code calls, so it failed ISO tests."
Everything else in the paragraph checks out against .github/workflows/update-gnome-extensions.yml at head (old/new + shell-version table, contract_only=true dispatch, no image build or installed verifier).
No findings from: correctness, security, intent-alignment, style.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Added the explicit “Search Light was dropped” fact in e22b15b, with the GNOME 51 API-removal reason. The title/body now describe only the workflow documentation this PR changes; targeted checks still pass and the skill remains 500 lines. |
There was a problem hiding this comment.
Verified the rewritten paragraph against .github/workflows/update-gnome-extensions.yml and .github/workflows/build.yml at e22b15b: PR body table (old/new/shell-version), contract_only=true dispatch, no image build, and .gitmodules count of 16 all match the new text.
style (out-of-scope, low)
docs/skills/desktop-contract.mdis exactly 500 lines, which isMAX_HARD=500inscripts/check-skill-frontmatter.sh:7,80. Pre-existing (this PR is 7/7 lines), but the next one-line addition to this skill fails CI; the paragraph compression here (line 255 is now 116 chars) is already a symptom. Backlog: split or trim the skill.
No findings from: correctness, security, intent-alignment, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
…ency Update docs/skills/desktop-contract.md to reflect the current 16 GNOME extension submodules declared in .gitmodules (expanded by Dakota extensions) and document the weekly automated update workflow (.github/workflows/update-gnome-extensions.yml). Regenerate docs/skills/index.json to keep skill catalog metadata current. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Run: projectbluefin#682 Hive-Plan: docs-currency Hive-Spec: desktop-contract#submodules Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
No content change. The earlier commit message claimed the weekly update-gnome-extensions workflow was documented; it is not on main yet (proposed in projectbluefin#645). desktop-contract.md correctly states pins are bumped manually. PR title/body updated to match and the projectbluefin#682 closing link removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Fix-Attempt: 2/6 Signed-off-by: scanner <scanner@hive.kubestellar.io>
Assisted-by: OpenAI Codex via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: OpenAI Codex via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move build and installed-image verifier details into a reference page, keeping the skill below its hard line cap. Assisted-by: OpenAI Codex via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
e22b15b to
e939610
Compare
Change
Document the weekly GNOME extension updater, its metadata-only contract check, the required image build before merge, and direct
.gitmodulessource/branch edits. State why Search Light was dropped for GNOME 51. Move verifier details into a linked reference sodesktop-contract.mdis below its 500-line hard cap.Verification
bash scripts/check-skill-frontmatter.sh(desktop-contract.md: 476 lines, below the hard cap).bash scripts/check-skill-index.shandpython3 scripts/generate_skill_index.py --check.python3 -m unittest tests.test_desktop_contract tests.test_gnome_extensions(59 tests; 2 skipped).Closes #682.
Closes #714.