Repository navigation
[scanner] fix: ship precompiled dash-to-dock stylesheet (sassc unavailable) - #53
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
dash-to-dock's Makefile renders stylesheet.css from _stylesheet.scss with sassc, which neither the Hummingbird base nor the Utah package repository provides. Main requested sassc in [build] and failed at package install; dropping that leaves the make step failing with 'sassc: No such file or directory' in every Build Utah run. Ship the stylesheet precompiled for the pinned extensions.gnome.org-v106 submodule ref (scss sha256 75892eff...), install it in place of the make invocation, and guard on the scss digest so a submodule bump fails loudly instead of shipping a stale stylesheet. Also drop sassc from the build-tool removal list in configure-services.sh, where removing a package that is no longer installed could fail the build. Closes #52 Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
hanthor
left a comment
There was a problem hiding this comment.
The red check here is not this PR's fault
Recording this explicitly so the failing Build Utah doesn't get read as a defect in the change. This PR's build failure is the pre-existing main breakage, hit several steps before anything this PR touches.
This PR, run 34549576780, job build_main / image:
install: cannot create regular file '/usr/local/libexec/utah-install-packages': No such file or directory
Error: building at STEP "RUN for pair in install-packages.py:utah-install-packages ..."
error: recipe `build-ghcr` failed with exit code 1
The base branch, main@636b48e, scheduled run 34654001732, same job:
install: cannot create regular file '/usr/local/libexec/utah-install-packages': No such file or directory
Error: building at STEP "RUN for pair in install-packages.py:utah-install-packages ..."
error: recipe `build-ghcr` failed with exit code 1
Byte-identical failure, same Containerfile step, on the unmodified base. This is Containerfile:81 — install -m 0755 into a /usr/local/libexec that the current base image no longer ships — which is #55/#56's subject, not #52's. The build dies at STEP 10 and never reaches the make -C .../dash-to-dock@micxgx.gmail.com step this PR is about, so the sassc fix is neither confirmed nor refuted by CI yet.
The contract job passed (just check, just check-parity, just check-repos), so the static side of this PR is clean.
Consequence: the actual fix is still unverified
The claim under test — that make fails with sassc: No such file or directory (Makefile:94, Error 127) and that shipping the precompiled stylesheet resolves it — has not been exercised by any green build. It needs main unblocked first.
Dependency order, as far as I can tell: #56 must land (with its typo fixed — it currently has a ${pair##*:} → ${pair##:*} regression that moves the failure to exit 127) before this PR's CI can say anything useful.
Two things to check once it can build
-
The drift guard. The description says the build fails loudly if
_stylesheet.scsschanges, keyed to sha25675892eff2b2d98fc94046a1d1a0a0defb4daaa8f0cadee251205e353ea048e0fat submodule refextensions.gnome.org-v106. Worth confirming that guard actually fires — a digest check that silently passes because the file path moved would be worse than no guard, since the stylesheet would go stale invisibly. -
Overlap with #46. #46 currently carries this same change — the identical 2058-line
system_files/shared/usr/share/utah/dash-to-dock-stylesheet.css, the samebuild-gnome-extensions.shsassc removal, and the sameconfigure-services.shbuild-tool-removal-list edit. Whichever lands second will conflict. Given #46 is nominally a Search Light shader fix, this PR is the right home for it; I've suggested there that #46 drop it.
Also worth noting for the record: sassc is in [unavailable] in packages/utah.toml on main today, yet scripts/build-gnome-extensions.sh still invokes it. That inconsistency is real and this PR is the correct way to resolve it. The analysis is good — it just needs a green build to prove it.
Generated by Claude Code
|
No longer needed: merged #82 consumes the published package candidate containing sassc. All four image builds passed with the real extension build, so the precompiled stylesheet workaround is unnecessary. Evidence: https://github.com/projectbluefin/utah/actions/runs/34996661981. |
Fix
Every Build Utah run on main fails at
make -C .../dash-to-dock@micxgx.gmail.com→sassc: No such file or directory(Makefile:94, Error 127). sassc is in[unavailable]in packages/utah.toml but was still requested in[build]and still invoked by scripts/build-gnome-extensions.sh.Claims exactly:
packages/utah.toml([build] list),scripts/build-gnome-extensions.sh(Dash to Dock block),scripts/configure-services.sh(build-tool removal list), newsystem_files/shared/usr/share/utah/dash-to-dock-stylesheet.css(precompiled from pinned submodule ref extensions.gnome.org-v106, scss sha256 75892eff2b2d98fc94046a1d1a0a0defb4daaa8f0cadee251205e353ea048e0f). Drift guard: build fails loudly if _stylesheet.scss changes.Closes #52
Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=kimi-k3