Repository navigation
refactor: single-source install-repo identity in packages/*.repo — scripts/check-repo-availability.py REPOS - #74
Closed
hivecommons-hive[bot] wants to merge 1 commit into
Closed
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…/*.repo check-repo-availability.py restated the install-source set as its own hardcoded REPOS dict, and the copy had already drifted: it keyed Hummingbird as 'public-hummingbird' while the real repo ID is 'public-hummingbird-x86_64-rpms'. The checker now parses packages/*.repo, selects sections marked '# utah-install: true', and follows a '# ci-mirror:' annotation for the factory repo whose in-image baseurl is file:///etc/utah-packages. nvidia-container-toolkit stays excluded — it is enabled on the image but consumed only by utah-install-nvidia. Refs #73 — the install-packages.py REPOS half is deliberately left open: its textual guard lives in the Justfile, occupied by open hold-gated #44, and the script's Containerfile region is occupied by #56. Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
This was referenced Sep 17, 2026
Member
|
Closing: this conflicts with Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
Claimed ground:
scripts/check-repo-availability.py,packages/hummingbird.repo,packages/utah-packages.repoonly. Disjoint from open PRs #44 (Justfile, scripts/flavors.py), #48 (iso/live/src/install-flatpaks.sh), #53 (packages/utah.toml, build-gnome-extensions.sh, configure-services.sh), #56 (Containerfile).Utah's install-source identity — which repos the image installs from, at which URLs — was stated three times, and the copies had already diverged:
check-repo-availability.pykeyed Hummingbird aspublic-hummingbird, but the real repo ID inpackages/hummingbird.repoispublic-hummingbird-x86_64-rpms. A repo rename or baseurl move would have left the CI preflight validating a different repository set than the build installs from.This PR makes
packages/*.repothe single statement:check-repo-availability.pygainsinstall_repos(): it parsespackages/*.repo(located via the manifest path, no second hardcoded path), selects sections marked# utah-install: true, and uses the real section ID as the label.packages/hummingbird.repoandpackages/utah-packages.repocarry the marker; the factory repo also carries# ci-mirror: https://projectbluefin.github.io/utah-packages/because its in-imagebaseurl=file:///etc/utah-packagesis unreachable from CI.nvidia-container-toolkitstays excluded — enabled on the image, but consumed only byutah-install-nvidia, not the main transaction.file://baseurl withoutci-mirrorexits with a named error.Verified:
install_repos()returns exactly the two real repo IDs with correct URLs (unit-level, including both error paths), and the full checker runs green against the live repositories (3515 + 421 packages, all 72 contract packages available).Refs #73 — the
install-packages.pyREPOS tuple half is deliberately left open: its textual guard lives in the Justfile (occupied by open hold-gated #44) and the script's Containerfile region is occupied by #56. Thesection()TOML-reader triplication noted in #73 is also left for the same reason.Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=architect backend=copilot model=kimi-k3 copilot=1.0.78