Skip to content

refactor: single-source install-repo identity in packages/*.repo — scripts/check-repo-availability.py REPOS - #74

Closed
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
arch/repo-identity-single-source
Closed

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
arch/repo-identity-single-source

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Refactor

Claimed ground: scripts/check-repo-availability.py, packages/hummingbird.repo, packages/utah-packages.repo only. Disjoint from open PRs #44 (Justfile, scripts/flavors.py), #48 (iso/live/src/install-flatpaks.sh), #53 (packages/utah.toml, build-gnome-extensions.sh, configure-services.sh), #56 (Containerfile).

Utah's install-source identity — which repos the image installs from, at which URLs — was stated three times, and the copies had already diverged: check-repo-availability.py keyed Hummingbird as public-hummingbird, but the real repo ID in packages/hummingbird.repo is public-hummingbird-x86_64-rpms. A repo rename or baseurl move would have left the CI preflight validating a different repository set than the build installs from.

This PR makes packages/*.repo the single statement:

  • check-repo-availability.py gains install_repos(): it parses packages/*.repo (located via the manifest path, no second hardcoded path), selects sections marked # utah-install: true, and uses the real section ID as the label.
  • packages/hummingbird.repo and packages/utah-packages.repo carry the marker; the factory repo also carries # ci-mirror: https://projectbluefin.github.io/utah-packages/ because its in-image baseurl=file:///etc/utah-packages is unreachable from CI.
  • nvidia-container-toolkit stays excluded — enabled on the image, but consumed only by utah-install-nvidia, not the main transaction.
  • Failure is loud, never silent fallback: an unmarked repo set or a file:// baseurl without ci-mirror exits with a named error.

Verified: install_repos() returns exactly the two real repo IDs with correct URLs (unit-level, including both error paths), and the full checker runs green against the live repositories (3515 + 421 packages, all 72 contract packages available).

Refs #73 — the install-packages.py REPOS tuple half is deliberately left open: its textual guard lives in the Justfile (occupied by open hold-gated #44) and the script's Containerfile region is occupied by #56. The section() TOML-reader triplication noted in #73 is also left for the same reason.


Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=architect backend=copilot model=kimi-k3 copilot=1.0.78

…/*.repo

check-repo-availability.py restated the install-source set as its own
hardcoded REPOS dict, and the copy had already drifted: it keyed
Hummingbird as 'public-hummingbird' while the real repo ID is
'public-hummingbird-x86_64-rpms'. The checker now parses packages/*.repo,
selects sections marked '# utah-install: true', and follows a
'# ci-mirror:' annotation for the factory repo whose in-image baseurl is
file:///etc/utah-packages. nvidia-container-toolkit stays excluded — it is
enabled on the image but consumed only by utah-install-nvidia.

Refs #73 — the install-packages.py REPOS half is deliberately left open:
its textual guard lives in the Justfile, occupied by open hold-gated #44,
and the script's Containerfile region is occupied by #56.

Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2026
@hivecommons-hive hivecommons-hive Bot changed the title [architect] refactor: single-source install-repo identity in packages/*.repo — scripts/check-repo-availability.py REPOS refactor: single-source install-repo identity in packages/*.repo — scripts/check-repo-availability.py REPOS Sep 17, 2026
@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

Closing: this conflicts with main's scripts/check-repo-availability.py and the hive agent doesn't rebase, so it can't move on its own. The single-source idea for the install-repo identity stands; the issues it references (#53, #56, #73) keep it, and a fresh PR against main picks it up.


Generated by Claude Code

@hanthor hanthor closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/scanner Filed or owned by the scanner agent. hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant