Repository navigation
fix: disable nvidia-container repo on non-NVIDIA flavors - #192
Conversation
packages/nvidia-container.repo shipped enabled=1 and was copied into every image via the Containerfile's yum.repos.d COPY, so a plain utah or utah-gaming install exposed NVIDIA's third-party runtime repository even though scripts/install-nvidia.sh -- the only thing that installs from it -- runs solely on the nvidia flavors. That contradicts the policy that Utah's runtime repositories are Hummingbird plus the pinned utah-packages factory. Ship the repo enabled=0 everywhere (the COPY stays; it is harmless disabled) and turn it on for the single install transaction on the NVIDIA flavors, --enablerepo=nvidia-container-toolkit, the same narrow window projectbluefin#133 gives utah-packages.repo. Non-NVIDIA images now list only Hummingbird in `dnf repolist`, while the NVIDIA flavors still install nvidia-container-toolkit with repo_gpgcheck=1 and the pinned fingerprint intact. Assisted-by: lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K Co-authored-by: Claude https://claude.ai/ghost
Danathar
left a comment
There was a problem hiding this comment.
What I checked: two-line change. packages/nvidia-container.repo flips to enabled=0, and the one consumer — the dnf install nvidia-container-toolkit in install-nvidia.sh, which only runs on NVIDIA flavors — adds --enablerepo=nvidia-container-toolkit for that single transaction. So a non-NVIDIA image no longer lists a third-party repo in dnf repolist, and the NVIDIA flavors still get the toolkit. Same pattern #133 uses for the factory repo. All 9 checks green. Closes #169.
castrojo
left a comment
There was a problem hiding this comment.
Reviewed diff and verification evidence. Disables packages/nvidia-container.repo by default (enabled=0) and restricts its enablement to the nvidia-container-toolkit dnf transaction in install-nvidia.sh via --enablerepo. Non-NVIDIA images no longer expose third-party repo in dnf repolist. Clean CI.
Problem
packages/nvidia-container.reposhippedenabled=1and was copied into everyimage by the Containerfile's
yum.repos.dCOPY, so a plainutahorutah-gaminginstall exposed NVIDIA's third-party runtime repository even thoughscripts/install-nvidia.sh-- the only consumer -- runs solely on the NVIDIAflavors. That contradicts the policy that Utah's runtime repositories are Hummingbird
plus the pinned
utah-packagesfactory (issue #169).Change
Ship the repo
enabled=0everywhere (the COPY stays; it is harmless disabled) andturn it on for the single install transaction on the NVIDIA flavors with
--enablerepo=nvidia-container-toolkit, the same narrow window #133 givesutah-packages.repo.Acceptance:
dnf repoliston a non-NVIDIA Utah image lists only Hummingbird.nvidia-container-toolkitwithrepo_gpgcheck=1and the pinned fingerprint
C95B 321B 61E8 8C18 09C4 F759 DDCA E044 F796 ECB0intact.Verified:
python3 scripts/verify-rpm-contract.py --checkandpython3 scripts/install-packages.py --check --repos-dir packagesboth pass;bash -n scripts/install-nvidia.shclean.— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K
🐝 Hive Agent:
contributor| SHA:191aade