Repository navigation
Conversation
nvidia-container.repo was copied into every flavor's /etc/yum.repos.d/ with enabled=1, so plain utah and utah-gaming images shipped an enabled third-party runtime repository even though nothing on those flavors installs from it. Utah's stated policy is that its runtime repositories are Hummingbird plus the pinned utah-packages factory, and nothing else. Ship the repo with enabled=0 everywhere, matching the pattern utah-packages.repo uses, and have install-nvidia.sh enable it only for the one transaction that needs it (--enablerepo=nvidia-container-toolkit). The NVIDIA flavors still install nvidia-container-toolkit with its pinned key check intact. Fixes #169 Assisted-by: Claude Sonnet 5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
…ression test - docs/skills/package-contract.md: record that packages/nvidia-container.repo ships enabled=0 in every flavor and is enabled only by install-nvidia.sh for its one transaction (#169). Regenerate docs/skills/index.json and index.md to match the bumped last_updated/generated_at. - tests/test_package_resolution.py: pin the fix with a regression test asserting nvidia-container.repo ships enabled=0 (never enabled=1) with repo_gpgcheck=1 intact, and that install-nvidia.sh enables it via --enablerepo=nvidia-container-toolkit. Assisted-by: Claude Sonnet 5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
ffeca63 to
7e98359
Compare
There was a problem hiding this comment.
style
- (low) The comment in
packages/nvidia-container.repo:26-28("enables it for the one transaction that needs it, the same pattern utah-packages.repo uses") misdescribes the reference pattern:packages/utah-packages.repo:12shipsenabled=1and is flipped toenabled=0by sed after the last install step (Containerfile:209) — it is never scoped with--enablerepo. This file is the firstenabled=0-from-the-start +--enablereporepo; a future maintainer copying "the utah-packages pattern" from this comment would build the wrong thing. Same claim appears in the PR body. Non-blocking.
No findings from: correctness, security, intent-alignment, docs-currency.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
…repo claim Review found the comment misdescribed the reference pattern: utah-packages.repo ships enabled=1 and is flipped to enabled=0 by sed after the last install step (Containerfile:209), never scoped with --enablerepo. nvidia-container.repo is the first enabled=0-from-the-start + --enablerepo repo, not a copy of that pattern. Fix the comment to describe both patterns accurately so a future maintainer copying 'the utah-packages pattern' from it builds the right thing. Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Correct — fixed in
|
CI triage: the red check is a transient mirror failure, not this diff
Each one reports the same thing: A deterministic packaging fault picks the same package every time. Three different The same run proves it is not this PREvery other image built from this exact commit succeeded: Two points stand out:
What this needsNo code change. The job needs a re-run. I could not trigger one myself — both If the hummingbird mirror keeps dropping connections across unrelated PRs, that is worth tracking separately as an infrastructure incident rather than absorbing it as per-PR retries — the in-workflow retry already burned all three of its attempts here. — hive: agent=scanner backend=copilot model=claude-opus-5 |
|
Closing as superseded: disabling packages/nvidia-container.repo by default and enabling it narrowly during nvidia-container-toolkit install in install-nvidia.sh was implemented and merged via #192. |
What
packages/nvidia-container.repois copied into every flavor's/etc/yum.repos.d/(Containerfile:43), and it shipped withenabled=1. That means a plainutahorutah-gaminginstall had an enabled third-party runtime repository pointing athttps://nvidia.github.io/libnvidia-container/stable/rpm/$basearch, even though nothing on those flavors installs from it --scripts/install-nvidia.shruns only on thenvidia/nvidia-gamingflavors.Utah's stated policy (AGENTS.md) is that its runtime repositories are Hummingbird plus the pinned
utah-packagesfactory, and nothing else. This contradicted it on every image.Fix
Ship
nvidia-container.repowithenabled=0everywhere -- unlikepackages/utah-packages.repo, which starts enabled and is flipped off by sed after the flavor step's last install -- and haveinstall-nvidia.shenable the repository only for the one transaction that needs it, with--enablerepo=nvidia-container-toolkit. This narrows the window on the flavors that do use it and matches the second option from the issue (closer to what #133 did forutah-packages.repo).The pinned key check is untouched:
repo_gpgcheck=1, key fingerprintC95B 321B 61E8 8C18 09C4 F759 DDCA E044 F796 ECB0.Also: added a regression test (
tests/test_package_resolution.py) pinningenabled=0+repo_gpgcheck=1in the repo file and the--enablerepoflag ininstall-nvidia.sh, and updateddocs/skills/package-contract.md's repository-policy section (plus the generated skill catalog) to document the scoping.Acceptance (from #169)
dnf repoliston a non-NVIDIA Utah image lists only Hummingbird (the repo now ships disabled and nothing enables it outsideinstall-nvidia.sh).nvidia-container-toolkitwith its pinned key check intact.Testing
python3 -m unittest discover -s tests -p 'test_*.py'-- pre-existing failures only, all from missingyaml/jsonschemamodules in this environment (workflow-output and skill-index-catalog checks), unrelated to this change. All package/repo/rpm-contract tests pass, including the new regression test.bash scripts/check-skill-frontmatter.shandbash scripts/check-skill-index.shpass.just/pipwere not available in this environment, sojust checkandscripts/generate_skill_index.py --writecould not be run directly; the skill catalog (index.json/index.md) was hand-synced to match the doc's bumpedlast_updated/generated_at.Fixes #169
— hive: backend=omp model=anthropic/claude-sonnet-5 effort=medium