Repository navigation
fix: enable PipeWire user units so GNOME screencast can start - #177
Conversation
Assisted-by: Muse Spark 1.3 in OpenCode
Assisted-by: Muse Spark 1.3 in OpenCode
Assisted-by: Muse Spark 1.3 in OpenCode
hanthor
left a comment
There was a problem hiding this comment.
Approving — this is the right fix and it follows the conventions the repo already has. contract and kernel_cache are green; the four image builds are still running, and I will merge once they finish.
Why it is right, checked against the tree rather than the description:
scripts/configure-services.shalready guards every global user-unit enable withuser_unit_exists, and this uses the same shape, in the same block, for the same reason.- Enabling the sockets and leaving the
.serviceunits to socket activation matches Fedora's own preset, so this does not invent a new policy for Utah. - The comment at
scripts/configure-services.sh:88states the rule this PR is applying: "The preset must agree or first-boot preset-all will undo the build-time enablement." A--global enablewith nothing backing it in a user preset is exactly that failure.
Which is why the same file should probably carry two more lines. There is no user-preset/ anywhere on main — this PR creates the first one. So the two user units already enabled --global today, podman-auto-update.timer and ublue-user-setup.service, have precisely the bug you are fixing for PipeWire: nothing in a preset backs them, and if Hummingbird's user preset disables what it does not list, first-boot preset-all --global undoes them the same way it was undoing pipewire.socket. The difference is only that nobody has noticed, because neither has a symptom as visible as screencast failing.
If you are willing, adding
enable podman-auto-update.timer
enable ublue-user-setup.service
to the new preset (and the matching grep -q lines to just check) closes the whole class in one commit rather than leaving two-thirds of it for someone to rediscover. If you would rather keep this PR to the screencast fix, say so and I will open a follow-up issue instead — I will not hold the merge on it either way.
One thing worth a follow-up regardless: just check can only grep the preset text. scripts/verify-desktop-contract.py asserts system units with systemctl is-enabled, which is scope-blind to these, so nothing verifies the user units in the built image. systemctl --global is-enabled would make that a real in-image assertion rather than a file-content one.
Generated by Claude Code
|
One thing worth flagging now that this is merged, @KiKaraage — nothing you did wrong, and no action needed from you. This merged with So the fix currently lives only on The route back to Practical upshot: your change is safe (it is in the promotion PR's diff and will land on Thanks for this one — the finding that Hummingbird's server user preset disables everything unlisted is the useful part, and it turned out to apply to two units beyond PipeWire that nothing had noticed. Generated by Claude Code |
Closes #176
Hummingbird's server user preset (dbus only + disable *) leaves PipeWire disabled, so xdg-desktop-portal logs "Failed to connect to PipeWire" and GNOME screencast fails with "Couldn't connect pipewire context".
Assisted-by: Muse Spark 1.3 in OpenCode