Repository navigation
fix(services): enable Avahi and switcheroo-control - #411
Conversation
There was a problem hiding this comment.
correctness
- High —
avahidaemon package is not installed, so the new contract requirement will fail the image build.baselines/utah/rpms.tsvlists onlyavahi-glibandavahi-libs;packages/utah.tomlnever installsavahi(its only mention, line 347, describes avahi as "a plugin shipped without the daemon behind it", tracked by open #104).scripts/configure-services.sh:28-30guardsenable_unitwithunit_exists, soenable_unit avahi-daemon.service/.socket(lines 69-70) silently no-op, and the preset lines (85-utah-desktop.preset:6-7) match nothing. Butcontracts/bluefin-desktop.toml:133-134now requires both units enabled, andscripts/verify-desktop-contract.py:195-197reportsrequired service is not enabledwhensystemctl is-enabledfails on a missing unit — that runs inContainerfile:221right after configure-services, so the build fails. The PR body's "Both packages are already installed" is true forswitcheroo-control(baselines/utah/rpms.tsv) but not for avahi. Fix: addavahito[services]inpackages/utah.toml(what #150 does) or rebase onto/merge #150 before this lands.
docs-currency
- Low —
docs/skills/desktop-contract.md:152-154says both units are listed "so the source parity check can match each enabled unit", but no such check exists:tests/test_desktop_contract.py:267-300(ServiceMaskParityTests) only asserts the mask/disable lines, neverenableparity between the script and preset. Either drop the claim or add the test.
No findings from: security, intent-alignment, style.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Heads-up: please retarget this PR to Generated by Claude Code |
hanthor
left a comment
There was a problem hiding this comment.
Please retarget to main. A merge into testing gets orphaned when the sync workflow resets it. #150 is now closed in favour of this PR.
Generated by Claude Code
Preserve contributor history, repair the reviewed behavior, and migrate Utah helpers to immutable /usr/libexec as explicitly approved. Assisted-by: GPT-6.1 Sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Shared runtime-helper migration and lint prerequisite are owned solely by PR projectbluefin#372, per maintainer direction. Preserve all substantive fixes and original contributor history. Assisted-by: GPT-6.1 Sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6.1 Sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Concrete fixes pushed:
Local verification: |
There was a problem hiding this comment.
docs-currency
- (low) PR body says "Targets
testing, the integration branch…" but the PR is based onmain(baseRefName: main); the repo's recent merged PRs all targetmain. Body text should match the actual base so the promotion-flow claim isn't misleading. - (low)
docs/skills/desktop-contract.md:222— "Require the full pinned-repository transaction to resolve before building." is unclear in context (nothing in the diff enforces or defines that step). Either drop it or say what it refers to (install-packages.py's pinned repo resolution?). - (info)
baselines/triage.toml:1022still carries[package.avahi] status = "untriaged"; this PR installsavahiviapackages/utah.toml:318, so once thebaselines/utah/rpms.tsvsnapshot refreshes,image-baseline.py checkwill report it as "no longer a gap, drop". Fine to leave for the snapshot refresh, just noting the follow-up.
Context checked, no action needed: baselines/utah/rpms.tsv:34-35 shows only avahi-glib/avahi-libs, so adding avahi (contrary to #387's "both are installed already") is correct; avahi is present in the Hummingbird repo; Hummingbird's firewalld-2.5.1-1.hum1 public zone allows mdns, so the enabled daemon is reachable. Out-of-scope parity gap for later: Bluefin ships nss-mdns (baselines/bluefin/rpms.tsv:1210), Utah does not and Hummingbird does not carry it, so .local hostname resolution still won't work.
No findings from: correctness, security, intent-alignment, style.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed out-of-scope review findings as backlog issues so they do not block this PR:
Cap: 3 backlog issue(s) per PR. |
Assisted-by: GPT-6.1 Sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danathar
left a comment
There was a problem hiding this comment.
Read the whole diff. It adds the avahi package (the client libraries alone don't ship the daemon), enables avahi-daemon.service/.socket and switcheroo-control.service in both configure-services.sh and the preset, and adds them to the desktop contract. Counts and packages.json are updated consistently, and the image builds pass. The retarget hanthor asked for is done: the base is main. Nit: the description still says it targets testing. Out of scope but worth knowing: Bluefin also ships nss-mdns, so .local name resolution still won't work without it.
There was a problem hiding this comment.
intent-alignment
- (low) PR body says "No package changes are needed" and "Targets
testing", but the diff adds"avahi"topackages/utah.toml:318(and bumps counts inREADME.md:70,site/data/packages.json:182,210) and the base ismain. The diff is the correct one —baselines/utah/rpms.tsvlists onlyavahi-glib/avahi-libs, so #387's "both are installed already" does not hold for the daemon andenable_unit(scripts/configure-services.sh:28-30) would have silently no-op'd without the package. Please fix the body so the record matches.
correctness
- (low, unverified)
firewalld.serviceis enabled right after the new units (scripts/configure-services.sh:69-72) and the tree ships no firewalld zone config, so whether inbound mDNS (UDP 5353) is permitted in the image's default zone could not be confirmed from the repo. If it is not,avahi-daemonis enabled but discovery stays broken. The PR already flags runtime verification as outstanding; worth including afirewall-cmd --list-servicescheck when that happens.
No findings from: security, style, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
avahi-daemon could not start on Utah, so *.local names never resolved (#443: `ssh host.local` -> "Temporary failure in name resolution"; failed avahi-daemon.service and .socket). On a booted testing-20261001-41873b5: avc: denied { nnp_transition } scontext=init_t tcontext=avahi_t avc: denied { create } comm="avahi-daemon" ... tcontext=avahi_var_run_t avahi-daemon.service: Main process exited, status=255 Hummingbird's avahi 0.9~rc4 unit sets NoNewPrivileges=yes, and the targeted policy grants no init_t -> avahi_t nnp_transition, so the daemon stayed in init_t and failed writing its pid file. (The earlier theory in the issue, pid-directory ownership, was the symptom, not the cause.) Fedora's unit does not set NNP. Drop it with a unit drop-in; avahi_t stays SELinux-confined. Verified on the VM: with the drop-in, avahi-daemon is active as avahi_t, no AVC denials, and `getent hosts utah-pub.local` resolves. Enabling the units by default is #387 / #411. Assisted-by: Claude Opus 5.5 via Claude Code Co-authored-by: hanthor <hanthor@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Utah shipped Avahi and switcheroo-control but left them disabled. Enable avahi-daemon.service/.socket and switcheroo-control.service in configure-services.sh and the desktop preset, install the avahi daemon package, and require the units in the desktop contract (projectbluefin#387, projectbluefin#104). Rebased onto main after projectbluefin#547 (package counts) and projectbluefin#549 (avahi SELinux drop-in, which this needs for the daemon to start). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Rebased onto main as a single commit (maintainer edit): #547 changed the package counts and #549 landed the avahi SELinux drop-in this PR needs for the daemon to actually start. Resolved counts are 91 Utah additions / 152 installed; the behavioural diff is unchanged (same 8 files). Will merge once CI is green. 🤖 Generated with Claude Code |
1008681 to
63b01bf
Compare
There was a problem hiding this comment.
intent-alignment
- (low) PR body says "No package changes are needed", but the diff adds
avahitopackages/utah.toml:327(andsite/data/packages.json:184, counts inREADME.md:70). The diff is right —baselines/utah/rpms.tsv:34-35carries onlyavahi-glib/avahi-libs, noavahi, so the daemon units the preset enables would not exist without it (andenable_unitatscripts/configure-services.sh:29silently no-ops on missing units, leavingverify-desktop-contract.py:201-203to fail the build). Issue #387's "both are installed already" was wrong for Avahi; please update the body so the record matches. Body also says "Targetstesting" — base ismain, which is the correct target perdocs/skills/ci-workflows.md:305.
correctness
- (low) Enablement is build-verified only.
firewalld.serviceis enabled alongside (scripts/configure-services.sh:72,85-utah-desktop.preset:9) and the tree ships no firewalld zone config, so whether mDNS (5353/udp) actually passes depends on the Hummingbird base's default zone. Worth oneavahi-browse -aon a booted testing image before closing #387.
No findings from: security, style, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
…lable (#569) * fix(packages): record nss-mdns .local resolution parity gap as unavailable Bluefin ships nss-mdns (baselines/bluefin/rpms.tsv, 0.15.1-28.fc44) so `ping foo.local` resolves over mDNS; Utah does not, and Hummingbird's repository does not carry it either -- it appears in that repodata only as a Recommends of cups (a virtual provide), never as an installable <name>. Enabling avahi-daemon restores mDNS service browsing but not .local name resolution, which is what this module provides (the two are separate; reviewed against #411). Records nss-mdns as an image-level parity gap in packages/utah.toml [unavailable] and baselines/triage.toml ([package.nss-mdns], status unavailable, area network-fs, issue #499), mirroring the nvtop precedent. Bumps the genuinely-unavailable count 7 -> 8 and updates the README parity table, site/data/packages.json (regenerated), and docs/skills/package-contract.md in lockstep so just check stays green. Hive-Run: #499 Hive-Plan: record nss-mdns as an unavailable image-level parity gap in utah.toml and triage.toml, bump the unavailable count 7 to 8 and sync README, packages.json, package-contract.md Hive-Spec: package-contract.md#[unavailable] Signed-off-by: hive <hive@kubestellar.io> * fix(packages): drop nss-mdns triage entry the gap checker never reports nss-mdns ships no path in baselines/bluefin/surface.tsv, so image-baseline.py check never derives it as a gap and flagged the entry as one to drop. The parity debt stays recorded in packages/utah.toml [unavailable] and site/data/packages.json. Restore nvtop as the sole triage.toml example in package-contract.md. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io> --------- Signed-off-by: hive <hive@kubestellar.io> Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: hive <hive@kubestellar.io> Co-authored-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Utah ships Avahi and switcheroo-control but leaves them disabled. Enable
avahi-daemon.service,avahi-daemon.socket, andswitcheroo-control.serviceduring image configuration and in the desktop preset, restoring mDNS discovery and hybrid-GPU application launching defaults.The desktop contract now requires all three units to be enabled. The desktop skill documents why the script and preset must stay aligned. No package changes are needed.
Fixes #387.
Related: #150 also proposes Avahi enablement for #104; this PR overlaps that portion and additionally handles switcheroo-control and the Avahi socket.
Validation:
just checkpassed (429 tests).pre-commit run --all-filesfound existing whitespace/EOF issues in unrelated files and actionlint v1.7.7 rejected existingubuntu-26.04runner labels. Unrelated automatic formatting was reverted.Targets
testing, the integration branch used by the testing-to-main promotion workflow.— hive: backend=codex model=gpt-6-astra effort=medium
🐝 Hive Agent:
contributor| SHA:674602f