Skip to content

fix(ci): never bump archive-shipped extension gitlinks alone - #1344

Merged
hanthor merged 1 commit into
mainfrom
fix/ext-bump-skip-archives
Nov 19, 2026
Merged

hanthor merged 1 commit into
mainfrom
fix/ext-bump-skip-archives

Conversation

@hanthor

@hanthor hanthor commented Nov 19, 2026

Copy link
Copy Markdown
Member

Maintainer decision on #1290: Copyous ships from the pinned v2.1.2 zip, so moving its gitlink alone makes provenance.json name source that isn't what ships. Fixed on main as asked, since the bot regenerates #1290's branch.

  • .github/scripts/prepare-gnome-extension-bumps.py reads ARCHIVES, SOURCE_EXTENSIONS and EXTENSION_BASE from scripts/verify-gnome-extensions.py (with ast, no import side effects) and reports archive-shipped submodules as skipped (ships from a pinned archive), leaving their gitlink alone.
  • The bump test adds an archive-shipped submodule with a newer upstream head and asserts its gitlink stays put.
  • ci-workflows.md documents the rule.

The next bot run drops Copyous from #1290; the other three bumps can then land.

Verified: umask 022; just check passes (1351 tests).

Copyous ships from its pinned v2.1.2 zip; the weekly bump moved its gitlink
to a newer upstream head, so provenance.json would name source that does not
ship (#1290). prepare-gnome-extension-bumps.py now reads ARCHIVES from the
verifier and reports those submodules as skipped.

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hanthor
hanthor enabled auto-merge November 19, 2026 00:50
@mergeraptor
mergeraptor Bot requested review from ahmedadan and castrojo November 19, 2026 00:50
@mergeraptor mergeraptor Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2026
@mergeraptor

mergeraptor Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergeraptor
mergeraptor Bot requested review from bketelsen and daegalus November 19, 2026 00:50
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 19, 2026
@hanthor
hanthor added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 18c82a0 Nov 19, 2026
32 checks passed
@hanthor
hanthor deleted the fix/ext-bump-skip-archives branch November 19, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant