Skip to content

feat(packages): add media sharing to TVs and home network devices (rygel) - #1313

Merged
hanthor merged 3 commits into
projectbluefin:mainfrom
Karibhou:feat/rygel-media-sharing
Nov 20, 2026
Merged

hanthor merged 3 commits into
projectbluefin:mainfrom
Karibhou:feat/rygel-media-sharing

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary: This adds media sharing to Utah, so a computer can stream its music, videos and photos to TVs and other devices on the home network, the same way Dakota (Bluefin's sibling system) already does. It turns on the "Media Sharing" switch in the system Settings. The factory publishes rygel 46.1, gupnp-av 0.14.5, gupnp-dlna 0.12.0 and gst-editing-services 1.28.8 since pin d9972fa (#1372), which is now on main.


  • Installs rygel, gupnp-av, gupnp-dlna, gst-editing-services in [parity] of packages/utah.toml.
  • All four are factory-built (.hum1.bfin in pin d9972fa), so they are also in [factory].parity, which fails the build if one resolves anywhere else.
  • /etc/rygel.conf comes from the rygel package itself (config file), matching Dakota; no overlay file needed.
  • README/package-contract counts and site/data/packages.json regenerated.
  • The triage entries for rygel, gupnp-dlna and gst-editing-services stay until just baselines refreshes; they are dropped after that refresh.

Closes #1258

Maintainer edits

Rebased onto main after #1372 and added one commit (factory parity entries and counts); Karibhou's two commits are unchanged. umask 022; just check passed.

— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra

@Karibhou

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@Karibhou

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: restored the rygel/gupnp-dlna triage entries (contract check reads the published image, which lacks them until this ships). CI pending — sweep will merge when green.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). The change itself looks right: rygel, gupnp-av, gupnp-dlna and gst-editing-services in [parity] give GNOME Settings' Media Sharing what Dakota ships (#1258), and /etc/rygel.conf and the user unit come from the rygel package. One fix needed: contract fails in just check, before package availability is checked, with site/data/packages.json is stale; regenerate with python3 scripts/generate-site-data.py (job). Adding packages to utah.toml changes the counts, so please run that script (and scripts/check-doc-counts.py if the README or package-contract counts move too) and push. Once that's green, check-repos will show whether all four resolve against the current pin. (The red Prow run on this PR is the hive's /ok-to-test being refused by Prow, not your change.)

@Karibhou

Copy link
Copy Markdown
Contributor Author

Thanks @Danathar. I regenerated site/data/packages.json with scripts/generate-site-data.py and ran scripts/check-doc-counts.py --write in fc5fed0. That moved the Utah additions count in README.md and docs/skills/package-contract.md from 255 to 259. Locally, generate-site-data.py --check, check-doc-counts.py, install-packages.py --check and verify-rpm-contract.py --check all pass. CI on the new head will show whether the four packages resolve in check-repos.

Danathar
Danathar previously approved these changes Nov 16, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Approving; fc5fed0 regenerates site/data/packages.json and the README and package-contract counts, which was the one fix needed. contract was still running when I looked; its check-repos step is the one that confirms all four packages resolve against the pin, so let that go green before merge.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions

Copy link
Copy Markdown
Contributor

Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file

@Danathar

Copy link
Copy Markdown
Contributor

Stand-in note: the count fix worked. What's left is availability: check-repos now reports No match for argument: gupnp-av (rygel needs libgupnp-av-1.0.so.3). gupnp-av reached utah-packages main only with #1147, merged 11-16 at 1:44 AM EST, so no factory image Utah pins carries it yet. Neither does main's pin, and #1310's 73ce095 most likely predates it. This needs one more factory publish after #1147 and a pin bump that includes gupnp-av; then re-run contract. Nothing to change in this PR meanwhile, and my approval stands.

@Karibhou

Copy link
Copy Markdown
Contributor Author

Thanks @Danathar. Agreed: the remaining check-repos failure (No match for argument: gupnp-av) is availability, not this diff. gupnp-av landed in utah-packages via #1147; this PR needs a factory publish after that plus a Utah pin bump carrying it, then a contract re-run. Leaving head fc5fed0 unchanged until then.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): CI stayed red for 2h after the nudge and the relay nudge went unanswered. The hive will rebase this branch on main and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head fc5fed00c07c has not moved for 12h57m and the hive has nothing it can push: adoption-stalled:fork-rehome-refused.

Blocker: this PR comes from a fork (Karibhou/utah), and main has changed .github/workflows/build.yml since this branch was cut. Bringing the branch up to date (a merge or a rebase) carries that workflow change into the fork, and GitHub refuses such a push from the Hive App whatever the App is granted on this repository: the App is not installed on the fork. The change is inherited from main, not part of this PR's own diff. Moving the commits to hive/adopt-1313 in this repository instead would run code no maintainer has reviewed with the repository's trusted CI, so the hive did not. Ask (maintainer): bring the branch up to date with main yourself (Update branch on this PR, or gh pr update-branch 1313 -R projectbluefin/utah), or ask @Karibhou to. This PR also conflicts with main, so Update branch cannot do it alone: merge main into the branch locally, resolve the conflicts and push. The update is a merge, so the contributor's commits and sign-off stay, and the new head goes through CI, /test and review as usual.

The hive would move this to stage/085-needs-decision, but the write-back gate keeps its labels off this PR (backfill-off — #1313 was created 2026-11-16T06:52:46Z, before hive could write to projectbluefin/utah (2026-11-16T10:29:59Z); writeback.unsolicited.backfill is off), so no label changes here. The hive tracks it at stage/085-needs-decision and lists it on the dashboard so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds media sharing, so a Utah computer can stream music, videos and photos to TVs on the home network. It cannot work yet. The build still points at an older copy of the project's package store, and that copy does not have one of the packages media sharing needs. The automated package check fails at this revision for that reason. The description also says some tracking entries were removed, but the change doesn't remove them.

What I need from you: Point the build at a newer package store that includes gupnp-av, and fix the description.


correctness

  1. High: the pinned package store has no gupnp-av, so the package set can't be installed. Containerfile:6 still pins PACKAGE_IMAGE_SHA=sha256:e220319b…. The contract job ran on this head (fc5fed0, job 133146781319), and its just check-repos step fails while resolving packages/utah.toml:
    No match for argument: gupnp-av
    nothing provides libgupnp-av-1.0.so.3()(64bit) needed by rygel-46.1-1.hum1.bfin.x86_64 from utah-packages
    
    The factory request (utah-packages#1022) was closed on 2026-11-16, but this PR never moves the pin to a factory build that contains it. Fix: bump PACKAGE_IMAGE_SHA in Containerfile:6, and the matching # factory-pin: stamp in packages/utah-packages.repo (see Containerfile:146), to a factory digest that publishes gupnp-av. Another option is to rebase onto the routine pin-bump PR once it lands. Then re-run check-repos.

intent-alignment

  1. Low: the description claims a change the diff doesn't make. The body says it "Removes the planned triage entries for rygel and gupnp-dlna in baselines/triage.toml". The diff doesn't touch that file, and at head the entries are still there (baselines/triage.toml:133, :138, and gst-editing-services at :424). Keeping them is the right call for now. scripts/image-baseline.py check (:193-207, run by just check) fails on any baseline gap that has no triage entry, and the committed Utah snapshot still lists these packages as gaps (baselines/GAP.md:40,42,95). Removing the entries before the next just baselines refresh would break the check. Fix: reword the body: the entries stay until the baselines refresh, and then image-baseline.py check reports them as "no longer gaps". Also, "the CI package-availability step resolves the transaction" isn't true yet (see 1).

The counts in the README, docs/skills/package-contract.md and site/data/packages.json are consistent (255→259 and 316→320), and just check passed in that job. I didn't verify on a running system that GNOME Settings' Media Sharing switch works with the rygel.conf that ships in the RPM. An image can't be built until item 1 is fixed.

No findings from: security, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 high finding

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

@github-actions github-actions Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: The package change looks correct to me, and it does what #1258 asks. The PR conflicts with main and needs a rebase. When rebasing, recompute the counts rather than keep this branch's values.

What I checked

  • The four packages Dakota ships are added to [parity] in packages/utah.toml: rygel, gupnp-av, gupnp-dlna, gst-editing-services. These match baselines/dakota/elements.tsv:884,885,1004 and the list in #1258.
  • gupnp-av has a recipe in utah-packages (packages/gupnp-av/gupnp-av.spec), and utah-packages#1022 (an issue, not a PR) closed on 2026-11-16.
  • /etc/rygel.conf is expected to come from the rygel package itself, so no overlay file is added. That covers #1258's "ship /etc/rygel.conf as Dakota does", provided the package really installs that file.

Needs a rebase

  • PACKAGE_IMAGE_SHA / factory-pin (Containerfile:6, packages/utah-packages.repo:1): main already pins sha256:0b0664cb… (#1248), the same digest this PR sets. Those hunks drop out on rebase.
  • Stale counts. This branch changes 255 to 259 and 316 to 320, starting from merge-base d1f25ba. main is now at 260 (README.md:76) and 321 (site/data/packages.json:381). After the rebase, the values should be 264 and 325, or whatever the generator produces. Do not keep this branch's 259 and 320.

Small discrepancies, not blocking

  • The description says the planned triage entries for rygel, gupnp-dlna and gst-editing-services stay. In baselines/triage.toml, only rygel is planned (:54, under #1236). gupnp-dlna (:192) and gst-editing-services (:187) are untriaged. gupnp-av has no entry.

Not verified

No build or package-availability check ran on this head: only prow reported, and authorize was skipped for the fork. Nothing has shown that the pinned package image can resolve all four packages together. A maintainer would need to trigger that check after the rebase.

Confidence: 3/5 (needs attention) — 2 perspectives requested changes

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

@Karibhou

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged main at d5876bb1c5d11abdac412b6ca19bc30bdc11d05e into this PR and resolved the package inventory/count conflicts. The site inventory and documentation count checks pass.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change would let a Utah computer share its music, videos and photos with TVs and other devices on the home network, matching what Dakota (Bluefin's sibling system) already does. Since the last review the branch only picked up unrelated changes from the main line; the one blocker from last time is still there. One of the four new packages (a library the media-sharing service needs) is still missing from the fixed set of packages Utah builds from, so the image cannot be built with this change yet.

What I need from you: Bump the package pin to a factory publish that includes gupnp-av, then push. No other changes needed.


Re-reviewed at head dcadd32. The delta from 1ca04c6 is one merge of main (#1341, #1141, #1338, #1344, #1345, #1334). None of the PR's own files changed except through that merge. python3 scripts/check-doc-counts.py passes at head (61 / 272 / 6), and regenerating site/data/packages.json changes only generated_at.

Previous finding, re-checked:

  • [correctness] gupnp-av unavailable in the pinned package image: still present. The pin is unchanged since 1ca04c6: Containerfile:6 PACKAGE_IMAGE_SHA=sha256:744c4632… and packages/utah-packages.repo:4 # factory-pin: sha256:744c4632…. The PR body still says check-repos fails for this reason. CI's contract job, which runs the package-availability check, was still running on this head when I looked, so I have no fresh log to quote. Details in the inline thread.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 high finding

-- hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327

Comment thread packages/utah.toml
# the rygel.service user unit Settings starts; gupnp-av's factory recipe
# was added in utah-packages#1147.
"rygel",
"gupnp-av",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[correctness] Image can't build yet: gupnp-av is missing from the pinned package image. The factory recipe landed (utah-packages#1147), but Utah still builds from utah-packages@sha256:744c4632… (Containerfile:6, and packages/utah-packages.repo:4 stamps the same digest). That publish has no gupnp-av RPM. So just check-repos (Justfile:204, run by build.yml:124) fails, and the image build can't install rygel. rygel links against libgupnp-av, so dropping this one line would not help.

Fix: once a factory publish contains gupnp-av, bump both pins to that digest in this PR. Use the factory-pin rev tool (#337/#367), or take the Renovate digest bump and merge main:

--- a/Containerfile
+++ b/Containerfile
-ARG PACKAGE_IMAGE_SHA=sha256:744c4632cca27c059905779911b4db3269ff069825372c1ba6c8fbf6668ed3d0
+ARG PACKAGE_IMAGE_SHA=sha256:<digest of the publish carrying gupnp-av>
--- a/packages/utah-packages.repo
+++ b/packages/utah-packages.repo
-# factory-pin: sha256:744c4632cca27c059905779911b4db3269ff069825372c1ba6c8fbf6668ed3d0
+# factory-pin: sha256:<same digest>

Then re-run just check-repos and confirm it passes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new factory publish sha256:acfed6fc6c24247de0de9c6624cb3a87f9e24e411671f5521d93f498853cb5bf contains all four media-sharing RPMs. Its repository metadata confirms that gupnp-av provides the exact libgupnp-av-1.0.so.3()(64bit) required by Rygel. I tried both pins in an isolated copy: just check-repos got past the missing Rygel dependency but failed on a different dependency, ptyxis → vte291-gtk4 → missing libsimdutf.so.34()(64bit). I left the branch pins unchanged per the maintainer’s direction to take the validated factory bump from main.

@Karibhou

Copy link
Copy Markdown
Contributor Author

Rechecked the factory registry after the latest review: utah-packages:latest still resolves to sha256:744c4632cca27c059905779911b4db3269ff069825372c1ba6c8fbf6668ed3d0, the current pin that lacks gupnp-av. I left both pin locations unchanged. The contract check still needs a factory publication containing that RPM; dropping it would not fix Rygel’s dependency.

@Karibhou

Copy link
Copy Markdown
Contributor Author

Review follow-up: the requested factory publish is not yet the validated pin on main. The available publish containing gupnp-av still failed the full install transaction on ptyxis -> vte291-gtk4 -> libsimdutf.so.34; #1230 addresses that consumer rebuild. I am leaving both package pins unchanged until a factory image containing the complete closure is published and the routine pin reaches main, rather than push a known-failing digest.


🐝 Hive Agent: contributor | SHA: unknown

@Karibhou

Copy link
Copy Markdown
Contributor Author

Tested the latest factory image (sha256:03c2340b75d41179e549c18640ddff628854396631765055cedd56c674badbcb) through the PR’s install-transaction verifier. The Rygel dependency now resolves, but the full transaction still fails: gvfs-afc needs libplist-2.0.so.4 and vte291-gtk4 (via Ptyxis) needs libsimdutf.so.34. Utah main still pins 744c4632. I left both pin locations unchanged per the agreed policy; the next usable factory image must pass the full transaction before Utah takes the pin.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/hive decision the author's clanker has picked the rework up: make CI green without widening scope, address the changes the hive's review requested on this head on #1313; then it merges

Rationale: the author's clanker has picked the rework up, so the PR goes back to them with the fix list instead of being adopted (hivecommons/hive#15289).

Hive decided: Told the author agent what to change.
Why: The author's clanker or hive is connected; returned to them with the fix list.
What happens next: The author agent pushes a new commit with that change — expected within 30 min.
If it doesn't happen: Re-run the decision, give different direction, or close it.

Decided by the hive at @Danathar's request as the owner's delegate under the owner-delegate policy (rule return-to-contributor).

Karibhou and others added 3 commits November 20, 2026 07:46
Install rygel with gupnp-av, gupnp-dlna and gst-editing-services so
GNOME Settings > Sharing > Media Sharing works, as on Dakota. The rygel
package ships /etc/rygel.conf. Drop the now-installed planned triage
entries.

Assisted-by: GPT via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Run: projectbluefin#1258
Hive-Plan: parity(dakota) media sharing
Hive-Spec: utah-1258#install-rygel
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
rygel, gupnp-av, gupnp-dlna and gst-editing-services are factory-built
(utah-packages recipes, published since pin d9972fa), so [factory].parity
asserts their .bfin release like the rest of the factory parity set.
Regenerate site/data/packages.json and the README/package-contract counts.

Refs projectbluefin#1258

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parity(dakota): DLNA/UPnP media sharing (rygel)

3 participants