Repository navigation
feat(packages): add media sharing to TVs and home network devices (rygel) - #1313
Conversation
|
hive/awaiting-ci: CI pending — sweep will merge when green. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
|
hive/awaiting-ci: restored the rygel/gupnp-dlna triage entries (contract check reads the published image, which lacks them until this ships). CI pending — sweep will merge when green. |
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). The change itself looks right: rygel, gupnp-av, gupnp-dlna and gst-editing-services in [parity] give GNOME Settings' Media Sharing what Dakota ships (#1258), and /etc/rygel.conf and the user unit come from the rygel package. One fix needed: contract fails in just check, before package availability is checked, with site/data/packages.json is stale; regenerate with python3 scripts/generate-site-data.py (job). Adding packages to utah.toml changes the counts, so please run that script (and scripts/check-doc-counts.py if the README or package-contract counts move too) and push. Once that's green, check-repos will show whether all four resolve against the current pin. (The red Prow run on this PR is the hive's /ok-to-test being refused by Prow, not your change.)
|
Thanks @Danathar. I regenerated |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving; fc5fed0 regenerates site/data/packages.json and the README and package-contract counts, which was the one fix needed. contract was still running when I looked; its check-repos step is the one that confirms all four packages resolve against the pin, so let that go green before merge.
|
/ok-to-test |
|
Cannot /ok-to-test because Error: hivecommons-hive[bot] is not a reviewer or approver for any changed file |
|
Stand-in note: the count fix worked. What's left is availability: |
|
Thanks @Danathar. Agreed: the remaining |
|
@Karibhou the hive has adopted this PR ( |
|
The hive adopted this PR ( Blocker: this PR comes from a fork ( The hive would move this to |
There was a problem hiding this comment.
Summary: This change adds media sharing, so a Utah computer can stream music, videos and photos to TVs on the home network. It cannot work yet. The build still points at an older copy of the project's package store, and that copy does not have one of the packages media sharing needs. The automated package check fails at this revision for that reason. The description also says some tracking entries were removed, but the change doesn't remove them.
What I need from you: Point the build at a newer package store that includes gupnp-av, and fix the description.
correctness
- High: the pinned package store has no
gupnp-av, so the package set can't be installed.Containerfile:6still pinsPACKAGE_IMAGE_SHA=sha256:e220319b…. Thecontractjob ran on this head (fc5fed0, job 133146781319), and itsjust check-reposstep fails while resolvingpackages/utah.toml:The factory request (utah-packages#1022) was closed on 2026-11-16, but this PR never moves the pin to a factory build that contains it. Fix: bumpNo match for argument: gupnp-av nothing provides libgupnp-av-1.0.so.3()(64bit) needed by rygel-46.1-1.hum1.bfin.x86_64 from utah-packagesPACKAGE_IMAGE_SHAinContainerfile:6, and the matching# factory-pin:stamp inpackages/utah-packages.repo(seeContainerfile:146), to a factory digest that publishesgupnp-av. Another option is to rebase onto the routine pin-bump PR once it lands. Then re-runcheck-repos.
intent-alignment
- Low: the description claims a change the diff doesn't make. The body says it "Removes the
plannedtriage entries forrygelandgupnp-dlnainbaselines/triage.toml". The diff doesn't touch that file, and at head the entries are still there (baselines/triage.toml:133,:138, andgst-editing-servicesat:424). Keeping them is the right call for now.scripts/image-baseline.py check(:193-207, run byjust check) fails on any baseline gap that has no triage entry, and the committed Utah snapshot still lists these packages as gaps (baselines/GAP.md:40,42,95). Removing the entries before the nextjust baselinesrefresh would break the check. Fix: reword the body: the entries stay until the baselines refresh, and thenimage-baseline.py checkreports them as "no longer gaps". Also, "the CI package-availability step resolves the transaction" isn't true yet (see 1).
The counts in the README, docs/skills/package-contract.md and site/data/packages.json are consistent (255→259 and 316→320), and just check passed in that job. I didn't verify on a running system that GNOME Settings' Media Sharing switch works with the rygel.conf that ships in the RPM. An image can't be built until item 1 is fixed.
No findings from: security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
There was a problem hiding this comment.
Summary: The package change looks correct to me, and it does what #1258 asks. The PR conflicts with main and needs a rebase. When rebasing, recompute the counts rather than keep this branch's values.
What I checked
- The four packages Dakota ships are added to
[parity]inpackages/utah.toml:rygel,gupnp-av,gupnp-dlna,gst-editing-services. These matchbaselines/dakota/elements.tsv:884,885,1004and the list in #1258. gupnp-avhas a recipe in utah-packages (packages/gupnp-av/gupnp-av.spec), and utah-packages#1022 (an issue, not a PR) closed on 2026-11-16./etc/rygel.confis expected to come from therygelpackage itself, so no overlay file is added. That covers #1258's "ship/etc/rygel.confas Dakota does", provided the package really installs that file.
Needs a rebase
PACKAGE_IMAGE_SHA/factory-pin(Containerfile:6,packages/utah-packages.repo:1):mainalready pinssha256:0b0664cb…(#1248), the same digest this PR sets. Those hunks drop out on rebase.- Stale counts. This branch changes 255 to 259 and 316 to 320, starting from merge-base
d1f25ba.mainis now at 260 (README.md:76) and 321 (site/data/packages.json:381). After the rebase, the values should be 264 and 325, or whatever the generator produces. Do not keep this branch's 259 and 320.
Small discrepancies, not blocking
- The description says the
plannedtriage entries forrygel,gupnp-dlnaandgst-editing-servicesstay. Inbaselines/triage.toml, onlyrygelisplanned(:54, under #1236).gupnp-dlna(:192) andgst-editing-services(:187) areuntriaged.gupnp-avhas no entry.
Not verified
No build or package-availability check ran on this head: only prow reported, and authorize was skipped for the fork. Nothing has shown that the pinned package image can resolve all four packages together. A maintainer would need to trigger that check after the rebase.
Confidence: 3/5 (needs attention) — 2 perspectives requested changes
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
|
hive-base-moved: merged |
There was a problem hiding this comment.
Summary: This change would let a Utah computer share its music, videos and photos with TVs and other devices on the home network, matching what Dakota (Bluefin's sibling system) already does. Since the last review the branch only picked up unrelated changes from the main line; the one blocker from last time is still there. One of the four new packages (a library the media-sharing service needs) is still missing from the fixed set of packages Utah builds from, so the image cannot be built with this change yet.
What I need from you: Bump the package pin to a factory publish that includes gupnp-av, then push. No other changes needed.
Re-reviewed at head dcadd32. The delta from 1ca04c6 is one merge of main (#1341, #1141, #1338, #1344, #1345, #1334). None of the PR's own files changed except through that merge. python3 scripts/check-doc-counts.py passes at head (61 / 272 / 6), and regenerating site/data/packages.json changes only generated_at.
Previous finding, re-checked:
- [correctness]
gupnp-avunavailable in the pinned package image: still present. The pin is unchanged since1ca04c6:Containerfile:6PACKAGE_IMAGE_SHA=sha256:744c4632…andpackages/utah-packages.repo:4# factory-pin: sha256:744c4632…. The PR body still sayscheck-reposfails for this reason. CI'scontractjob, which runs the package-availability check, was still running on this head when I looked, so I have no fresh log to quote. Details in the inline thread.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 high finding
-- hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327
| # the rygel.service user unit Settings starts; gupnp-av's factory recipe | ||
| # was added in utah-packages#1147. | ||
| "rygel", | ||
| "gupnp-av", |
There was a problem hiding this comment.
[correctness] Image can't build yet: gupnp-av is missing from the pinned package image. The factory recipe landed (utah-packages#1147), but Utah still builds from utah-packages@sha256:744c4632… (Containerfile:6, and packages/utah-packages.repo:4 stamps the same digest). That publish has no gupnp-av RPM. So just check-repos (Justfile:204, run by build.yml:124) fails, and the image build can't install rygel. rygel links against libgupnp-av, so dropping this one line would not help.
Fix: once a factory publish contains gupnp-av, bump both pins to that digest in this PR. Use the factory-pin rev tool (#337/#367), or take the Renovate digest bump and merge main:
--- a/Containerfile
+++ b/Containerfile
-ARG PACKAGE_IMAGE_SHA=sha256:744c4632cca27c059905779911b4db3269ff069825372c1ba6c8fbf6668ed3d0
+ARG PACKAGE_IMAGE_SHA=sha256:<digest of the publish carrying gupnp-av>
--- a/packages/utah-packages.repo
+++ b/packages/utah-packages.repo
-# factory-pin: sha256:744c4632cca27c059905779911b4db3269ff069825372c1ba6c8fbf6668ed3d0
+# factory-pin: sha256:<same digest>Then re-run just check-repos and confirm it passes.
There was a problem hiding this comment.
The new factory publish sha256:acfed6fc6c24247de0de9c6624cb3a87f9e24e411671f5521d93f498853cb5bf contains all four media-sharing RPMs. Its repository metadata confirms that gupnp-av provides the exact libgupnp-av-1.0.so.3()(64bit) required by Rygel. I tried both pins in an isolated copy: just check-repos got past the missing Rygel dependency but failed on a different dependency, ptyxis → vte291-gtk4 → missing libsimdutf.so.34()(64bit). I left the branch pins unchanged per the maintainer’s direction to take the validated factory bump from main.
|
Rechecked the factory registry after the latest review: |
|
Review follow-up: the requested factory publish is not yet the validated pin on 🐝 Hive Agent: |
|
Tested the latest factory image ( |
|
/hive decision the author's clanker has picked the rework up: make CI green without widening scope, address the changes the hive's review requested on this head on #1313; then it merges Rationale: the author's clanker has picked the rework up, so the PR goes back to them with the fix list instead of being adopted (hivecommons/hive#15289). Hive decided: Told the author agent what to change. Decided by the hive at @Danathar's request as the owner's delegate under the owner-delegate policy (rule |
Install rygel with gupnp-av, gupnp-dlna and gst-editing-services so GNOME Settings > Sharing > Media Sharing works, as on Dakota. The rygel package ships /etc/rygel.conf. Drop the now-installed planned triage entries. Assisted-by: GPT via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Run: projectbluefin#1258 Hive-Plan: parity(dakota) media sharing Hive-Spec: utah-1258#install-rygel Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
rygel, gupnp-av, gupnp-dlna and gst-editing-services are factory-built (utah-packages recipes, published since pin d9972fa), so [factory].parity asserts their .bfin release like the rest of the factory parity set. Regenerate site/data/packages.json and the README/package-contract counts. Refs projectbluefin#1258 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary: This adds media sharing to Utah, so a computer can stream its music, videos and photos to TVs and other devices on the home network, the same way Dakota (Bluefin's sibling system) already does. It turns on the "Media Sharing" switch in the system Settings. The factory publishes rygel 46.1, gupnp-av 0.14.5, gupnp-dlna 0.12.0 and gst-editing-services 1.28.8 since pin
d9972fa(#1372), which is now on main.rygel,gupnp-av,gupnp-dlna,gst-editing-servicesin[parity]ofpackages/utah.toml..hum1.bfinin pind9972fa), so they are also in[factory].parity, which fails the build if one resolves anywhere else./etc/rygel.confcomes from therygelpackage itself (config file), matching Dakota; no overlay file needed.site/data/packages.jsonregenerated.rygel,gupnp-dlnaandgst-editing-servicesstay untiljust baselinesrefreshes; they are dropped after that refresh.Closes #1258
Maintainer edits
Rebased onto main after #1372 and added one commit (factory parity entries and counts); Karibhou's two commits are unchanged.
umask 022; just checkpassed.— hive: agent=scanner backend=omp model=openai-codex/gpt-6.1-terra