Repository navigation
feat(packages): add media sharing to TVs and home network devices (rygel) #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -648,6 +648,14 @@ packages = [ | |
| "bindfs", | ||
| "malcontent-tools", | ||
| "nfs-python-utils", | ||
| # DLNA/UPnP media sharing (GNOME Settings > Sharing > Media Sharing), as | ||
| # Dakota ships it (#1258). The rygel package carries /etc/rygel.conf and | ||
| # the rygel.service user unit Settings starts; gupnp-av's factory recipe | ||
| # was added in utah-packages#1147. | ||
| "rygel", | ||
| "gupnp-av", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correctness (still present):
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correctness (still present from previous review): Fix: bump
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correctness (still present from last review):
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still present at That means Fix: The fix does not belong in this diff. When the factory publishes an image that contains
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rechecked the registry:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rechecked the factory registry and both pin locations:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Merged current main in
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [correctness] Image can't build yet: Fix: once a factory publish contains --- a/Containerfile
+++ b/Containerfile
-ARG PACKAGE_IMAGE_SHA=sha256:744c4632cca27c059905779911b4db3269ff069825372c1ba6c8fbf6668ed3d0
+ARG PACKAGE_IMAGE_SHA=sha256:<digest of the publish carrying gupnp-av>
--- a/packages/utah-packages.repo
+++ b/packages/utah-packages.repo
-# factory-pin: sha256:744c4632cca27c059905779911b4db3269ff069825372c1ba6c8fbf6668ed3d0
+# factory-pin: sha256:<same digest>Then re-run
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new factory publish |
||
| "gupnp-dlna", | ||
| "gst-editing-services", | ||
| # | ||
| # Left out (resolved against sha256:d3b5bac2): | ||
| # tuned, tuned-ppd Dakota runs power-profiles-daemon, which is | ||
|
|
@@ -1163,4 +1171,9 @@ parity = [ | |
| "nfs-python-utils", | ||
| "google-noto-serif-cjk-vf-fonts", | ||
| "nerd-fonts-symbols", | ||
| # DLNA/UPnP media sharing (#1258). | ||
| "rygel", | ||
| "gupnp-av", | ||
| "gupnp-dlna", | ||
| "gst-editing-services", | ||
| ] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correctness (still present):
gupnp-avis not in the pinned package image yet. CIcontracton headc997c286failscheck-repos:No match for argument: gupnp-avandnothing provides libgupnp-av-1.0.so.3()(64bit) needed by rygel-46.1-1.hum1.bfin.x86_64.rygelhard-requires it, so dropping this line does not help.Fix: bump
PACKAGE_IMAGE_SHAinContainerfile:6to a utah-packages image digest built after utah-packages#1022 (or rebase once Renovate lands that bump onmain), then re-runjust check-repos:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch now includes main’s newer factory pin, sha256:744c4632, which is also the registry latest. The current contract run still fails: gupnp-av is absent and rygel cannot resolve libgupnp-av-1.0.so.3. A factory publication containing that RPM is still needed before the pin can be updated and contract can pass: https://github.com/projectbluefin/utah/actions/runs/44229337338/job/134550234432