Skip to content

feat(media): install gstreamer-plugins-rs, as Dakota ships it - #1307

Merged
hanthor merged 1 commit into
mainfrom
feat/dakota-gst-plugins-rs
Nov 20, 2026
Merged

hanthor merged 1 commit into
mainfrom
feat/dakota-gst-plugins-rs

Conversation

@hanthor

@hanthor hanthor commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Dakota ships freedesktop-sdk's gstreamer-plugins-rs. The factory builds it as one recipe (projectbluefin/utah-packages#1153) and pin 7339e87 (#1374) carries it.

What changed

  • [parity] and [factory].parity add gstreamer-plugins-rs (rsrtp, gif, hlssink3, spotify), next to the gstreamer1-plugin-dav1d already requested. Together they match the plugin set of Dakota's freedesktop-sdk.bst:components/gstreamer-plugins-rs.bst, which utah-packages#1153 builds with the element's options.
  • The contract [media].decoders adds dav1ddec, so the AV1 decoder must load (gst-inspect-1.0), not merely be installed.
  • Docs: desktop-contract.md [media]; counts regenerated.

Refs #12

Verification

  • umask 022; just check passed on main 58c0165e.
  • just check-repos passed against the 7339e87 pin.
  • No image was built locally.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

@hanthor this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (7 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
Danathar
Danathar previously approved these changes Nov 16, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Approving. It installs gstreamer-plugins-rs next to gstreamer1-plugin-dav1d and asserts dav1ddec loads. It matches Dakota's freedesktop-sdk element (rtp, gif, hlssink3, dav1d, spotify) and utah-packages#1153's options. dav1ddec already loads from the published gstreamer1-plugin-dav1d 0.15.0, so the assertion is safe, and no testsuite scenario mentions these plugins. Don't merge yet: gstreamer-plugins-rs isn't in the factory (checked 0b0664cb and the current latest) until #1153 publishes and the pin moves. The red contract here comes from the stack's older copy of #1248 (factory pin 523507b8), so rebase onto the current #1248 (0b0664cb) before reading it.

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds a set of extra video and streaming plugins (the same ones Dakota ships) and requires the AV1 video decoder to actually load on the image. Since the last review, the only change is a rebase onto newer main with the package counts updated to match, so the review still recommends approving it. The automated package check is red on this revision, but the cause is an unrelated package that is still on the "unavailable" list even though it now builds. That failure is not caused by this change.


Re-reviewed at 56ade138. Previous head was 14a1182c. The 150-file delta between them is main's own commits from the rebase. Diffing the PR's own patch at each head shows identical content. Only the hunk offsets and README/doc counts moved (57 base + 344 additions = 401, matching site/data/packages.json totals). The previous review had no findings, so nothing is fixed, still present, or no longer applicable. The factory pin at head is 7339e877… (packages/utah-packages.repo:4), as the body says. CI's resolve step installs gstreamer-plugins-rs 0.15.4-1.hum1.bfin and gstreamer1-plugin-dav1d from that pin.

correctness (out-of-scope, does not block)

  • The contract job on this head (job 136228047721) fails in just check-repos with this error: ERROR: 1 unavailable entries no longer describe reality: bluefin-cli: now resolves on the pinned inputs; move it out of [unavailable] into the contract. The entry is at packages/utah.toml:874, and its comment at :857 already says it should move to [parity]/[factory].parity once the pin carries it. This PR doesn't touch that entry or the pin, so the failure comes from main. The body's line "just check-repos passed against the 7339e87 pin" doesn't hold at this head, though. CI stays red until main moves bluefin-cli out of [unavailable]. The fix belongs in its own PR: move "bluefin-cli" from [unavailable].packages into [parity] and [factory].parity, then rerun generate-site-data.py and check-doc-counts.py --write.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

-- hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Hive filed review findings that do not block this PR as backlog items:

Cap: 3 backlog item(s) per PR.

Dakota ships freedesktop-sdk's gstreamer-plugins-rs (rsrtp, gif,
hlssink3, spotify, dav1d). The factory now builds it as one recipe
(utah-packages#1153), with gstreamer1-plugin-dav1d as a subpackage.
Install the main package beside the dav1d plugin Utah already requests,
and assert that dav1ddec loads.

Refs #12

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants